Ack, code review only.
Thanks,
Praveen
On 07-Apr-15 2:33 PM, nagendr...@oracle.com wrote:
> osaf/services/saf/amf/amfd/sgproc.cc | 8
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
>
> Amfd is not decrementing saAmfSINumCurrStandbyAssignments when
> HA state is changing from Qu
it was tested with an LSB compiler, but I can add the ifndef before
pushing. /Thanks HansN
On 04/27/2015 01:20 PM, Anders Widell wrote:
> Ack.
>
> Question: Did you try this with an LSB compiler? I am surprised it
> didn't complain about PR_SET_DUMPABLE. Maybe it would be good to add
> an #ifnd
Ack.
/ Anders Widell
On 04/22/2015 04:35 PM, Hans Nordeback wrote:
> bootstrap.sh| 2 +-
> osaf/services/saf/amf/amfd/main.cc | 2 +-
> osaf/services/saf/amf/amfnd/main.cc | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
>
> diff --git a/bootstrap.sh b
Ack.
Question: Did you try this with an LSB compiler? I am surprised it
didn't complain about PR_SET_DUMPABLE. Maybe it would be good to add an
#ifndef, just in case:
#ifndef PR_SET_DUMPABLE
#define PR_SET_DUMPABLE 4
#endif
/ Anders Widell
On 04/20/2015 02:52 PM, Hans Nordeback wrote:
> osa
osaf/services/saf/amf/amfd/chkop.cc | 4
osaf/services/saf/amf/amfd/main.cc | 6 +-
2 files changed, 9 insertions(+), 1 deletions(-)
Act Amfd initialization is said to be completed when
it completes its initialization with imm.
Apart from initializing with imm, Standby Amfd
also need
Summary: amfd: respond to nid only after initialization is completed [#1334]
Review request for Trac Ticket(s): #1334
Peer Reviewer(s): Mathi, Hans N, Praveen
Pull request to: <>
Affected branch(es): All
Development branch: Default
Impacted area Impact y/n
--
osaf/libs/agents/saf/imma/imma_cb.h | 2 +-
osaf/libs/agents/saf/imma/imma_proc.c | 5 -
2 files changed, 5 insertions(+), 2 deletions(-)
The member imma_client_node->replyPending was in OpenSAF4.1 and earlier
defined as 'uns8', i.e. a byte. But this member is a counter and not a boolean
Summary: immsv: Revert imma_client_node->replyPending to unsigned char [#1341]
Review request for Trac Ticket(s): 1341
Peer Reviewer(s): Neel; Zoran
Pull request to:
Affected branch(es): 4.5; 4.6; default(4.7)
Development branch:
Impacted area Impact y/n
--
