Re: [devel] [PATCH 0 of 5] Review Request for imm: remove all use of SaNameT from IMM server side and messages [#969]

2015-05-06 Thread Hung Nguyen
Hi Neel, The new member isProto47 of IMMA_CLIENT_NODE is not the same with the members like isImmA2b, isImmA2d... It is used to check if the proto47 is enabled at handle initialization. Since only IMMND knows about proto47 so clients have to get that from IMMND. Best Regards, Hung Nguyen DEK T

[devel] [PATCH 1 of 1] osaf: During adminrestart of node directors, before re-instantiating kill them [#1326]

2015-05-06 Thread mathi . naickan
osaf/services/saf/cpsv/cpnd/cpnd_amf.c | 14 +- osaf/services/saf/cpsv/cpnd/scripts/osaf-ckptnd.in | 13 + osaf/services/saf/glsv/glnd/glnd_amf.c | 14 ++ osaf/services/saf/glsv/glnd/scripts/osaf-lcknd.in | 13 + osaf

[devel] [PATCH 0 of 1] Review Request for osaf: During adminrestart of node directors, before re-instantiating kill them [#1326]

2015-05-06 Thread mathi . naickan
Summary: osaf: During adminrestart of node directors, before re-instantiating kill them [#1326] Review request for Trac Ticket(s): #1326 Peer Reviewer(s): AndersW, Ramesh - General aspects. HansN,Nagendra, Praveen from AMF perspective Pull request to: <> Affected branch(es): opensaf-4.5.x, 4.6.x,

[devel] [PATCH 0 of 1] Review Request for IMM: Support admin-op for aborting non critical ccbs [#1107]

2015-05-06 Thread Anders Bjornerstedt
Summary: IMM: Support admin-op for aborting non critical ccbs [#1107] Review request for Trac Ticket(s): 1107 Peer Reviewer(s): Neel; Zoran Pull request to: Affected branch(es): default(4.7) Development branch: default Impacted area Impact y/n --

[devel] [PATCH 1 of 1] IMM: Support admin-op for aborting non critical ccbs [#1107]

2015-05-06 Thread Anders Bjornerstedt
osaf/libs/common/immsv/include/immsv_api.h | 5 +- osaf/services/saf/immsv/README | 33 +--- osaf/services/saf/immsv/immnd/ImmModel.cc | 47 +++-- osaf/services/saf/immsv/immnd/ImmModel.hh | 5 +- 4 files changed, 71 insertions(+), 19 del

Re: [devel] [PATCH 1 of 1] nid: cleanup should generate a core dump V3 [#1300]

2015-05-06 Thread Mathivanan Naickan Palanivelu
Okay, Thanks, Mathi. - hans.nordeb...@ericsson.com wrote: > Hi Mathi, > > is it ok to push this patch? I'll add the documentation AndersW > mentioned. /Thanks HansN > > On 05/06/2015 12:17 PM, Anders Widell wrote: > > Ack with minor comment: The documentation for the function > > spawn_wa

Re: [devel] [PATCH 1 of 1] nid: cleanup should generate a core dump V3 [#1300]

2015-05-06 Thread Hans Nordebäck
Hi Mathi, is it ok to push this patch? I'll add the documentation AndersW mentioned. /Thanks HansN On 05/06/2015 12:17 PM, Anders Widell wrote: > Ack with minor comment: The documentation for the function > spawn_wait() should be updated to say that NCSCC_RC_REQ_TIMEOUT is a > possible return

Re: [devel] [PATCH 1 of 1] nid: cleanup should generate a core dump V3 [#1300]

2015-05-06 Thread Anders Widell
Ack with minor comment: The documentation for the function spawn_wait() should be updated to say that NCSCC_RC_REQ_TIMEOUT is a possible return code. / Anders Widell On 04/30/2015 03:13 PM, Hans Nordeback wrote: > osaf/services/infrastructure/nid/nodeinit.c | 56 > +++---

Re: [devel] [PATCH 1 of 1] amfd: avoid null pointer access [#1365]

2015-05-06 Thread Hans Nordebäck
ack, code review only/Thanks HansN On 05/05/2015 12:55 PM, nagendr...@oracle.com wrote: > osaf/services/saf/amf/amfd/role.cc | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > > During node failover if node is not found at amfd, > then my_node remains null and amfd access it in th

Re: [devel] [PATCH 1 of 1] amfd: send data verify message to node in NO_CONFIG and NCS_INIT also [#1359]

2015-05-06 Thread Hans Nordebäck
Hi Nagu, please see below. /Thanks HansN On 05/06/2015 10:51 AM, Nagendra Kumar wrote: > > Hi Hans N, > > >> perhaps the comment above the change need to be updated > > I didn’t get it. Please specify the comment you are pointing. > > Thanks > > -Nagu > > *From:*Hans Nordebäck [mailto:hans.norde

Re: [devel] [PATCH 1 of 1] amfd: send data verify message to node in NO_CONFIG and NCS_INIT also [#1359]

2015-05-06 Thread Nagendra Kumar
Hi Hans N,   >> perhaps the comment above the change need to be updated I didn't get it. Please specify the comment you are pointing.   Thanks -Nagu   From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] Sent: 05 May 2015 17:21 To: Nagendra Kumar; Praveen Malviya Cc: opensaf-devel@lis

Re: [devel] [PATCH 1 of 1] imm: update document for OI callback timeout [#1347]

2015-05-06 Thread Anders Björnerstedt
Ack from me. /AndersBj -Original Message- From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com] Sent: den 5 maj 2015 14:42 To: reddy.neelaka...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 1 of 1] imm: update document for OI callback timeout [#1347]

Re: [devel] [PATCH 1 of 1] amfd: node rebooted when immnd is killed twice in succession [#1290]

2015-05-06 Thread Hans Nordebäck
Hi Nagu, The handling of BAD_HANDLE should be equal to handling of TRY_AGAIN and preferably supported in immutil, (perhaps an enhancement ticket for immutil?) Anyhow I sent out a version 2 of this patch that uses the default values from ImmUtilWrapperProfile. The number of retries and retry int

[devel] [PATCH 1 of 1] amfd: node rebooted when immnd is killed twice in succession V2 [#1290]

2015-05-06 Thread Hans Nordeback
osaf/services/saf/amf/amfd/imm.cc | 80 +++--- 1 files changed, 56 insertions(+), 24 deletions(-) Use defaults from immutilWrapperProfile. diff --git a/osaf/services/saf/amf/amfd/imm.cc b/osaf/services/saf/amf/amfd/imm.cc --- a/osaf/services/saf/amf/amfd/imm.cc

[devel] [PATCH 0 of 1] Review Request for amfd: node rebooted when immnd is killed twice in succession V2 [#1290]

2015-05-06 Thread Hans Nordeback
Summary: amfd: node rebooted when immnd is killed twice in succession V2 Review request for Trac Ticket(s): #1290 Peer Reviewer(s): Nagu, Praveen Pull request to: Affected branch(es): default Development branch: default Impacted area Impact y/n

Re: [devel] [PATCH 1 of 1] amfd: Support lock-in and unlock-in on nodegroup V2 [#1327]

2015-05-06 Thread Hans Nordebäck
Hi Praveen, you mean that we can use version 1 of this patch then add your modified.patch on top of it and ignore version 2? /Thanks HansN On 05/05/2015 03:06 PM, praveen malviya wrote: > > > On 28-Apr-15 4:39 PM, Hans Nordeback wrote: >> osaf/services/saf/amf/amfd/include/node.h |1 + >> o

[devel] [PATCH 1 of 1] LOG: Fix unable to rename cfg file when changing saLogStreamFileName attribute [#1346]

2015-05-06 Thread Vu Minh Nguyen
osaf/services/saf/logsv/lgs/lgs_imm.c | 36 -- 1 files changed, 29 insertions(+), 7 deletions(-) As expectation, LOG server should close the old cfg file and opening log file, then creating new cfg/log files. But It failed to rename the configuration file. The

[devel] [PATCH 0 of 1] Review Request for LOG: Unnable to rename cfg file when changing saLogStreamFileName attribute [#1346]

2015-05-06 Thread Vu Minh Nguyen
Summary: LOG: Unable to rename cfg file when changing saLogStreamFileName attribute [#1346] Review request for Trac Ticket(s): #1346 Peer Reviewer(s): mathi.naic...@oracle.com, lennart.l...@ericsson.com Pull request to: lennart.l...@ericsson.com Affected branch(es): 4.5, 4.6, default Development b