Re: [devel] [PATCH 00 of 48] Review Request for amfd: convert NULL to nullptr V2 [#1547]

Hi Long, patch is now pushed/Thanks HansN On 11/12/2015 01:29 PM, Long Nguyen wrote: > Hi Hans, > > You and Praveen ack'ed for this series. Can you please help to push > the code to the repository? I have zip'ed the patches for AMFD in the > attachment. > Because many files have been changed, it

Re: [devel] [PATCH 00 of 30] Review Request for amfnd: convert NULL to nullptr [#1551]

Hi Long, patch is now pushed/Thanks HansN On 11/12/2015 01:30 PM, Long Nguyen wrote: > Hi Hans, > > Can you please also push the code for AMFND? Thanks so much. > > Best regards, > Long Nguyen. > > On 10/27/2015 7:09 PM, Hans Nordebäck wrote: >> Ack for the series, code review only/Thanks HansN >>

Re: [devel] [PATCH 1 of 1] amfd: set node oper state to enable during clm unlock [#1567]

ack, code review only/Thanks HansN On 11/02/2015 01:02 PM, nagendr...@oracle.com wrote: > osaf/services/saf/amf/amfd/clm.cc | 4 +++- > osaf/services/saf/amf/amfd/nodegroup.cc | 7 --- > 2 files changed, 7 insertions(+), 4 deletions(-) > > > During Clm unlock, Amf is not marking no

Re: [devel] [PATCH 00 of 30] Review Request for amfnd: convert NULL to nullptr [#1551]

Hi Hans, Can you please also push the code for AMFND? Thanks so much. Best regards, Long Nguyen. On 10/27/2015 7:09 PM, Hans Nordebäck wrote: Ack for the series, code review only/Thanks HansN -Original Message- From: Long HB Nguyen [mailto:long.hb.ngu...@dektech.com.au] Sent: den 20 o

Re: [devel] [PATCH 1 of 1] amfd: check for admin state for all nodegroup [#1563]

ack, code review only. Minor comment below/Thanks HansN On 10/30/2015 01:54 PM, nagendr...@oracle.com wrote: > osaf/services/saf/amf/amfd/node.cc | 6 -- > osaf/services/saf/amf/amfd/nodegroup.cc | 4 > 2 files changed, 8 insertions(+), 2 deletions(-) > > > Amf is not checking

Re: [devel] [PATCH 1 of 1] amfd: adjust NPI app configuration during unlock-in op [#1564]

Ack, code review only/Thanks HansN -Original Message- From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com] Sent: den 28 oktober 2015 13:33 To: Hans Nordebäck; nagendr...@oracle.com; Gary Lee Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1] amfd: adjust NPI a

Re: [devel] [PATCH 1 of 1] cpsv: validated SaTimeT timeout argument value for all CPA APIs [#1583]

Ack with minor comments inlined. Thanks -Nagu > -Original Message- > From: Venkata Mahesh Alla > Sent: 06 November 2015 11:04 > To: Nagendra Kumar; Ramesh Babu Betham > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] cpsv: validated SaTimeT timeout argument value for > a

Re: [devel] [PATCH 1 of 1] amfd: remove duplicate code in node_fail_sg_relgn [#1520]

ack, code review only. /Thanks HansN On 11/12/2015 06:31 AM, Gary Lee wrote: > osaf/services/saf/amf/amfd/include/sg.h |2 + > osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 230 > -- > 2 files changed, 39 insertions(+), 193 deletions(-) > > > diff --git a/osaf/s