Re: [devel] [PATCH 1 of 1] cpsv: improve handling unlink and close non-collocated checkpoint [#1616]

2016-01-04 Thread A V Mahesh
Hi Nhat Pham, On 1/5/2016 10:00 AM, Nhat Pham wrote: > RE: [devel] [PATCH 1 of 1] cpsv: improve handling unlink and close > non-collocated checkpoint [#1616] > > Hi Mahesh, > > By looking to the ticket #1616 description again, I think the scenario > and the cause of the problem that you mention

Re: [devel] [PATCH 1 of 1] cpsv: improve handling unlink and close non-collocated checkpoint [#1616]

2016-01-04 Thread Nhat Pham
Hi Mahesh, By looking to the ticket #1616 description again, I think the scenario and the cause of the problem that you mention is quite different with the ones in the #1616. It would be clearer if this problem is fixed in a new ticket. How would you think? Best regards, Nhat Pham Fro

Re: [devel] [PATCH 1 of 1] cpsv: improve handling unlink and close non-collocated checkpoint [#1616]

2016-01-04 Thread Nhat Pham
Hi Mahesh, I’ll include the fix in the new patch for this ticket and send it to you for review. Best regards, Nhat Pham From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Tuesday, January 5, 2016 10:46 AM To: Nhat Pham ; opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [P

Re: [devel] [PATCH 1 of 1] cpsv: improve handling unlink and close non-collocated checkpoint [#1616]

2016-01-04 Thread A V Mahesh
Hi Nhat Pham, On 1/5/2016 8:19 AM, Nhat Pham wrote: > > But the replica IMM objects are not created.This is because when > unlink the checkpoint, theCPD doesn’t delete relating > nodesfromckpt_reploc_tree. > > This should be fixed too. > We will do in a New ticket ? or you would like to adde

Re: [devel] [PATCH 1 of 1] cpsv: improve handling unlink and close non-collocated checkpoint [#1616]

2016-01-04 Thread Nhat Pham
Hi Mahesh, For the case you described below, a new replica is created with same name. root@PL-3:~# ll /run/shm total 696 drwxrwxrwt 2 root root100 Jan 5 09:02 ./ drwxr-xr-x 11 root root440 Jan 5 09:01 ../ -rw-r--r-- 1 root root 704008 Jan 5 09:00 opensaf_CPND_CHECKPOINT_INFO_131855 -

Re: [devel] [PATCH 1 of 1] cpsv: validated SaTimeT timeout argument value for all CPA APIs [#1583]

2016-01-04 Thread A V Mahesh
Hi Anders Widell, Please find my answers. On 1/4/2016 2:20 PM, Anders Widell wrote: > Ok good, that will solve the backwards compatibility issue! Though I > still don't understand what the problem would be if we let the > function time out at the time specified by the user, even when the > use

[devel] [PATCH 1 of 1] cpsv: Support preserving and recovering checkpoint replicas during headless state [#1621]

2016-01-04 Thread Nhat Pham
osaf/libs/agents/saf/cpa/cpa_proc.c | 52 osaf/libs/common/cpsv/cpsv_edu.c | 43 osaf/libs/common/cpsv/include/cpd_cb.h|3 + osaf/libs/common/cpsv/include/cpd_imm.h |1 + osaf/libs/common/cpsv/include/cpd_proc.h |7 + osaf/libs/common/cpsv/include/cp

[devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

2016-01-04 Thread Nhat Pham
Summary: cpsv: Support preserving and recovering checkpoint replicas during headless state [#1621] Review request for Trac Ticket(s): #1621 Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com Pull request to: mahesh.va...@oracle.com Affected branch(es): default Development branch

Re: [devel] [PATCH 0 of 1] Review Request for base: Add osaf_timerfd_* utility functions [#777]

2016-01-04 Thread Anders Widell
Hi Ramesh! Have you had time to look at this yet? regards, Anders Widell On 12/22/2015 05:03 PM, Anders Widell wrote: > Summary: base: Add osaf_timerfd_* utility functions [#777] > Review request for Trac Ticket(s): 777 > Peer Reviewer(s): Ramesh > Pull request to: > Affected branch(es): default

Re: [devel] [PATCH 0 of 3] Review Request for Simplify osaf_nanosleep() and add new time constants [#777]

2016-01-04 Thread Anders Widell
Hi Ramesh! Do you have any comments on this review? regards, Anders Widell On 12/10/2015 11:38 AM, Anders Widell wrote: > Summary: Simplify osaf_nanosleep() and add new time constants > Review request for Trac Ticket(s): 777 > Peer Reviewer(s): Ramesh, Hans > Pull request to: > Affected branch(e

Re: [devel] [PATCH 1 of 1] cpsv: validated SaTimeT timeout argument value for all CPA APIs [#1583]

2016-01-04 Thread Anders Widell
Ok good, that will solve the backwards compatibility issue! Though I still don't understand what the problem would be if we let the function time out at the time specified by the user, even when the user wants us to time out after less than fourteen seconds. If we go for a new API version, woul

Re: [devel] [PATCH 1 of 1] core: Add unit test for sysf_ipc.c V3 [#1520]

2016-01-04 Thread Mathivanan Naickan Palanivelu
Ack, Mathi. > -Original Message- > From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] > Sent: Wednesday, November 25, 2015 11:03 PM > To: Mathivanan Naickan Palanivelu; Ramesh Babu Betham; > anders.wid...@ericsson.com > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of