[devel] [PATCH 0 of 1] Review Request for amfd: delete su and its child objects at stdby amfd [#1683]

Summary: amfd: delete su and its child objects at stdby amfd [#1683] Review request for Trac Ticket(s): #1683 Peer Reviewer(s): Amf maintainers Pull request to: <> Affected branch(es): All Development branch: 4.7.x Impacted area Impact y/n --

[devel] [PATCH 1 of 1] amfd: delete su and its child objects at stdby amfd [#1683]

osaf/services/saf/amf/amfd/comp.cc| 2 +- osaf/services/saf/amf/amfd/include/comp.h | 1 + osaf/services/saf/amf/amfd/include/su.h | 2 +- osaf/services/saf/amf/amfd/node.cc| 54 +++ osaf/services/saf/amf/amfd/su.cc | 2 +- osaf/servi

Re: [devel] [PATCH 03 of 15] amfd: Add support for cloud resilience at director [#1620]

Hi, I made a mistake in rebase the patch, that I reverted fix of #1595 (the last diff) I'll remove that last diff in next version. Thanks, Minh On 25/02/16 19:44, Minh Hon Chau wrote: > osaf/services/saf/amf/amfd/cluster.cc| 48 +++- > osaf/services/saf/amf/amfd/comp.cc

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

Hi Nhat Pham, Please find my answers. -AVM On 2/26/2016 10:23 AM, Nhat Pham wrote: > > Hi Mahesh, > > Please see my answers below with [NhatPham5] > > Best regards, > > Nhat Pham > > *From:*A V Mahesh [mailto:mahesh.va...@oracle.com] > *Sent:* Friday, February 26, 2016 11:17 AM > *To:* Nhat Ph

Re: [devel] [PATCH 1 of 1] imm: Remove coordinator role when SC absence happens [#1625]

Hi Hung, Reviewed and tested the patch. Following are the comments: 1. This patch has to go in a separate defect,After #1625 is pushed. 2. re-publish the patch with the comments when the defect is opened 3. Comments inline. Thanks, Neel. On Thursday 25 February 2016 05:29 PM, Hung Nguyen wrote:

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

Hi Mahesh, Please see my answers below with [NhatPham5] Best regards, Nhat Pham From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Friday, February 26, 2016 11:17 AM To: Nhat Pham ; 'Anders Widell' Cc: opensaf-devel@lists.sourceforge.net; 'Beatriz Brandao' ; 'Minh Chau H' Subje

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

Hi Nhat Pham, >>[NhatPham4] To be more correct, the application will get >>SA_AIS_ERR_BAD_HANDLE when trying to access the lost checkpoint because all data was destroyed. >>[AndersW4] If this is a problem we could re-create the checkpoint with no sections in it. Even I come across this

Re: [devel] [PATCH 2 of 5] amfd: Add support for cloud resilience at director [#1620] V2

Hi Praveen, We have been lost in emails of #1620, sorry for late reply. V4 has been sent out though your comments here are still valid on V4. So please find our comments inline with [Gary] and [Minh] Thanks, Gary/Minh On 11/02/16 22:15, praveen malviya wrote: > Hi Minh, > > Please find some init

Re: [devel] Build error on default branch

Hi Anders, The problem was reported in the ticket 1666. https://sourceforge.net/p/opensaf/tickets/1666/ The fix was sent out for review. Please get the patch from the attachment. Best regards, Nhat Pham -Original Message- From: Anders Widell [mailto:anders.wid...@ericsson.com] Sent: Fri

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

Hi, Please see my comment below with [NhatPham4] Best regards, Nhat Pham From: Anders Widell [mailto:anders.wid...@ericsson.com] Sent: Thursday, February 25, 2016 9:25 PM To: A V Mahesh ; Nhat Pham Cc: opensaf-devel@lists.sourceforge.net; 'Beatriz Brandao' ; 'Minh Chau H' Subject: R

[devel] [PATCH 0 of 1] Review Request for log: Extend information about origin of log record [#1480]

Summary: log: Extend information about origin of log record [#1480] Review request for Trac Ticket(s): #1468 Peer Reviewer(s): Lennart, Anders W, Mathi Pull request to: Lennart Affected branch(es): Default Development branch: Default Impacted area Impact y/n

[devel] [PATCH 1 of 1] log: Extend information about origin of log record [#1480]

osaf/services/saf/logsv/README |16 + osaf/services/saf/logsv/config/Makefile.am | 4 +- osaf/services/saf/logsv/config/gcfg_classes.xml |18 + osaf/services/saf/logsv/config/gcfg_objects.xml | 6 + osaf/services/saf/logsv/lgs/Makefile.am | 6 +- o

[devel] Build error on default branch

Hi! I get the following build error on the default branch when building with GCC 4.8.4 and optimization level -O3 : In file included from /usr/include/string.h:640:0, from ../../../../osaf/libs/core/include/os_defs.h:39, from ../../../../osaf/libs/core/include

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

See my comments, marked [AndersW5]. regards, Anders Widell On 02/25/2016 11:09 AM, Nhat Pham wrote: > > Hi Mahesh and Anders, > > Please see my comment below with [NhatPham3] > > Best regards, > > Nhat Pham > > *From:*A V Mahesh [mailto:mahesh.va...@oracle.com] > *Sent:* Thursday, February 25, 20

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

Hi! See my comments inline, marked [AndersW4]. regards, Anders Widell On 02/25/2016 05:26 AM, A V Mahesh wrote: > Hi Nhat Pham, > > Please see my comment below. > > -AVM > > On 2/25/2016 7:54 AM, Nhat Pham wrote: >> >> Hi Mahesh, >> >> Would you agree with the comment below? >> >> To summarize,

[devel] [PATCH 0 of 1] Review Request for amfa: Divide amf api functions in a thin C layer and use C++ for implementation V2 [#1673]

Summary:amfa: Divide amf api functions in a thin C layer and use C++ for implementation V2 Review request for Trac Ticket(s): #1673 Peer Reviewer(s): Nagu, Praveen, Mathi, AndersW, Gary, Minh Pull request to: Affected branch(es): default Development branch: default --

[devel] [PATCH 1 of 1] imm: Remove coordinator role when SC absence happens [#1625]

osaf/services/saf/immsv/immnd/immnd_evt.c | 13 +-- osaf/services/saf/immsv/immnd/immnd_init.h | 1 + osaf/services/saf/immsv/immnd/immnd_proc.c | 55 - 3 files changed, 55 insertions(+), 14 deletions(-) Set 'mIsCoord' to false when headless to avoid coordina

[devel] [PATCH 0 of 1] Review Request for imm: Remove coordinator role when SC absence happens [#1625]

Summary: imm: Remove coordinator role when SC absence happens [#1625] Review request for Trac Ticket(s): 1625 Peer Reviewer(s): Zoran, Neel Pull request to: Affected branch(es): 5.0 Development branch: 5.0 Impacted area Impact y/n ---

Re: [devel] [PATCH 1 of 4] log: add support for cloud resilience feature (service part) [#1179]

Ack, Iam not yet through with the testing, but you please go ahead to push the patch as you deem appropriate. Thanks, Mathi. - vu.m.ngu...@dektech.com.au wrote: > Sorry. Please take this attach. > > Regards, Vu. > > > >-Original Message- > >From: Vu Minh Nguyen [mailto:vu.m.ngu..

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

Fine. Please publish the v3 patch. -AVM On 2/25/2016 3:50 PM, Nhat Pham wrote: > Hi Mahesh, > > Please see my answers below with [NhatPham4] > > Best regards, > Nhat Pham > > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Thursday, February 25, 2016 4:31

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

Hi Nhat Pham, Well In any case let's go forward as below: (a) For now, let's just document that 'sackptCheckpoint' APis will return ERR_NOT_EXIST in the headless state. In future we can look at ways to create more than two replicas (b) for the cpnd restart scenario, w.r.t CPSV-CLM integration,

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

Hi Mahesh, Please see my answers below with [NhatPham4] Best regards, Nhat Pham -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Thursday, February 25, 2016 4:31 PM To: Nhat Pham ; 'Anders Widell' Cc: 'Beatriz Brandao' ; 'Minh Chau H' ; opensaf-devel@lists.sour

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

Hi Mahesh and Anders, Please see my comment below with [NhatPham3] Best regards, Nhat Pham From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Thursday, February 25, 2016 2:14 PM To: Nhat Pham ; 'Anders Widell' Cc: opensaf-devel@lists.sourceforge.net; 'Beatriz Brandao' ; 'Minh Ch

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

Hi Nhat Pham, >> With this patch the CPND detects un-recoverable checkpoints and deletes them all from the DB in case the headless state happens. By the way I didn't tested some cases, can you clarify below : - which error will be revived by cpsv application of PL , for the unrecoverable

[devel] [PATCH 11 of 15] amf: Fix various amfnd coredump and mapping SU [#1620]

osaf/services/saf/amf/amfd/role.cc | 10 osaf/services/saf/amf/amfd/sgproc.cc | 2 +- osaf/services/saf/amf/amfd/siass.cc | 4 ++- osaf/services/saf/amf/amfnd/err.cc | 37 ++- osaf/services/saf/amf/amfnd/susm.cc | 20 -- 5 files

[devel] [PATCH 01 of 15] amfd: Add support for cloud resilience at common libs [#1620]

osaf/libs/common/amf/d2nedu.c| 311 -- osaf/libs/common/amf/d2nmsg.c| 266 +++ osaf/libs/common/amf/include/Makefile.am |1 + osaf/libs/common/amf/include/amf_d2nedu.h| 16 + osaf/libs/common/amf/include/am

[devel] [PATCH 03 of 15] amfd: Add support for cloud resilience at director [#1620]

osaf/services/saf/amf/amfd/cluster.cc| 48 +++- osaf/services/saf/amf/amfd/comp.cc |8 +- osaf/services/saf/amf/amfd/csi.cc| 105 +++ osaf/services/saf/amf/amfd/imm.cc| 58 osaf/services/saf/amf/amfd/include/cb.h

[devel] [PATCH 15 of 15] imported patch 1620_README_V4.diff

osaf/services/saf/amf/README_HEADLESS | 172 ++ 1 files changed, 172 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/amf/README_HEADLESS b/osaf/services/saf/amf/README_HEADLESS new file mode 100644 --- /dev/null +++ b/osaf/services/saf/amf/README_HE

[devel] [PATCH 14 of 15] amfd: Treat su fault if inconsistency of csi between amfd and amfnd [#1620]

osaf/services/saf/amf/amfd/csi.cc | 14 +- osaf/services/saf/amf/amfd/include/su.h | 2 +- osaf/services/saf/amf/amfd/sg.cc| 6 +- osaf/services/saf/amf/amfd/su.cc| 1 + 4 files changed, 20 insertions(+), 3 deletions(-) The problem happens if csi is d

[devel] [PATCH 08 of 15] amfd: Adjust uncompleted admin command after headless [#1620]

osaf/services/saf/amf/amfd/cluster.cc | 6 + osaf/services/saf/amf/amfd/include/node.h | 6 +- osaf/services/saf/amf/amfd/include/sg.h | 2 +- osaf/services/saf/amf/amfd/node.cc| 35 +++ osaf/services/saf/amf/amfd/nodegroup.cc | 16 + osaf/services/saf/amf/amfd/

[devel] [PATCH 09 of 15] amfnd: Return TRY_AGAIN for saAmfProtectionGroupTrack and saAmfProtectionGroupTrackStop [#1620]

osaf/services/saf/amf/amfnd/pg.cc | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) Patch returns TRY_AGAIN for saAmfProtectionGroupTrack and saAmfProtectionGroupTrackStop during headless since the proctection group tracking requires amfd's presence diff --git a/osaf/

[devel] [PATCH 07 of 15] amfd: Support delayed si_dep [#1620]

osaf/services/saf/amf/amfd/cluster.cc | 10 + osaf/services/saf/amf/amfd/include/sg.h | 1 + osaf/services/saf/amf/amfd/sg.cc| 56 + 3 files changed, 67 insertions(+), 0 deletions(-) si_dep is configured in cluster and it could be broken due to s

[devel] [PATCH 13 of 15] amfd: Reboot cluster at data inconsistency [#1620]

osaf/services/saf/amf/amfd/include/util.h | 1 + osaf/services/saf/amf/amfd/siass.cc | 9 - osaf/services/saf/amf/amfd/util.cc| 22 ++ osaf/services/saf/amf/amfnd/amfnd.cc | 3 ++- osaf/services/saf/amf/amfnd/mds.cc| 3 ++- 5 files ch

[devel] [PATCH 05 of 15] amfnd: Support component/su failover [#1620]

osaf/services/saf/amf/amfnd/err.cc | 80 +++--- 1 files changed, 40 insertions(+), 40 deletions(-) If any error escalates to component/su failover during headless, amfnd reboot node. The issue is other healthy SUs get affected by this reboot, and this degrades t

[devel] [PATCH 00 of 15] Review Request for AMF: Add support for cloud resilience [#1620] V4

Summary: AMF: Add support for cloud resilience [#1620] V4 Review request for Trac Ticket(s): 1620 Peer Reviewer(s): Hans N, Gary, Nagu, Praveen Pull request to: AMF maintainers Affected branch(es): default Development branch: default Impacted area Impact y/n

[devel] [PATCH 12 of 15] amfd: Don't disable healthy SU [#1620]

osaf/services/saf/amf/amfnd/su.cc | 8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) This scenario happen if unlock-in SU before going headless. After headless, amfnd sends SU oper state DISABLE in recovery data. The patch comments out the suspicious setting SU's oper state to DISA

[devel] [PATCH 02 of 15] amfd: Add saAmfUnassignedAlarmStatus attribute to memorize the alarm_sent status [#1620]

osaf/services/saf/amf/config/amf_classes.xml | 8 1 files changed, 8 insertions(+), 0 deletions(-) If the SI Unassigned Alarm is raised before headless by locking SU for instance, then after cluster recovers from headless and unlocking the SU, this alarm is not cleared. As the applic

[devel] [PATCH 10 of 15] amfnd: Resend pg information after headless [#1620]

osaf/services/saf/amf/amfnd/di.cc | 36 + osaf/services/saf/amf/amfnd/include/avnd_di.h | 1 + osaf/services/saf/amf/amfnd/verify.cc | 38 +-- 3 files changed, 38 insertions(+), 37 deletions(-) If SC comes back from headless

[devel] [PATCH 06 of 15] amfd: Support delayed failover [#1620]

osaf/services/saf/amf/amfd/cluster.cc| 11 ++ osaf/services/saf/amf/amfd/include/sg.h | 14 ++ osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 140 +++ osaf/services/saf/amf/amfd/sg_nored_fsm.cc |6 + osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 2

[devel] [PATCH 04 of 15] amfnd: Add support for cloud resilience at node director [#1620]

osaf/services/saf/amf/amfnd/clc.cc | 100 +++-- osaf/services/saf/amf/amfnd/clm.cc | 11 +- osaf/services/saf/amf/amfnd/comp.cc | 42 ++- osaf/services/saf/amf/amfnd/compdb.cc | 45 ++- osaf/services/saf/amf/amfnd/di.cc | 419 ++

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V2 [#1621]

>> With this patch the CPND detects un-recoverable checkpoints and deletes them all from the DB in case the headless state happens. By the way didn't tested some cases can you clarify below : which error will be revived by cpsv application of PL , for the unrecoverable checkpoint ?