Re: [devel] [PATCH 1 of 1] amfd: delete su and its child objects at stdby amfd [#1683]

2016-03-03 Thread Nagendra Kumar
Hi Hans N, Please find the modified attached patch. Please find some time to review. Thanks -Nagu > -Original Message- > From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] > Sent: 03 March 2016 12:48 > To: Nagendra Kumar; Praveen Malviya; Minh Chau H; Gary Lee > Cc:

Re: [devel] [PATCH 01 of 15] amfd: Add support for cloud resilience at common libs [#1620]

2016-03-03 Thread Nagendra Kumar
Hi, I have conducted the same 9 test cases sent on Mar 2 (in review response) with the patches #1-#4along with attached patches(#9-#13). The summary of the results: All the 9 test cases have failed except in TC #2, in which stopping PL-4 has worked.

Re: [devel] [PATCH 01 of 15] amfd: Add support for cloud resilience at common libs [#1620]

2016-03-03 Thread minh chau
Hi Praveen, Please see my comments in line with [Minh] Thanks, Minh On 04/03/16 00:41, praveen malviya wrote: > Hi Minh, > > The second version of the patches you had published handles immediate > escalation only(1 to 4) but it does not performs 'immediate escalation' > during the transient pha

[devel] [PATCH 1 of 1] log: log agent library is not backward compatible [#1686]

2016-03-03 Thread Vu Minh Nguyen
osaf/libs/agents/saf/lga/lga_mds.c | 26 -- 1 files changed, 20 insertions(+), 6 deletions(-) The log agent on defaul branch (5.0) was not backward compatible with the old OpenSAF versions. This fix does an workaround to make it work. diff --git a/osaf/libs/agents/saf/

[devel] [PATCH 0 of 1] Review Request for log: log agent library is not backward compatible [#1686]

2016-03-03 Thread Vu Minh Nguyen
Summary: log: log agent library is not backward compatible [#1686] Review request for Trac Ticket(s): #1686 Peer Reviewer(s): Lennart, Mathi Pull request to: Lennart Affected branch(es): 5.0 Development branch: 5.0 Impacted area Impact y/n ---

Re: [devel] [PATCH 0 of 1] Review Request for log: Extend information about origin of log record [#1480]

2016-03-03 Thread Lennart Lund
Hi Vu My comments: --- logtest.c get_attr_value() This function looks like it can get a value from any attribute in any object but this does not seems to be the case. It can only get values from some specific objects and also not for all attributes in those o

Re: [devel] [PATCH 0 of 1] Review Request for imm: fix review comments [#1625]

2016-03-03 Thread Neelakanta Reddy
Hi Zoran, Reviewed and tested the the following patch series: 1. https://sourceforge.net/p/opensaf/mailman/message/34715967/ 2. http://sourceforge.net/p/opensaf/mailman/message/34741160/ *imm: add casting of integer types in verifyAttributeValuePBE

Re: [devel] [PATCH 1 of 1] amfd: delete su and its child objects at stdby amfd [#1683]

2016-03-03 Thread Hans Nordebäck
Hi Nagu, the question was related to: while iterating over list_of_comp a component is removed/erase from list_of_comp in remove_comp() function , is the iterator valid after the erase? The same applies to the iterating over list_of_su. If iterating over a copy of list_of_comp, list_of_su that

Re: [devel] [PATCH 01 of 15] amfd: Add support for cloud resilience at common libs [#1620]

2016-03-03 Thread praveen malviya
Hi Minh, The second version of the patches you had published handles immediate escalation only(1 to 4) but it does not performs 'immediate escalation' during the transient phases. So, the concept patch is not for "delayed failover" approach but for doing 'Immediate escalation' during transient

Re: [devel] [PATCH 1 of 1] amfd: delete su and its child objects at stdby amfd [#1683]

2016-03-03 Thread Nagendra Kumar
Hi Hans N, I had found the code working without updating, I wonder how it was printing 3 SU names. > > to iterate over a copy of these lists and then the deletes should not > > affect respective iterators. Can you please elaborate it. Did you mean the below: for (const auto& su : node->list_of_su

Re: [devel] [PATCH 0 of 5] Review Request for Add cloud resilience support [#1180] V2

2016-03-03 Thread Lennart Lund
Hi Minh, Ack. I have not done a very deep analyze of this I assume it's the same code that has already been tested for some time and that there are no significant changes (and that I have reviewed once). Please tell me if there are any changes that you think I should take a closer look at. I h

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V3 [#1621]

2016-03-03 Thread A V Mahesh
Hi Nhat Pham, I am working on `MDS:TIPC include node name as a part of callback_info events [#1522]` i will start as soon as this is pushed . -AVM On 3/3/2016 3:41 PM, Nhat Pham wrote: > Hi Mahesh, > > Have you reviewed the patch? > > Best regards, > Nhat Pham > > -Original Message- >

Re: [devel] [PATCH 0 of 1] Review Request for cpsv: Support preserving and recovering checkpoint replicas during headless state V3 [#1621]

2016-03-03 Thread Nhat Pham
Hi Mahesh, Have you reviewed the patch? Best regards, Nhat Pham -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: Monday, February 29, 2016 1:15 PM To: Nhat Pham ; anders.wid...@ericsson.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 0 of

Re: [devel] current opensaf-4.7.x (4.7.0-1) and default (5.0.M0-1 ) in-service upgrade is not working

2016-03-03 Thread A V Mahesh
Hi Vu, You just take (5.0.M0-1 ) : hg clone http://hg.code.sf.net/p/opensaf/staging & `hg update default` (4.7.0-1) : `hg clone http://hg.code.sf.net/p/opensaf/staging` & `hg update opensaf-4.7.x` Bring4.7.0-1) node as Active , then try to bring 5.0.M0-1 node as Standby , you will see

Re: [devel] current opensaf-4.7.x (4.7.0-1) and default (5.0.M0-1 ) in-service upgrade is not working

2016-03-03 Thread Vu Minh Nguyen
Hi Mahesh, What is the changeset number of default (5.0.M0-1 ) that you were using? And can you send me the trace log of osaflogd on standby node? Thanks. Regards, Vu. >-Original Message- >From: A V Mahesh [mailto:mahesh.va...@oracle.com] >Sent: Thursday, March 03, 2016 2:53 PM >To: open