[devel] [PATCH 1 of 1] amfnd: avoid sending SUSI resp during recovery [#1931]

osaf/services/saf/amf/amfnd/susm.cc | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) During component failover recovery (NPI SU), Amfnd attempt to send SUSI resp to Amfd though there is no SUSI assignment is undergoing. NPI SU terminating state is not a reflective of SUSI assignment

[devel] [PATCH 0 of 1] Review Request for amfnd: avoid sending SUSI resp during recovery [#1931]

Summary: amfnd: avoid sending SUSI resp during recovery [#1931] Review request for Trac Ticket(s): #1931 Peer Reviewer(s): Amf Dev Pull request to: <> Affected branch(es): All Development branch: Default Impacted area Impact y/n

Re: [devel] [PATCH 3 of 4] log: update logsv to support long DN [#1315]

Hi Lennart, Thanks for your comments. Please see my responses inline [Vu]. Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Wednesday, August 3, 2016 8:57 PM > To: Vu Minh Nguyen ; > mahesh.va...@oracle.com >

Re: [devel] [PATCH 1 of 4] log: add one new option -f to saflogger tool [#1315]

Hi Lennart, Please see my respond inline [Vu]. Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Wednesday, August 3, 2016 5:10 PM > To: Vu Minh Nguyen ; > mahesh.va...@oracle.com > Cc:

[devel] [PATCH 0 of 1] Review Request for log: fix ER in syslog if changing saLogStreamFileName and other atrributes[#1887]

Summary: log: fix ER in syslog if changing saLogStreamFileName and other atrributes[#1887] Review request for Trac Ticket(s): #1887 Peer Reviewer(s): Vu, Mahesh, Lennart Pull request to: Vu Affected branch(es): 4.7.x, 5.0.x, default Development branch: default

Re: [devel] [PATCH 3 of 4] log: update logsv to support long DN [#1315]

Hi Vu Ack with comments and after static checks done See comments inline [Lennart] Also if not done already, run the static checks (cppcheck and cpplint) and fix found problems for at least the new code. Thanks Lennart > -Original Message- > From: Vu Minh Nguyen

Re: [devel] [PATCH 2 of 4] log: update LOG agent to support Long DN & RDN [#1315]

Hi Vu, For this patch ACK, no comments Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 1 juli 2016 12:42 > To: mahesh.va...@oracle.com; Lennart Lund > Cc: opensaf-devel@lists.sourceforge.net >

Re: [devel] [PATCH 1 of 1] cpsv: To update checkpoint user number for each node [#1669] V3

Dear Mahesh, I have just submit a V4 patch that try to eliminate the possible error in communicating between old and new version. My testing shows OK result but when I cannot reproduce the problem exactly, I do not have high confident about it. Would you please help me review and check the

[devel] [PATCH 1 of 1] cpsv: To update checkpoint user number for each node [#1669] V4

osaf/libs/common/cpsv/include/cpd_cb.h |2 + osaf/libs/common/cpsv/include/cpd_proc.h |3 + osaf/libs/common/cpsv/include/cpd_red.h | 13 ++ osaf/libs/common/cpsv/include/cpsv_evt.h |8 + osaf/services/saf/cpsv/cpd/cpd_db.c | 14 ++- osaf/services/saf/cpsv/cpd/cpd_evt.c

[devel] [PATCH 0 of 1] Review Request for cpsv: To update checkpoint user number for each node [#1669] V4

Summary: cpsv: To update checkpoint user number for each node [#1669] V4 Review request for Trac Ticket(s): 1669 Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com Pull request to: mahesh.va...@oracle.com; anders.wid...@ericsson.com Affected branch(es): default Development

Re: [devel] [PATCH 1 of 1] log: Readme file for long DN support [#1315]

Hi Lennart, Please see my responses in line, started with [Vu]. I will create a new README file for saflogger tool and put the info related to new test cases to `~/tests/logsv/README`. Updated files are attached. Please have a look. Thanks. Regards, Vu > -Original Message- > From:

Re: [devel] [PATCH 0 of 3] Review Request for lgsv: Log Service CLM integration [#1638] V2

.cc and .h files are supposed to be in the same directory according to the style guide. You can specify the full path to the include file from the top of the source tree: #include "osaf/services/saf/logsv/lgs/lgs_clm.h" regards, Anders Widell On 08/03/2016 12:22 PM, A V Mahesh wrote: > Hi

Re: [devel] [PATCH 0 of 3] Review Request for lgsv: Log Service CLM integration [#1638] V2

Hi Anders Widel, I cleared all the warnings, except following please suggest the how do we adders them : 1 ) Reason for the followings warnings because of lgs *.h files are not in a `include` directory , can I ignore or do i move all the .h file to `include` directory ?

Re: [devel] [PATCH 1 of 4] log: add one new option -f to saflogger tool [#1315]

Hi Vu For saflogger tool ACK with minor comments See also comments inline [Lennart] Thanks Lennart > -Original Message- > From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] > Sent: den 1 juli 2016 12:42 > To: mahesh.va...@oracle.com; Lennart Lund > Cc:

Re: [devel] [PATCH 1 of 2] fm: Add support for self-fencing [#1859]

It's an ack from me after fixing ander's comments. We can take up further comments as a next stab. Mathi. > -Original Message- > From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] > Sent: Wednesday, August 03, 2016 1:18 PM > To: Mathivanan Naickan Palanivelu; Praveen Malviya;

Re: [devel] [PATCH 1 of 1] rde: Change syslog priority from ER to WA when MDS send fails [#1907]

Ack. Thanks, Ramesh. On 7/8/2016 6:09 PM, Anders Widell wrote: > osaf/services/infrastructure/rde/rde_mds.cc | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > RDE may fail to send MDS messages to its peer, e.g. when the peer node is > down. > This should not be considered an

Re: [devel] [PATCH 2 of 3] lgs: director Cluster Membership (CLM) integration [#1638] V2

Hi Mahesh See my new comments inline [Lennart] Thanks Lennart > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: den 3 augusti 2016 08:21 > To: Lennart Lund ; Vu Minh Nguyen > ; Anders Widell >

Re: [devel] [PATCH 1 of 1] log: Readme file for long DN support [#1315]

Hi Vu In general this document should not be a document describing what to implement instead it should describe what is implemented and what in the log service that is affected by long DN and to some extent how it is implemented. See some comments/examples inline. To have information here

Re: [devel] [PATCH 1 of 2] fm: Add support for self-fencing [#1859]

Hi, a gentle reminder. /Thanks HansN -Original Message- From: Mathivanan Naickan Palanivelu [mailto:mathi.naic...@oracle.com] Sent: den 14 juli 2016 11:37 To: Anders Widell ; Hans Nordebäck ; Praveen Malviya

Re: [devel] [PATCH 0 of 1] Review Request for rde: Change syslog priority from ER to WA when MDS send fails [#1907]

I will push this tomorrow if there are no comments. regards, Anders Widell On 08/02/2016 09:57 AM, Anders Widell wrote: > Hi Ramesh! > > Have you had a chance to look at this patch yet? > > regards, > > Anders Widell > > On 07/08/2016 02:39 PM, Anders Widell wrote: >> Summary: rde: Change

Re: [devel] [PATCH 1 of 5] amfd: replace SaNameT with string in include dir [#1642]

On 02-Aug-16 3:39 AM, minh chau wrote: > Hi Praveen, > > One comment with [Minh] in line. > > Thanks, > Minh > > On 01/08/16 17:22, Gary Lee wrote: >> Hi Praveen >> >> On 1/08/2016 4:29 PM, praveen malviya wrote: >>> Hi Gary, Long, >>> >>> Some comments/observations: >>> -In AMFD

Re: [devel] [PATCH 2 of 3] lgs: director Cluster Membership (CLM) integration [#1638] V2

Hi Lennar, I just incorporated possible comments based on the current code base, This My fist patch for LOG :) , so I just followed how existing functions/variables organized like. I will considered all other inputs while doing complete refracting code to C++ in a separate ticket soon.