Re: [devel] [PATCH 1 of 1] amfd: support NplusM model for supported admin ops on NG [#1454]

Hi Minh, Thanks for reviewing the patch. Please see inline with [Praveen] Thanks, Praveen On 23-Aug-16 5:53 AM, minh chau wrote: > Hi Praveen, > > One comment in line with [Minh] > > Thanks > Minh > > On 20/07/16 18:57, praveen.malv...@oracle.com wrote: >>

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi HansN, Let us fist discuss the error handling and abort, then we can come back to interpretation of TIPC currently does permit OR does not permit an application to send a multicast message with the "destination droppable" setting disabled. Let us disable TIPC_DEST_DROPPABLE, so that TIPC

Re: [devel] [PATCH 1 of 1] ntfsv: refactor logging long dn notification [#1585]

Thanks Lennart. I have added comments to make the code more clear/understandable. Regards, Vu > -Original Message- > From: Lennart Lund [mailto:lennart.l...@ericsson.com] > Sent: Monday, August 22, 2016 6:14 PM > To: Vu Minh Nguyen ; Minh Hon Chau >

Re: [devel] [PATCH 1 of 1] amfd: support NplusM model for supported admin ops on NG [#1454]

Hi Praveen, One comment in line with [Minh] Thanks Minh On 20/07/16 18:57, praveen.malv...@oracle.com wrote: > osaf/services/saf/amf/amfd/include/sg.h | 1 + > osaf/services/saf/amf/amfd/nodegroup.cc | 4 +- > osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 62 >

Re: [devel] [PATCH 1 of 1] amfd: add long DN support [#1642]

One minor correction at AMFD: diff --git a/osaf/services/saf/amf/amfd/util.cc b/osaf/services/saf/amf/amfd/util.cc --- a/osaf/services/saf/amf/amfd/util.cc +++ b/osaf/services/saf/amf/amfd/util.cc @@ -1772,10 +1772,13 @@ void d2n_msg_free(AVSV_DND_MSG *msg) case

[devel] [PATCH 0 of 1] Review Request for build: Add missing include path to the top of the source code tree [#1958]

Summary: build: Add missing include path to the top of the source code tree [#1958] Review request for Trac Ticket(s): 1958 Peer Reviewer(s): Mathi Pull request to: Affected branch(es): default(5.1) Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 1] build: Add missing include path to the top of the source code tree [#1958]

Makefile.common | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) Without this include path, it was not possible to build OpenSAF in a directory outside of the source code tree. diff --git a/Makefile.common b/Makefile.common --- a/Makefile.common +++ b/Makefile.common @@ -2,6 +2,7 @@ #

Re: [devel] [PATCH 1 of 1] imm: Allow saImmOmCcbObjectRead in completed callback when ROF is set to false [#1956]

Hi Neel, I have this problem when testing the patch. saImmOiAugmentCcbInitialize() doesn't crash but it always fails with ERR_TRY_AGAIN. Aug 22 18:57:49.347120 imma [1503:imma_oi_api.c:3662] >> saImmOiAugmentCcbInitialize Aug 22 18:57:49.347441 imma [1503:imma_db.c:0451] >>

Re: [devel] [PATCH 1 of 1] dtm: When IPv4 broadcast address is not configured, derive it from IP and netmask [#1930]

Hi! I have not investigated if a similar problem exists with IPv6 addresses. If you have time, please go ahead and try it! thanks, Anders Widell On 08/05/2016 06:38 AM, A V Mahesh wrote: > Hi Anders Widell, > > Did you verified IP6 or you want me to test ? > > -AVM > > > On 8/4/2016 2:22 PM,

Re: [devel] [PATCH 1 of 1] ntfsv: refactor logging long dn notification [#1585]

Hi Vu Ack with comments: It seems as if you have integrated the manual steps by adding some functions for handling data in IMM but it's very cryptic. It's hard to see what "environment" that is backed up, restored and setup. This should be made more clear. Since the functions used for this are

Re: [devel] [PATCH 1 of 1] ntfsv: refactor logging long dn notification [#1585]

Hi Vu, Ack from me (tested) Thanks, Minh On 16/08/16 13:30, Vu Minh Nguyen wrote: > Hi all, > > Do you have any comments on the updated patch (update test code)? Thanks. > > Regards, Vu > >> -Original Message- >> From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au] >> Sent:

Re: [devel] [PATCH 0 of 1] Review Request for imm: Return implementer ID to timed out client [#1948]

Hi Hung, Reviewed the code. Ack from me. Thanks, Zoran -Original Message- From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: den 11 augusti 2016 08:53 To: Zoran Milinkovic; reddy.neelaka...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 0 of 1] Review

Re: [devel] [PATCH 0 of 1] Review Request for imm: Do not revert isApplier and isPbe flag when timeout occurs [#1943]

Hi Hung, Same comments as Neelakanta. Without #1948, the patch is incomplete. The patch #1948 is going to be pushed, so ACK from me. Thanks, Zoran -Original Message- From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: den 11 augusti 2016 09:10 To: Zoran Milinkovic;

Re: [devel] [PATCH 1 of 1] log: fix incorrect usage of saImmRtObjectDelete on cfg app stream [#1330]

Hi Vu, ACK -AVM On 7/20/2016 11:40 AM, Vu Minh Nguyen wrote: > osaf/services/saf/logsv/lgs/lgs_imm.cc| 25 + > osaf/services/saf/logsv/lgs/lgs_mbcsv.cc | 1 + > osaf/services/saf/logsv/lgs/lgs_stream.cc | 6 -- >

Re: [devel] [PATCH 1 of 1] ckpt: fix cppcheck warning [#1874]

Hi Hoan, Can you please push -AVM On 6/13/2016 11:58 AM, A V Mahesh wrote: > Hi Hoang Vo, > > ACK , Not tested. > > By the way which GCC/tool given these warnings ? > > -AVM > > On 6/13/2016 9:20 AM, Hoang Vo wrote: >> osaf/services/saf/cpsv/cpd/cpd_db.c | 8 ++--- >>

Re: [devel] [PATCH 0 of 8] Review Request for CKPT: Support DNs longer than 255 bytes [#1574] v5

Hi Hoang, ACK, Please Update README Note : tested default functionality , LONG DN functionality not tested in full fledged. -AVM On 8/18/2016 12:48 PM, Hoang Vo wrote: > Summary: CKPT: Support DNs longer than 255 bytes {#1574} > Review request for Trac Ticket(s): 1574 > Peer Reviewer(s):

Re: [devel] [PATCH 7 of 8] ckpt: Add new test cases to verify long DN feature on CPSV [#1574] v1

ACK. Not tested. -AVM On 8/18/2016 12:48 PM, Hoang Vo wrote: > tests/cpsv/Makefile.am |1 + > tests/cpsv/test_cpa.c | 180 > +++- > tests/cpsv/test_cpa_util.c | 16 +++- > tests/cpsv/test_cpsv.h |6 + >

Re: [devel] [PATCH 1 of 1] amfa: fixed freeing notification buff [#1642]

Hi Praveen, The case you just mentioned is still in callback context, so Agent can help application to release the allocated notification. But still another case: +SaAmfProtectionGroupNotificationBufferT buff; +buff.notification = NULL; +rc = saAmfProtectionGroupTrack_4(my_amf_hdl,

Re: [devel] [PATCH 6 of 8] cpsv: Apply new messages supporting extended SaNameT to CPD, CPND, and CPA [#1574] v4

Hi Hoang, ACK for [PATCH 6 of 8] with following minor comment I think CPND should return SA_AIS_ERR_TOO_BIG = 26 instead of SA_AIS_ERR_INVALID_PARAM ( please sync-up with other service return values ). Note : tested default functionality , LONG DN functionality not tested in full fledged