[devel] [PATCH 2 of 2] AMF: Update README for SC Absence feature [#2033]

osaf/services/saf/amf/README_HEADLESS | 151 + 1 files changed, 76 insertions(+), 75 deletions(-) Rephrase Headless to SC absence, plus documentation for admin continuation diff --git a/osaf/services/saf/amf/README_HEADLESS

[devel] [PATCH 1 of 2] AMF: Update PR doc for SC Absence feature [#2033]

Rephrase Headless to SC absence, plus documentation for admin continuation Link to document for review https://sourceforge.net/p/opensaf/tickets/_discuss/thread/3f0beb7d/a191/attachment/OpenSAF_AMF_PR_2033.odt --

[devel] [PATCH 0 of 2] Review Request for AMF: Update README for SC Absence feature [#2033]

Summary: AMF: Update README for SC Absence feature [#2033] Review request for Trac Ticket(s): 2033 Peer Reviewer(s): AMF devs Pull request to: <> Affected branch(es): 5.1, default Development branch: default Impacted area Impact y/n

Re: [devel] [PATCH 1 of 1] cpd: coredump error while creating checkpoint after previous creating got error [#2055]

Dear Mahesh, The submitted patch correct the behavior of cpd_ckpt_db_entry_update() function to be similar to cpd_sb_proc_ckpt_create() in handling node_info. So both 2 cases have been considered. Thank you and best regards, Hoang -Original Message- From: A V Mahesh

Re: [devel] [PATCH 1 of 1] cpd: coredump error while creating checkpoint after previous creating got error [#2055]

Hi Hoang, Please check below cases as well uint32_t cpd_ckpt_db_entry_update(CPD_CB *cb, MDS_DEST *cpnd_dest, CPSV_ND2D_CKPT_CREATE *ckpt_create, CPD_CKPT_INFO_NODE

Re: [devel] [PATCH 1 of 1] log: fix ER no stream exists in syslog [#2043]

Hi Vu, Still we can convert this below logic to a function which is use in multiple places like log_stream_get_next_by_id() === /* Check existing streams */ uint32_t count = 0, stream_id = 0, max = 0; uint32_t num = get_number_of_streams(); max =

Re: [devel] [PATCH 1 of 1] amf: handle csi attributes using long dn APIs in assignment messages [#1993]

Hi Praveen ack (review only) with some comments below. On 8/9/16 7:07 pm, praveen.malv...@oracle.com wrote: > osaf/libs/common/amf/n2avamsg.c | 5 +- > osaf/services/saf/amf/amfd/csiattr.cc | 1 + > osaf/services/saf/amf/amfd/util.cc | 49 >

Re: [devel] [PATCH 1 of 1] log: fix ER no stream exists in syslog [#2043]

Hi Lennart, Thanks for your comments. Yesterday, I sent out the V2 patch as attached. Can you have a look to see it could cover your comments #1 and #3? I will handle your comment #2 before pushing the code. Regards, Vu > -Original Message- > From: Lennart Lund

[devel] [PATCH 1 of 2] NTF: Update PR doc to uniformly use SC Absence [#1890]

Link to updated document for review https://sourceforge.net/p/opensaf/tickets/_discuss/thread/74fb31a7/c923/attachment/OpenSAF_NTFSv_PR_1890.odt -- ___ Opensaf-devel mailing

[devel] [PATCH 2 of 2] NTF: Update README to uniformly use SC Absence [#1890]

osaf/services/saf/ntfsv/README.HYDRA | 26 +- 1 files changed, 13 insertions(+), 13 deletions(-) diff --git a/osaf/services/saf/ntfsv/README.HYDRA b/osaf/services/saf/ntfsv/README_SC_ABSENCE rename from osaf/services/saf/ntfsv/README.HYDRA rename to

[devel] [PATCH 0 of 2] Review Request for NTF: Update documenation to uniformly use SC Absence [#1890]

Summary: NTF: Update documentation to uniformly use SC Absence [#1890] Review request for Trac Ticket(s): 1890 Peer Reviewer(s): Mathi, Anders W, Lennart, Praveen Pull request to: <> Affected branch(es): 5.1, default Development branch: default Impacted area

Re: [devel] [PATCH 1 of 1] log: fix ER no stream exists in syslog [#2043]

Hi Vu I have a few comments. There are no comments inline. 1) In several places the following (or almost the same)code can be found: uint32_t count = 0, stream_id = 0; uint32_t num = get_number_of_streams(); stream = log_stream_get_by_id(stream_id); while (count < num) { if (stream

[devel] [PATCH 1 of 1] dtm: Convert transport monitor script to a daemon [#2035]

configure.ac| 3 +- osaf/services/infrastructure/dtms/Makefile.am | 3 +- osaf/services/infrastructure/dtms/scripts/Makefile.am | 3 +-

[devel] [PATCH 0 of 1] Review Request for dtm: Convert transport monitor script to a daemon [#2035]

Summary: dtm: Convert transport monitor script to a daemon [#2035] Review request for Trac Ticket(s): 2035 Peer Reviewer(s): Mahesh Pull request to: Affected branch(es): default(5.2) Development branch: default Impacted area Impact y/n

[devel] [PATCH 0 of 1] Review Request for cpd: coredump error while creating checkpoint after previous creating got error [#2055]

Summary: cpd: coredump error while creating checkpoint after previous creating got error [#2055] Review request for Trac Ticket(s): 2055 Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com Pull request to: mahesh.va...@oracle.com Affected branch(es): default Development branch:

[devel] [PATCH 1 of 1] cpd: coredump error while creating checkpoint after previous creating got error [#2055]

osaf/services/saf/cpsv/cpd/cpd_proc.c | 5 - 1 files changed, 0 insertions(+), 5 deletions(-) Problem: First creating time, cpd got error in creating immOm object and run to error handling steps, this free node_info memory without removing it from nsc_patricia_tree. Second creating time,

[devel] [PATCH 0 of 1] Review Request for log: fix ER no stream exists in syslog [#2043] V2

Summary: log: fix ER no stream exists in syslog [#2043] V2 Review request for Trac Ticket(s): #2043 Peer Reviewer(s): Lennart, Mahesh Pull request to: <> Affected branch(es): 5.1, default Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 1] log: fix ER no stream exists in syslog [#2043]

osaf/services/saf/logsv/lgs/lgs_amf.cc| 34 ++- osaf/services/saf/logsv/lgs/lgs_config.cc | 12 +++-- osaf/services/saf/logsv/lgs/lgs_evt.cc| 31 +- osaf/services/saf/logsv/lgs/lgs_imm.cc| 63 +++---

Re: [devel] [PATCH 1 of 1] log: fix ER no stream exists in syslog [#2043]

I will send the V2 patch soon. Regards, Vu > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Wednesday, September 21, 2016 4:13 PM > To: Vu Minh Nguyen ; > lennart.l...@ericsson.com > Cc: opensaf-devel@lists.sourceforge.net >

Re: [devel] [PATCH 1 of 1] log: fix ER no stream exists in syslog [#2043]

Hi VU, Try**to have function **log_stream_get_next_by_id(). -AVM On 9/21/2016 2:35 PM, Vu Minh Nguyen wrote: > Hi Mahesh, > > I do think about it but not yet found out the better way. > I can use the macro for this, somethings like > GET { > .. > } NEXT; > > but it will violate the coding

Re: [devel] [PATCH 1 of 1] log: fix ER no stream exists in syslog [#2043]

Hi Mahesh, I do think about it but not yet found out the better way. I can use the macro for this, somethings like GET { .. } NEXT; but it will violate the coding rule - avoid using the macro. I would appreciate if you have any proposal for this. Thanks. Regards, Vu > -Original

Re: [devel] [PATCH 1 of 1] log: fix ER no stream exists in syslog [#2043]

Hi Vu, You used this similar code logic number of time in multiple file in log service code is it possibly to optimize this logic in single function , to make maintainability of code , so that any bug fix will not trigger multiple places code changes

[devel] [PATCH 0 of 1] Review Request for log: fix failure to create directory when changing logRootDirectory [#2054]

Summary: log: fix failure to create directory when changing logRootDirectory [#2054] Review request for Trac Ticket(s): 2054 Peer Reviewer(s): Lennart, Mahesh Pull request to: <> Affected branch(es): all Development branch: default Impacted area Impact y/n

[devel] [PATCH 1 of 1] log: fix failure to create directory when changing logRootDirectory [#2054]

osaf/services/saf/logsv/lgs/lgs_imm.cc | 3 + tests/logsv/tet_LogOiOps.c | 82 ++ 2 files changed, 85 insertions(+), 0 deletions(-) When changing `logRootDirectory`, the new directory was not updated to global `lgs_conf.logRootDirectory`, therefore

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi HansN, >> any how GA is tagged. Sorry I mean RC2 tagged -AVM On 9/21/2016 12:41 PM, A V Mahesh wrote: > Hi HansN, > > I just tested with uniform buffer sizes in all nodes and sending > messages with normal phase the results looks OK, > even after hitting the TIPC_ERR_OVERLOAD. > > So my

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages V2 [#1957]

Hi HansN, Ack tested . Please add Steps to test as : 1) send continuous messages to process say 2) Pause receiver process(# kill -STOP ) 3) once we hit TIPC_ERR_OVERLOAD 4) Continues a stopped osafimmnd process(#kill -CONT ) -AVM On

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi HansN, On 9/20/2016 4:17 PM, Hans Nordebäck wrote: > Hi Mahesh, > > I think only logging is needed as proposed in the patch, as some services are > already handling dropped messages. This logging will help in > trouble shooting. Keeping TIPC_DEST_DROPPABLE to true will only make TIPC to >