Re: [devel] [PATCH 1 of 3] imm: Remove use of SaBoolT from library [#2225]

Hi Zoran, In my repository, that 'immOmIsLoader' variable already has the type of bool. (default branch) Can you check if your repository is up to date? Thanks, Hung Nguyen - DEK Technologies From: Zoran Milinkov

[devel] [PATCH 1 of 1] imm: Remove use of SaBoolT from message type [#2225]

osaf/libs/agents/saf/imma/imma_om_api.cc | 4 ++-- osaf/libs/common/immsv/include/immsv_evt_model.h | 6 +++--- osaf/services/saf/immsv/immnd/ImmModel.cc| 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) SaBoolT can be replaced by bool in message type because that does

[devel] [PATCH 0 of 1] Review Request for imm: Remove use of SaBoolT from message type [#2225]

Summary: imm: Remove use of SaBoolT from message type [#2225] Review request for Trac Ticket(s): 2225 Peer Reviewer(s): Zoran, Neel Pull request to: Affected branch(es): 5.2 Development branch: 5.2 Impacted area Impact y/n Do

Re: [devel] [PATCH 1 of 1] amfnd: monitor immnd process using FIFO [#2158]

Hi Praveen, I agree about your summary below. /Thanks HansN -Original Message- From: praveen malviya [mailto:praveen.malv...@oracle.com] Sent: den 20 december 2016 07:57 To: Hans Nordebäck ; nagendr...@oracle.com; Gary Lee ; Minh Hon Chau Cc: opensaf-devel@lists.sourceforge.net Subjec

Re: [devel] [PATCH 1 of 1] amfnd: monitor immnd process using FIFO [#2158]

Hi Hans, Please see inline with [Praveen]. Thanks, Praveen On 16-Dec-16 4:45 PM, Hans Nordeback wrote: > Hi Praveen, please see inline with [HansN]. > > /Thanks HansN > > > On 12/16/2016 11:13 AM, praveen malviya wrote: >> Hi Hans, >> >> Please see inline with [Praveen]. >> >> Thanks, >> Praveen

[devel] [PATCH 1 of 1] ntfd: fix circular dependency with osafntfimcnd [#2219]

osaf/services/saf/ntfsv/ntfimcnd/ntfimcn_main.c | 47 +--- 1 files changed, 11 insertions(+), 36 deletions(-) Refer to the #2219 ticket for more info on the problem. Fix the problem by exiting the osafntfimcnd process right away when getting SIGTERM signal. By this way, not

[devel] [PATCH 0 of 1] Review Request for ntfd: fix circular dependency with osafntfimcnd [#2219]

Summary: ntfd: fix circular dependency with osafntfimcnd [#2219] Review request for Trac Ticket(s): #2219 Peer Reviewer(s): Lennart, Gary, Minh, Praveen Pull request to: <> Affected branch(es): all Development branch: default Impacted area Impact y/n

Re: [devel] [PATCH 0 of 3] Review Request for imm: Remove use of SaBoolT [#2225]

Hi Hung, Reviewed and tested the patch. Ack. patch 3 of 3 is same as "[PATCH 0 of 1] Review Request for imm: Remove use of SaBoolT [#2225]" /Neel. On 2016/12/14 02:16 PM, Hung Nguyen wrote: > Summary: imm: Remove use of SaBoolT [#2225] > Review request for Trac Ticket(s): 2225 > Peer Reviewer(

Re: [devel] [PATCH 0 of 3] Review Request for imm: Improve the iteration in ImmModel [#2224]

Hi Hung, Reviewed and tested the patch. Ack. /Neel. On 2016/12/13 08:58 AM, Hung Nguyen wrote: > Summary: imm: Improve the iteration in ImmModel [#2224] > Review request for Trac Ticket(s): 2224 > Peer Reviewer(s): Zoran, Neel > Pull request to: > Affected branch(es): 5.2 > Development branch: 5

Re: [devel] [PATCH 0 of 1] Review Request for imm: Remove use of SaBoolT [#2225]

Hi Hung, Ack from me with a minor comment on immOmIsLoader I sent for the first code review. Thanks, Zoran -Original Message- From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: den 14 december 2016 09:45 To: Zoran Milinkovic ; reddy.neelaka...@oracle.com Cc: opensaf-devel@l

Re: [devel] [PATCH 1 of 1] nid: Use the FIFO monitoring for started services V2 [#2204]

Hi Mathi, please see comment inlined with [HansN]. /Thanks HansN On 12/19/2016 01:05 PM, Mathivanan Naickan Palanivelu wrote: > Hi Hans, > > Quick comments > > (a) Remove the comma below: > + {"CLMD", "osafclmd.fifo", -1}, [HansN] I have removed the comma. > > (b) NULL is not a part of c++11 r

Re: [devel] [PATCH 1 of 1] nid: Use the FIFO monitoring for started services V2 [#2204]

Hi Hans, Quick comments (a) Remove the comma below: + {"CLMD", "osafclmd.fifo", -1}, (b) NULL is not a part of c++11 right. (c) I'm not sure there is an obvious reason for converting this file to c++ Thanks, Mathi. > -Original Message- > From: Hans Nordeback [mailto:hans.nordeb...@er

Re: [devel] [PATCH 1 of 3] imm: Remove use of SaBoolT from library [#2225]

Hi Hung, In imma_om_api.c in line 52: 'static SaBoolT immOmIsLoader = SA_FALSE;' ... can be replaced with bool type and false. Thanks, Zoran -Original Message- From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: den 14 december 2016 09:46 To: Zoran Milinkovic ; reddy.neelaka.

Re: [devel] [PATCH 1 of 1] clm: Send MDS messages asynchronously to avoid blocking the main thread [#2220]

Ack, Mathi. > -Original Message- > From: Anders Widell [mailto:anders.wid...@ericsson.com] > Sent: Friday, December 09, 2016 6:20 PM > To: Mathivanan Naickan Palanivelu > Cc: opensaf-devel@lists.sourceforge.net > Subject: [PATCH 1 of 1] clm: Send MDS messages asynchronously to avoid > bloc

Re: [devel] [PATCH 1 of 1] imm: Remove use of SaBoolT from IMM tools and tests [#2225]

Hi Hung, Reviewed the code. Ack from me. Thanks, Zoran -Original Message- From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au] Sent: den 14 december 2016 09:45 To: Zoran Milinkovic ; reddy.neelaka...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1] imm: Rem