Re: [devel] [PATCH 1/3] amfnd: Refactor AVND_COMP for simpler environment variable handling [#1945]

2017-06-29 Thread Gary Lee
Hi Hans Ack for the series. Minor comment, perhaps compare_sanamet() can be moved to common as amfd already has a copy. Thanks Gary On 14/6/17, 5:17 pm, "Hans Nordebäck" wrote: Hi Praveen, thanks for reviewing, for info, the patch series also implies the following improvemen

Re: [devel] [PATCH 1/1] imm: send imm finalize message to immnd when dispatch returns ERR_BAD_HANDLE [#2504]

2017-06-29 Thread A V Mahesh
Hi Zoran, Thanks for the test case, I will test like below. -AVM On 6/29/2017 3:53 PM, Zoran Milinkovic wrote: Hi Mahesh, Try to set an implementer on a class with disabled long DN support. When you create an instance of the class with long DN, OiDispatch should return ERR_BAD_HANDLE. After

Re: [devel] [PATCH 0/5] Review Request for ntf: ntfimcn does not handle SA_ERR_UNAVAILABLE [#2506]

2017-06-29 Thread Lennart Lund
Hi I will push a fix for this that: - OM handle is initialized once when imcn is started but is re-initialized in case of SA_ERR_UNAVAILABLE (which will never happen if properly initialized with version A, 2, 12) - imm-version will be handled so that OI and OM is always initialized with IMM ver

Re: [devel] [PATCH 0/5] Review Request for ntf: ntfimcn does not handle SA_ERR_UNAVAILABLE [#2506]

2017-06-29 Thread Zoran Milinkovic
Hi Praveen, I checked saImmOmClassDescriptionGet_2() and the function returns ERR_UNAVAILABLE only if IMM handle is initialized with A.2.18 and above version. The problem here is that first OI handle is initialized with imm_version variable, which version is A.2.12. Then OM handle is initialize

Re: [devel] [PATCH 1/1] imm: send imm finalize message to immnd when dispatch returns ERR_BAD_HANDLE [#2504]

2017-06-29 Thread Zoran Milinkovic
Hi Mahesh, Try to set an implementer on a class with disabled long DN support. When you create an instance of the class with long DN, OiDispatch should return ERR_BAD_HANDLE. After that, you will not be able to set a new implementer with the same name. BR, Zoran -Original Message- From:

Re: [devel] [PATCH 2/3] amf: support SC status change callback, non SAF [#2475]

2017-06-29 Thread praveen malviya
Hi Gary, Thanks for the reviewing the patches. Please see inline with [Praveen]. Thanks, Praveen On 28-Jun-17 12:56 PM, Gary Lee wrote: I think currently the callback is called in the context of the agent MDS thread? This could introduce threading issues to an application as they normally e