Hi Minh, ack code review only, perhaps we can do the following changes
also?
change typdef struct avnd_cb_tag to:
struct AVND_CB {
enum class AvdStatus {
UP,
DOWN
};
AvdStatus avd_status() {return avd_status_;} /* Temp: Indicates if
AvD went down */
AvdStatus avd_statu
Make generic C++ decorator for handling SA_AIS_ERR_TRY_AGAIN return code
of AIS APIs.
---
src/base/Makefile.am | 5 +-
src/base/tests/try_again_decorator_test.cc | 48 +
src/base/try_again_decorator.h | 109 +
3 files cha
Summary: base: create generic try-again handling decorator for AIS APIs [#2702]
Review request for Ticket(s): 2702
Peer Reviewer(s): Hans, AndersW
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2702
Base revision: fb42d73a1d0ec
Hi Anders,
Thanks a lot for your very good comments. I have just sent out the updated
patch V2.
Regards, Vu
> -Original Message-
> From: Anders Widell [mailto:anders.wid...@ericsson.com]
> Sent: Monday, November 27, 2017 10:45 PM
> To: Vu Minh Nguyen ;
> hans.nordeb...@ericsson.com
>
ack, review only. /Thanks HansN
On 11/20/2017 12:59 PM, Nguyen Luu wrote:
Fix pylint and pep8 issues for the following Python files:
./tools/devel/dot/trace2dot
./tools/devel/review/patch-tokenize.py
./src/imm/tools/immxml-merge
./src/imm/tools/immxml-validate
./src/imm/tools/bas
Add a new protocol message that can be recevied on the UNIX socket, that causes
osaftransportd to write all buffered log messages from memory to disk.
---
src/base/logtrace.cc | 4 +-
src/dtm/Makefile.am | 16 -
src/dtm/common/osaflog_protocol.h | 50
Flush log entries in the OpenSAF internal log server from memory to disk before
rebooting the local node, to prevent loss of log messages.
---
scripts/opensaf_reboot | 7 +++
1 file changed, 7 insertions(+)
diff --git a/scripts/opensaf_reboot b/scripts/opensaf_reboot
index b8a5737d0..df65c268
Add new UnixSocket methods for sending and receiving with a sockaddr_un address
parameter. Also add support for abstract UNIX socket addresses and for providing
a raw sockaddr_un address to UnixSocket.
---
src/base/tests/unix_socket_test.cc | 35 +
src/base/unix_client_socket.cc |
Summary: base: Add support for recvfrom and sendto operations on UnixSocket
[#2646]
Review request for Ticket(s): 2646
Peer Reviewer(s): Ravi
Pull request to:
Affected branch(es): develop
Development branch: ticket-2646
Base revision: fb42d73a1d0ec3aed4cd493269d99592c3e12985
Personal repository:
signature.asc
Description: OpenPGP digital signature
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot__
Summary: plm: setup immutil wrapper profile [#2708]
Review request for Ticket(s): 2708
Peer Reviewer(s): Mathi, Ravi
Pull request to:
Affected branch(es): develop
Development branch: ticket-2708
Base revision: fb42d73a1d0ec3aed4cd493269d99592c3e12985
Personal repository: git://git.code.sf.net/u/tr
If an immutil_XXX call fails, PLM asserts which reboots the node.
immutil wrapper profile is not set.
Set the immutil wrapper profile.
---
src/plm/plmd/plms_imm.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/plm/plmd/plms_imm.c b/src/plm/plmd/plms_imm.c
index ef61b57..e3882e4 10
Hi Alex,
Ack, Code review only
Regards,
Ravi
- Original Message -
From: alex.jo...@genband.com
To: mathi.np@gmail.com, ravisekhar.ko...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net, alex.jo...@genband.com
Sent: Tuesday, November 28, 2017 10:34:48 PM GMT +05:30 Chennai, Kolkata,
Hi Hans,
That's good idea and it seems to be similar and done in #2672 by Gary.
Thanks,
Minh
On 28/11/17 23:19, Hans Nordebäck wrote:
Hi Minh, ack code review only, perhaps we can do the following changes
also?
change typdef struct avnd_cb_tag to:
struct AVND_CB {
enum class AvdStatus
Hi all,
I have added static assertion for validating retry control parameters,
so that user will get complier error if giving invalid inputs. Below is the
diff.
diff --git a/src/base/try_again_decorator.h b/src/base/try_again_decorator.h
index e676697..b11194d 100644
--- a/src/base/try_again_deco
15 matches
Mail list logo