Re: [devel] [PATCH 1/1] amfd: ignore amfnd down event if node state is absent [#3015]

2019-06-10 Thread Minh Hon Chau
Hi Thang, I can see it's a race in main thread that how amfd processes the mds down and clm callback. Node is going down <143>1 2019-06-11T15:16:42.157517+10:00 SC-1 osafamfd 272 osafamfd [meta sequenceId="38507"] 275:amf/amfd/mds.cc:398 >> avd_mds_svc_evt <143>1 2019-06-11T15:16:42.157526+1

Re: [devel] [PATCH 1/1] amfd: do not queue sync messages from 'lost' nodes [#3050]

2019-06-10 Thread Gary Lee
Hi Minh On 11/6/19 10:33 am, Minh Hon Chau wrote: Hi Gary, Those variables e.g node_sync_window_closed have been used before headless sync complete. If there is a failover during the headless sync, the new active will start the headless sync again, so those variables have not been needed to

Re: [devel] [PATCH 1/1] amfd: do not queue sync messages from 'lost' nodes [#3050]

2019-06-10 Thread Minh Hon Chau
Hi Gary, Those variables e.g node_sync_window_closed have been used before headless sync complete. If there is a failover during the headless sync, the new active will start the headless sync again, so those variables have not been needed to checkpoint. But here the scenario happens in split