Re: [devel] [PATCH 1/1] amfd: honor PrefAssignedSU in nway and nway active model during assignments [#2269]

Hi Praveen, ack, code review only, minor comments below. /Regards HansN On 07/27/2017 07:36 AM, Praveen wrote: SG attribute saAmfSGNumPrefAssignedSUs is applicable to N-Way and N-Way Active model. AMF is assigning more than saAmfSGNumPrefAssignedSUs in both N-Way and N-Way Active model.

Re: [devel] [PATCH 1/1] amf: add option for controller status in amfclusterstatus [#2536]

ack, code review only. Minor comments below marked with [HansN] /Regards HansN On 08/04/2017 11:18 AM, Praveen wrote: --- src/amf/tools/amf_cluster_status.cc | 190 +++- 1 file changed, 167 insertions(+), 23 deletions(-) diff --git

Re: [devel] [PATCH 1/1] nid: order of system log print out is not correct [#2541]

Ack, code review only/Regards HansN -Original Message- From: Rafael Odzakow Sent: den 2 augusti 2017 10:14 To: Anders Widell <anders.wid...@ericsson.com>; Hans Nordebäck <hans.nordeb...@ericsson.com> Cc: opensaf-devel@lists.sourceforge.net; Rafael Odzakow <rafael.odza.

Re: [devel] [PATCH 1/1] amfa: return BAD HANDLE in error report or error clear [#248]

ack, code review only. Same comment as for ticket [#2539], (UINT32_MAX and PRIx64)). /Regards HansN On 07/28/2017 11:25 AM, Nagendra Kumar wrote: --- src/amf/agent/amf_agent.cc | 15 +++ 1 file changed, 15 insertions(+) diff --git a/src/amf/agent/amf_agent.cc

Re: [devel] [PATCH 1/1] amfa: Fix saAmfPmStart_3 and saAmfResponse_4 to correctly return BAD_HANDLE [#2539]

ack, code review only. When refactoring the code, perhaps UINT_MAX from can be used instead of AVSV_UNS32_HDL_MAX? And PRIx64 from instead of %llx? /Regards HansN On 08/02/2017 06:01 AM, Nguyen Luu wrote: When called with an uninitialized or already finalized handle, saAmfPmStart_3 and

Re: [devel] [PATCH 1/1] amfd: increase msg priority for node ups [#2510]

Hi, agree with you Gary, the main thread looks busy, ack on this patch. /Thanks HansN On 07/06/2017 07:59 AM, Gary Lee wrote: Hi Praveen / Hans There are no errors in mds log. The messages are not lost, they are just buffered between the MDS thread and main thread, for up to around 15

Re: [devel] [PATCH 1/1] amfd: increase msg priority for node ups [#2510]

Hi, it may be that the MDS thread is a real time thread SCHED_RR and the main thread is SCHED_OTHER, and as long as the MDS thread do not yield, the main thread will not be scheduled. This may be more common in an container environment, I think we need to look into, if this starts to be a

Re: [devel] [PATCH 1/1] pyosaf: Ensure compatibility with Python 3 [#2492]

Hi Anders, minor comments below marked with [HansN] /BR Hans On 06/13/2017 04:07 PM, Anders Widell wrote: Ensure compatibility with Python 3 by running the Python source code files through the Automated Python 2 to 3 code translation tool "2to3". For more information about this tool, see:

Re: [devel] [PATCH 1/3] amfnd: Refactor AVND_COMP for simpler environment variable handling [#1945]

Hi Praveen, thanks for reviewing, for info, the patch series also implies the following improvements: avnd_comp_clc_cmd_execute after refactoring: cyclomatic complexity reduced from 23 to 19 (-17%) # stmts reduced from 150 to 98 (-35%) # lines in function reduced from 259 to 184 (-29%)

Re: [devel] [PATCH 1/3] amfnd: Refactor AVND_COMP for simpler environment variable handling [#1945]

Hi Praveen, good catch, I'll update. /Thanks HansN On 06/13/2017 08:53 AM, praveen malviya wrote: Hi Hans, One comment on this patch inline with [Praveen]. Thanks, Praveen On 18-May-17 3:32 PM, Hans Nordeback wrote: --- src/amf/amfnd/avnd_comp.h | 134

Re: [devel] [PATCH 3/3] amfnd: Refactor AVND_COMP for simpler cmd argument handling V2 [#1945]

Hi Praveen, The intention with V2 was to correct the case when a space is needed in the argument, but as you say it is not backward compatible. V1 of this patch is backward compatible, I'll put it back and send it out for a new review. /Thanks HansN On 06/13/2017 08:53 AM, praveen malviya

Re: [devel] [PATCH 1/1] base: Improve state report for opensafd [#2459]

" opensafd but from services that can not handle a abrupt reboot." Which services are you referring to? The system may be abrubtly rebooted at any time. /Hans -Original Message- From: Rafael Odzakow Sent: den 1 juni 2017 10:41 To: Hans Nordebäck <hans.nordeb...@ericsson

Re: [devel] [PATCH 1/1] base: Improve state report for opensafd [#2459]

BC. But as this script is pretty central to OpenSAF I am thinḱing NBC route would be better. On 05/31/2017 12:42 PM, Hans Nordebäck wrote: Hi Rafael, not tested, but perhaps we can do this check instead?: status() { amfpid=`pidofproc -p $amfnd_pid $amfnd_bin` if [[ -n

Re: [devel] [PATCH 1/1] amfd: only increment su_cnt_admin_oper for non-opensaf SUs [#2466]

Ack, code review only/Thanks HansN -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: den 24 maj 2017 02:52 To: praveen malviya <praveen.malv...@oracle.com>; Hans Nordebäck <hans.nordeb...@ericsson.com>; Minh Hon Chau <minh.c...@dektech.co

Re: [devel] [PATCH 1/1] base: Improve state report for opensafd [#2459]

Hi Rafael, not sure if checking status of OpenSAF before ordering a reboot will have any effect as the result of the call will only be momentarily accurate. Is the problem this ticket address when SMF is ordering a reboot of a not fully started OpenSAF, and the "opensafd start/stop already

Re: [devel] [PATCH 1/1] base: Make pid file safe to read by rename it from temporary created file [#2432]

cause then we can have problems interacting with other >> programs that operate on the pid files (Ubuntu start-stop-daemon and >> LSB start_daemon). Maybe the solution is as simple as using flock() >> when reading the pid file? >> >> regards, >> >>

Re: [devel] [PATCH 1/1] base: Make pid file safe to read by rename it from temporary created file [#2432]

Hi Minh, You can ignore my comment on pid in temp filename below. /Thanks HansN -Original Message- From: Hans Nordebäck Sent: den 2 maj 2017 15:11 To: Minh Hon Chau <minh.c...@dektech.com.au>; Anders Widell <anders.wid...@ericsson.com>; ramesh.bet...@oracle.com Cc: o

Re: [devel] [PATCH 1/1] base: Make pid file safe to read by rename it from temporary created file [#2432]

Hi Minh, some minor comments below, I discussed with Anders about using the existing flock instead of the rename. /BR HansN On 04/28/2017 11:36 AM, Minh Chau wrote: > At startup, osaftransportd waits for osafdtmd.pid file creation > and then reads dtm pid. If osafdtmd.pid has not been

Re: [devel] [PATCH 1 of 1] amfd: disallow delete of CtCs object if Ct maps to comp [#2428]

Hi Nagu, there are some compiler errors related to TRACE, osaf_extended_name_borrow() is missing for SaNameT and c_str() for std::string. /Thanks Hans On 04/18/2017 03:04 PM, Hans Nordebäck wrote: > Hi Nagu, > > Is the patch only valid for 5.1? /Regards Hans > > -O

Re: [devel] [PATCH 1 of 1] amfd: disallow delete of CtCs object if Ct maps to comp [#2428]

Hi Nagu, Is the patch only valid for 5.1? /Regards Hans -Original Message- From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] Sent: den 18 april 2017 14:49 To: nagendr...@oracle.com; praveen.malv...@oracle.com; Minh Hon Chau <minh.c...@dektech.com.au>; Gary Lee

Re: [devel] [PATCH 1 of 1] amfd: disallow delete of CtCs object if Ct maps to comp [#2428]

Hi Nagu, can you please use the new git submit for review. /Thanks HansN On 04/14/2017 03:22 PM, nagendr...@oracle.com wrote: > osaf/services/saf/amf/amfd/ctcstype.cc | 60 > - > 1 files changed, 58 insertions(+), 2 deletions(-) > > > diff --git

Re: [devel] [PATCH 1/1] samples: fix $piddir undefined in amf_demo_script [#2410]

ack, code review only/Thanks HansN On 04/12/2017 02:36 PM, Nguyen Luu wrote: > The $piddir variable (containing path to amf_demo comp's pid file) > is missed to be defined in amf_demo_script. > > This could lead to the amf_demo process not getting truely killed > in some cases when cleanup is

Re: [devel] [PATCH 1 of 1] CLM : Cluster reset does not succed as reboot now command fails on SLES [#2339]

Hi Ramesh, Is it ok to push this patch? It is acked by AndersW /Thanks HansN -Original Message- From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] Sent: den 13 mars 2017 14:37 To: ramesh.bet...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1

Re: [devel] [PATCH 1 of 1] base: Improve trace by using tid instead of pid [#2370]

Hi Ramesh, reading the trace files with tid instead of pid will make it much easier to follow each threads flow of control. Tools such as trace2dot should also benefit. Example: : Mar 15 10:57:54.837368 osafamfd [475:src/imm/agent/imma_oi_api.cc:2960] TR attr:safCSIComp Mar 15

Re: [devel] [PATCH 1 of 1] CLM : Cluster reset does not succed as reboot now command fails on SLES [#2339]

Hi Ramesh, A gentle reminder for review/Thanks HansN -Original Message- From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] Sent: den 6 mars 2017 16:28 To: ramesh.bet...@oracle.com; Anders Widell Cc: opensaf-devel@lists.sourceforge.net Subject: [devel]

Re: [devel] [PATCH 1 of 1] mds: reduce log level to Err for TIPC_ERR_OVERLOAD in syslog [#2350]

Hi Mahesh, Yes, I think 'TIPC_RETDATA' can have INFO, and TIPC_ERR_OVERLOAD as is, i.e. ERROR. /Regards Hans -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: den 10 mars 2017 04:52 To: Hans Nordebäck <hans.nordeb...@ericsson.com> Cc: opensaf

Re: [devel] [PATCH 1 of 1] mds: reduce log level to Err for TIPC_ERR_OVERLOAD in syslog [#2350]

that fails due to this change. /Regards Hans -Original Message- From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] Sent: den 7 mars 2017 07:57 To: mahesh.va...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1 of 1] mds: reduce log level to Err

Re: [devel] [PATCH 1 of 1] CLM : Cluster reset does not succed as reboot now command fails on SLES [#2339]

thanks Anders I'll update the patch/BR Hans On 03/07/2017 03:06 PM, Anders Widell wrote: > One more comment: the syslog message on the line before the shutdown > command also has to be updated. > > regards, > > Anders Widell > > > On 03/07/2017 03:03 PM, Anders Widell wrote: >> Ack with

Re: [devel] [PATCH 1 of 1] nid: OpenSAF failed to start on controller randomly [#2346]

Hi Ramesh, I only increased the tolerance time, assuming that the time to start transportd in this case is longer than usual. /Regards HansN From: ramesh betham [mailto:ramesh.bet...@oracle.com] Sent: den 7 mars 2017 11:55 To: Hans Nordebäck <hans.nordeb...@ericsson.com> Cc: Anders

Re: [devel] [PATCH 1 of 1] amfnd: avoid null pointer access [#2213]

Ack, code review only/Thanks HansN -Original Message- From: nagendr...@oracle.com [mailto:nagendr...@oracle.com] Sent: den 7 mars 2017 07:31 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; praveen.malv...@oracle.com; Minh Hon Chau <minh.c...@dektech.com.au>; Ga

Re: [devel] [PATCH 1 of 1] mds: reduce log level to Err for TIPC_ERR_OVERLOAD in syslog [#2350]

Ack, code review only/Thanks HansN -Original Message- From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com] Sent: den 7 mars 2017 03:39 To: Hans Nordebäck <hans.nordeb...@ericsson.com> Cc: opensaf-devel@lists.sourceforge.net Subject: [PATCH 1 of 1] mds: reduce log level

Re: [devel] [PATCH 1 of 1] base: Add a collision-resistant hash function [#2266]

is not hard to implement. > If there is a need for supporting more algorithms in the future, then I would > consider for using OpenSSL. > > As Anders has pointed out, adding OpenSSL means adding one more third party > library to OpenSAF. > > BR, > Zoran > > -Or

Re: [devel] [PATCH 1 of 1] nid: nodeinit may crash when exit is called from the main thread [#2294]

Hi Ramesh and Mahesh, I plan to push this patch tomorrow, AndersW has acked the patch. /Thanks HansN -Original Message- From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] Sent: den 17 februari 2017 15:16 To: ramesh.bet...@oracle.com; mahesh.va...@oracle.com Cc: opensaf-devel

Re: [devel] [PATCH 1 of 1] nid: nodeinit may crash when exit is called from the main thread [#2294]

Hi Ramesh and Mahesh, a gentle reminder for review. /Thanks HansN -Original Message- From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] Sent: den 10 februari 2017 09:57 To: Anders Widell ; ramesh.bet...@oracle.com; mahesh.va...@oracle.com Cc:

Re: [devel] [PATCH 1 of 1] amfd: change LOG_ER to LOG_NO [#1749]

Ack, code review only/Thanks HansN -Original Message- From: nagendr...@oracle.com [mailto:nagendr...@oracle.com] Sent: den 9 februari 2017 11:25 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; praveen.malv...@oracle.com; Minh Hon Chau <minh.c...@dektech.com.au>; Ga

Re: [devel] `make rpm` giving error

Hi Mahesh, please ignore the patch, it should only include where the PRI macros are used, I noticed that the patch includes it in too many places. /Regards HansN -Original Message- From: Hans Nordebäck Sent: den 31 januari 2017 12:44 To: A V Mahesh <mahesh.va...@oracle.com>;

Re: [devel] `make rpm` giving error

Perhaps the has to be changed to in mds_log.cc, (__STDC_FORMAT_MACROS). /Regards Hans -Original Message- From: Chani Srivastava [mailto:chani.srivast...@oracle.com] Sent: den 31 januari 2017 10:21 To: opensaf-devel@lists.sourceforge.net Subject: [devel] `make rpm` giving error Hi,

Re: [devel] [PATCH 1 of 1] mds: Remove calls to exit [#2279]

...@oracle.com] Sent: den 30 januari 2017 04:20 To: Hans Nordebäck <hans.nordeb...@ericsson.com> Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 1 of 1] mds: Remove calls to exit [#2279] Hi Hans N, ACK, Not tested. I Hope you have simulated the New return cases. -AVM On 1/27/

Re: [devel] [PATCH 1 of 1] base: Improve TRACE_ENTER, TRACE_LEAVE macros [#2262]

Hi Ramesh and Nagendra, Have you had any time to look at this patch? /Thanks HansN -Original Message- From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] Sent: den 19 januari 2017 15:27 To: Anders Widell <anders.wid...@ericsson.com>; ramesh.bet...@oracle.com; n

Re: [devel] [PATCH 1 of 1] base: Improve TRACE_ENTER, TRACE_LEAVE macros [#2262]

Thanks Anders, I'll update the patch before pushing. /BR HansN -Original Message- From: Anders Widell Sent: den 19 januari 2017 15:15 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; ramesh.bet...@oracle.com; nagendr...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subje

Re: [devel] [PATCH 1 of 1] opensafd: Disallow parallel execution of opensafd operations start and stop [#2244]

Hi Ramesh, A gentle reminder for review/Thanks HansN -Original Message- From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] Sent: den 22 december 2016 14:17 To: ramesh.bet...@oracle.com; Anders Widell Cc: opensaf-devel@lists.sourceforge.net Subject:

Re: [devel] [PATCH 1 of 1] amfnd: monitor immnd process using FIFO [#2158]

Hi Minh & Praveen, Do we agree to close ticket #2158 as a duplicate of #2204? /Thanks HansN -Original Message- From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] Sent: den 20 december 2016 08:18 To: praveen malviya <praveen.malv...@oracle.com>; nagendr...@oracle.com;

Re: [devel] [PATCH 1 of 1] nid: Use the FIFO monitoring for started services V2 [#2204]

Hi Mathi & Ramesh, A gentle reminder, Is it ok to push this patch? /Thanks HansN -Original Message- From: Hans Nordebäck Sent: den 19 december 2016 13:40 To: Mathivanan Naickan Palanivelu <mathi.naic...@oracle.com>; Praveen Malviya <praveen.malv...@oracle.com>; Ra

Re: [devel] [PATCH 1 of 1] amfnd: monitor immnd process using FIFO [#2158]

Hi Praveen, I agree about your summary below. /Thanks HansN -Original Message- From: praveen malviya [mailto:praveen.malv...@oracle.com] Sent: den 20 december 2016 07:57 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; nagendr...@oracle.com; Gary Lee <gary@dektech.com.

Re: [devel] [PATCH 1 of 1] amfd: assert in avd_compcsi_cleanup_imm_object [#2081]

Hi, it is only 5.1.x branch where it is needed. /Thanks HansN -Original Message- From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] Sent: den 2 december 2016 13:51 To: praveen malviya <praveen.malv...@oracle.com>; Gary Lee <gary@dektech.com.au> Cc: Minh Hon

Re: [devel] [PATCH 1 of 1] amfd: assert in avd_compcsi_cleanup_imm_object [#2081]

Hi, This patch needs to be pushed asap to 5.1.x and 5.0.x also, you don't see any problem with that? /Thanks HansN -Original Message- From: praveen malviya [mailto:praveen.malv...@oracle.com] Sent: den 4 oktober 2016 13:01 To: Gary Lee <gary@dektech.com.au>; Hans Nor

Re: [devel] [PATCH 1 of 1] amfnd: add logs for HC start failures [#340]

To: Hans Nordebäck <hans.nordeb...@ericsson.com>; Praveen Malviya <praveen.malv...@oracle.com>; Minh Hon Chau <minh.c...@dektech.com.au>; Gary Lee <gary@dektech.com.au> Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [PATCH 1 of 1] amfnd: add logs for HC start failures [#

Re: [devel] [PATCH 1 of 1] amfnd: add logs for HC start failures [#340]

though there are no OpenSAF errors? /Regards HansN -Original Message- From: Nagendra Kumar [mailto:nagendr...@oracle.com] Sent: den 1 december 2016 06:37 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; Praveen Malviya <praveen.malv...@oracle.com>; Minh Hon Chau <minh.c...

Re: [devel] [PATCH 1 of 1] fm: Add support for differentiating a hung node versus a stopped node V3 [#2160]

Hi, Has anyone had the time to look at this patch? /Regards HansN -Original Message- From: Hans Nordebäck Sent: den 23 november 2016 14:45 To: ramesh.bet...@oracle.com; mathi.naic...@oracle.com; Anders Widell <anders.wid...@ericsson.com> Cc: opensaf-devel@lists.sourceforge.net S

Re: [devel] [PATCH 1 of 1] mds: Remove use of mutex at TIPC receive (part 1) V3 [#2132]

Hi Mahesh, Any updates on this? /Regards HansN -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: den 23 november 2016 06:37 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; Anders Widell <anders.wid...@ericsson.com> Cc: opensaf-devel@lists.sou

Re: [devel] [PATCH 1 of 1] cpnd: ensure shared memory size before writing [#2202]

Hi, A question, is the use of shared memory really needed for ckpt? It seems overly comlex for its purpose, or? /Regards HansN -Original Message- From: Anders Widell [mailto:anders.wid...@ericsson.com] Sent: den 28 november 2016 13:58 To: ramesh betham ;

Re: [devel] [PATCH 1 of 1] mds: avoid SIGPIPE in mds_register_callback() [#2203]

Hi Mahesh, It is an alternative, but as of today in OpenSAF only MSG_NOSIGNAL is used, I think it is better to follow that pattern. /Thanks HansN -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: den 25 november 2016 06:49 To: Hans Nordebäck <hans.nor

Re: [devel] [PATCH 1 of 1] fm: Add support for differentiating a hung node versus a stopped node [#2160]

Hi, Sorry, in the first V3 sent for review I missed to do hg qrefresh, so I resent a second V3 which is the correct one. /Thanks HansN -Original Message- From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] Sent: den 23 november 2016 14:42 To: Mathivanan Naickan Palanivelu

Re: [devel] [PATCH 1 of 1] fm: Add support for differentiating a hung node versus a stopped node [#2160]

Hi Mathi, Yes I agree. I'll send out a new V3 of the patch where the fm peer informs the other peer at terminating. /Thanks HansN -Original Message- From: Mathivanan Naickan Palanivelu [mailto:mathi.naic...@oracle.com] Sent: den 23 november 2016 04:34 To: Hans Nordebäck <hans.nor

Re: [devel] [PATCH 1 of 1] mds: Remove use of mutex at TIPC receive (part 1) V2 [#2132]

Hi Mahesh, V3 of patch is sent out. Regarding the out of order problem mentioned below it is addressed by ticket #2124 and #2180. /Thanks HansN -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: den 22 november 2016 10:06 To: Hans Nordebäck <hans.nor

Re: [devel] [PATCH 1 of 1] mds: Remove use of mutex at TIPC receive (part 1) V2 [#2132]

Hi Mahesh, I didn't find any review comments on V2, only from AndersW. I did find some questions on MSG_DONTWAIT flag only. /Regards HansN -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: den 22 november 2016 04:10 To: Hans Nordebäck <hans.nor

Re: [devel] [PATCH 1 of 1] fm: Add support for differentiating a hung node versus a stopped node [#2160]

Hi Ramesh and Mathi, Have you had time to review this patch? /Regards HansN -Original Message- From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] Sent: den 4 november 2016 14:00 To: ramesh.bet...@oracle.com; mathi.naic...@oracle.com; Anders Widell Cc:

Re: [devel] [PATCH 1 of 1] mds: Remove use of mutex at TIPC receive (part 1) V2 [#2132]

Hi Mahesh, Have you had time to review this patch? /Regards HansN -Original Message- From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] Sent: den 27 oktober 2016 17:29 To: Anders Widell ; mahesh.va...@oracle.com Cc: opensaf-devel@lists.sourceforge.net

Re: [devel] [PATCH 1 of 1] amfnd: send node_up even if led_state is not green

Ack, code review only/Thanks HansN -Original Message- From: Gary Lee Sent: den 11 november 2016 06:47 To: Gary Lee <gary@dektech.com.au>; praveen.malv...@oracle.com; Minh Hon Chau <minh.c...@dektech.com.au>; Hans Nordebäck <hans.nordeb...@ericsson.com>; nagendr..

Re: [devel] [PATCH 0 of 3] Review Request for dtm: Use inotify to improve response time for transport monitor process V4 [#2091]

Hi Ramesh, Thanks, for info, I added a close of the fifo fd in daemon_exit() after I sent out the V4, so that close is missing in V4. /BR HansN -Original Message- From: ramesh betham [mailto:ramesh.bet...@oracle.com] Sent: den 28 oktober 2016 07:10 To: Hans Nordebäck <hans.nor

Re: [devel] [PATCH 3 of 3] dtm: Use inotify to improve response time for transport monitor process V3 [#2091]

One more comment, in daemon.c we can move create_fifo before __create_pid, this will close the raise window and then its needed to only check EINTR at fifo open. /Thanks HansN -Original Message- From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] Sent: den 27 oktober 2016 09:17

Re: [devel] [PATCH 1 of 1] amfnd: ignore healthcheck failure if comp is terminating [#1950]

Hi Gary, Ack, code review only/Thanks HansN -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: den 25 oktober 2016 04:24 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; praveen.malv...@oracle.com; nagendr...@oracle.com; Minh Hon Chau <minh.c...@dektech.c

Re: [devel] [PATCH 3 of 3] dtm: Use inotify to improve response time for transport monitor process V3 [#2091]

Hi, The FIFO is created for each daemon (reading and non blocking), perhaps it should be created for osafdtmd only, or? /Thanks HansN -Original Message- From: Hans Nordeback [mailto:hans.nordeb...@ericsson.com] Sent: den 22 oktober 2016 14:54 To: Anders Widell

Re: [devel] [PATCH 1 of 3] base: Use inotify to improve response time for transport monitor process V3 [#2091]

Hi, the design can be more general, WaitForFileCreation/Deletion can be change to WaitForEvent(Events, timeout), where Events contains filename + filedescriptors. When an event happens it will be returned. /Thanks HansN -Original Message- From: Hans Nordeback

Re: [devel] [PATCH 1 of 1] amfnd: fix amfnd exit when a NPI SU comp faults during shutdown phase [#2098]

Hi Praveen, Ack, code review and tested in UML. /Thanks HansN -Original Message- From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com] Sent: den 13 oktober 2016 08:16 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; nagendr...@oracle.com; Gary Lee

Re: [devel] [PATCH 3 of 3] dtm: Use inotify to improve response time for transport monitor process [#2091]

Hi Anders, thanks for pointing out, I missed the term_fd_. I'll send out a new version. /Thanks HansN On 10/14/2016 10:34 AM, Anders Widell wrote: > Hi! > > This code has degraded in one aspect: it does not return so quickly > (or at all) when term_fd_ has been signalled. Could you try to fix

Re: [devel] [PATCH 1 of 3] base: Use inotify to improve response time for transport monitor process [#2091]

Hi Anders, good comments! I'll update and send out a new version. I'll keep the dirname and basename for now, (the c++ version requires some more work, boost filesystem path may be used but it requires building). /Thanks HansN On 10/14/2016 10:27 AM, Anders Widell wrote: > > Ack with

[devel] Review request CLM Programmers Guide [#2053]

Hi Mathi, I updated the CLM Programmers Guide with the CLM cluster reboot support. /Thanks HansN OpenSAF_CLMSv_PR.odt Description: application/vnd.oasis.opendocument.text -- Check out the vibrant tech community on

Re: [devel] [PATCH 1 of 1] uml: Update UML to Linux 4.8 [#2089]

Hi Anders, ack. Code review and basic tests. Minor comments below. /Thanks HansN On 10/03/2016 03:33 PM, Anders Widell wrote: > tools/cluster_sim_uml/README| 6 + > tools/cluster_sim_uml/opensaf | 161 +- >

Re: [devel] [PATCH 1 of 1] amfnd: send recovery request to amfd for term-failed PI su [#2047] V2

Hi Praveen, ack, code review only. Minor comment below. Small suggestions in attached patch also. /Thanks HansN On 10/03/2016 09:28 AM, praveen.malv...@oracle.com wrote: osaf/services/saf/amf/amfnd/clc.cc| 5 + osaf/services/saf/amf/amfnd/di.cc | 2 +-

Re: [devel] [PATCH 1 of 1] amfd: assert in avd_compcsi_cleanup_imm_object [#2081]

Hi Praveen, the case when the assertion occurred is after headless and the node up messages are sent from the payloads. The comp name in SaAmfCSIAssignment is missing in the comp db. Changing the assert to a log message may also help in further troubleshooting. But this case seems not

Re: [devel] [PATCH 1 of 1] amfd: assert in avd_compcsi_cleanup_imm_object [#2081]

Hi Nagu, Praveen, I would like to push this patch, have you had any time to review? /Thanks HansN From: Gary Lee [mailto:gary@dektech.com.au] Sent: den 3 oktober 2016 23:03 To: Hans Nordebäck <hans.nordeb...@ericsson.com> Cc: Minh Chau H <minh.c...@dektech.com.au>; o

Re: [devel] [PATCH 1 of 1] amfd: assert in avd_compcsi_cleanup_imm_object [#2081]

ansN On 10/03/2016 02:59 PM, Hans Nordebäck wrote: > > yes, you are right, the continue is missing, I'll add it. /Thanks HansN > > > On 10/03/2016 10:22 AM, Gary Lee wrote: >> Hi >> >> Sorry, I missed the bit where comp is references later: >> >> susi = a

Re: [devel] [PATCH 1 of 1] amfd: assert in avd_compcsi_cleanup_imm_object [#2081]

yes, you are right, the continue is missing, I'll add it. /Thanks HansN On 10/03/2016 10:22 AM, Gary Lee wrote: > Hi > > Sorry, I missed the bit where comp is references later: > > susi = avd_susi_find(avd_cb, comp->su->name, si->name); > > I guess there should be a continue, after comp is null?

Re: [devel] [PATCH 1 of 1] clm: add support for cluster reboot V3 [#2053]

ess. But yes, not applicable in the current scenario) > > Thanks, > Mathi. > >> -Original Message- >> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] >> Sent: Monday, October 03, 2016 5:00 PM >> To: Mathivanan Naickan Palanivelu; anders.wid...@ericsso

Re: [devel] [PATCH 1 of 1] clm: add support for cluster reboot V3 [#2053]

, Mathivanan Naickan Palanivelu wrote: > Hans, > ACK after fixing Anders' and two of my comments inlined as [Mathi]. > > Thanks, > Mathi. > >> -Original Message- >> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] >> Sent: Friday, September 30, 20

Re: [devel] [PATCH 1 of 1] dtm: Convert transport monitor script to a daemon [#2035]

One very minor comment, instead of the busy wait we may check if e.g. inotify can be used for daemons and implement a "wrapper" for easier use? /BR HansN -Original Message- From: Anders Widell [mailto:anders.wid...@ericsson.com] Sent: den 22 september 2016 13:17 To:

Re: [devel] [PATCH 1 of 1] clm: add support for cluster reboot V3 [#2053]

Hi Anders, thanks for the comments, I have updated the patch accordingly. Mathi have you had any time to look at the patch? /BR HansN -Original Message- From: Anders Widell Sent: den 29 september 2016 14:29 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; mathi.naic...@oracle.

Re: [devel] [PATCH 1 of 1] amfnd: correct logging during assignment and syncing after SC absence state[#2062]

ack, code review only/Thanks HansN On 09/22/2016 12:42 PM, praveen.malv...@oracle.com wrote: > osaf/services/saf/amf/amfnd/di.cc | 2 +- > osaf/services/saf/amf/amfnd/sidb.cc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > > diff --git a/osaf/services/saf/amf/amfnd/di.cc

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

sync", "msg id mismatch" and so on? /Regards HansN -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: den 20 september 2016 12:29 To: Anders Widell <anders.wid...@ericsson.com>; Hans Nordebäck <hans.nordeb...@ericsson.com> Cc: opens

Re: [devel] [PATCH 1 of 1] amf: fix activeCompName in csiStateDescriptor used in CSI SET cbk [#2021]

Ack, code review only./Thanks HansN -Original Message- From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com] Sent: den 15 september 2016 11:42 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; nagendr...@oracle.com; Gary Lee <gary@dektech.com.au>; M

Re: [devel] [PATCH 1 of 1] amfd: fix amfd crash while dumping state [#1995]

Hi Praveen, ack, one comment below. /Thanks HansN On 09/08/2016 03:20 PM, praveen.malv...@oracle.com wrote: > osaf/services/saf/amf/amfd/imm.cc | 6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > > diff --git a/osaf/services/saf/amf/amfd/imm.cc >

Re: [devel] [PATCH 1 of 1] AMFND: Fix amfnd coredump if sc failover while shutting down [#2008]

ack, code review only/Thanks HansN On 09/08/2016 02:01 PM, Minh Hon Chau wrote: > osaf/libs/common/amf/include/amf_db_template.h | 11 +++ > osaf/services/saf/amf/amfnd/clc.cc | 6 ++ > osaf/services/saf/amf/amfnd/term.cc| 16 ++-- > 3

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi Mahesh, Any updates on this? /Thanks HansN -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: den 1 september 2016 07:55 To: Hans Nordebäck <hans.nordeb...@ericsson.com> Cc: opensaf-devel@lists.sourceforge.net; Anders Widell <anders.wid...@eri

Re: [devel] [PATCH 1 of 1] amf: update mds version in main process[#1996]

ack, code review and tests run. /Thanks HansN On 09/07/2016 02:03 PM, praveen.malv...@oracle.com wrote: > osaf/services/saf/amf/amfd/csiattr.cc | 2 + > osaf/services/saf/amf/amfd/include/evt.h| 6 + > osaf/services/saf/amf/amfd/include/proc.h | 1 + >

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

s. > > -AVM > > > On 9/1/2016 9:12 AM, A V Mahesh wrote: >> Hi HansN, >> >> Sorry for the delay. >> >> I will test it and get back to you soon. >> >> -AVM >> >> >> On 8/31/2016 4:29 PM, Hans Nordebäck wrote: >>> Hi Mahes

Re: [devel] staging changeset: 7982 with gcc version 4.8.3 build failed

/HansN On 08/31/2016 12:10 PM, Mathivanan Naickan Palanivelu wrote: > Iam looking into this. > > Thanks, > Mathi. > >> -Original Message- >> From: A V Mahesh >> Sent: Tuesday, August 30, 2016 2:10 PM >> To: Hans Nordebäck; Zoran Milinkovic >

Re: [devel] [PATCH 1 of 1] amfnd: Incorrect ER messages in syslog [#1989]

Ack, code review only/Thanks HansN -Original Message- From: Long HB Nguyen [mailto:long.hb.ngu...@dektech.com.au] Sent: den 31 augusti 2016 06:29 To: Gary Lee <gary@dektech.com.au>; Hans Nordebäck <hans.nordeb...@ericsson.com>; Minh Hon Chau <minh.c...@dektech.co

Re: [devel] staging changeset: 7982 with gcc version 4.8.3 build failed

Hi Mahesh, One question/comment below. /Thanks HansN -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: den 30 augusti 2016 08:09 To: praveen malviya ; opensaf-devel@lists.sourceforge.net Subject: Re: [devel] staging changeset: 7982

Re: [devel] [PATCH 1 of 1] amf: add saAmf_B_04_02.h in opensaf.spec.in [#1982]

ack, code review only/Thanks HansN On 08/30/2016 07:36 AM, praveen.malv...@oracle.com wrote: > opensaf.spec.in | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > > diff --git a/opensaf.spec.in b/opensaf.spec.in > --- a/opensaf.spec.in > +++ b/opensaf.spec.in > @@ -1457,6 +1457,7

Re: [devel] [PATCH 1 of 1] amfd: fix compilation issue with gcc 6.1.1 [#1980]

ack, code review only/Thanks HansN On 08/30/2016 07:26 AM, praveen.malv...@oracle.com wrote: > osaf/services/saf/amf/amfd/util.cc | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > > diff --git a/osaf/services/saf/amf/amfd/util.cc > b/osaf/services/saf/amf/amfd/util.cc > ---

Re: [devel] [PATCH 1 of 1] amfd: fix cppcheck errors [#1642]

ack, code review only/Thanks HansN On 08/29/2016 08:13 AM, Gary Lee wrote: > osaf/services/saf/amf/amfd/ckpt_enc.cc | 2 +- > osaf/services/saf/amf/amfd/ndproc.cc | 8 > osaf/services/saf/amf/amfd/role.cc | 3 +-- > 3 files changed, 6 insertions(+), 7 deletions(-) > > >

Re: [devel] [PATCH 1 of 1] amfnd: cppcheck warnings with severity error [#1642]

ack, code review only/Thanks HansN On 08/29/2016 08:25 AM, Long HB Nguyen wrote: > osaf/services/saf/amf/amfnd/cbq.cc | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > > diff --git a/osaf/services/saf/amf/amfnd/cbq.cc > b/osaf/services/saf/amf/amfnd/cbq.cc > ---

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

to choose connection oriented or connection less. The problem with dropped messages seems in one case related to, (by MDS), intensive MDS logging. /Thanks HansN -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: den 23 augusti 2016 11:27 To: Hans Nordebäck <hans.nor

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi Mahesh, Please see response below with [HansN] /Thanks HansN -Original Message- From: A V Mahesh [mailto:mahesh.va...@oracle.com] Sent: den 23 augusti 2016 08:25 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; Anders Widell <anders.wid...@ericsson.com>; mathi.naic...@o

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi Mahesh, please see comments below. /Thanks HansN On 08/23/2016 07:21 AM, A V Mahesh wrote: > Hi HansN, > > Let us fist discuss the error handling and abort, then we can come > back to > interpretation of TIPC currently does permit OR does not permit an > application to send > a

Re: [devel] [PATCH 1 of 1] MDS: Log TIPC dropped messages [#1957]

Hi Mahesh, there is a problem that TIPC may silently drop messages at overload situations, as MDS uses the SOCK_RDM option. At least it has to be logged when messages are dropped. It is allowed in TIPC to set TIPC_DROPPABLE=false and also use multicast. The concern may be that the send buffer

Re: [devel] [PATCH 1 of 1] pyosaf: Add __str__ method into non extended SaNameT class [#1737]

ack, code review only/Thanks HansN On 08/05/2016 05:53 AM, Quyen Dao wrote: > Hi, > > Please help review! > > Thanks, > Quyen > > -Original Message- > From: Quyen Dao [mailto:quyen@dektech.com.au] > Sent: Wednesday, May 25, 2016 11:45 AM > To: hans.nordeb...@ericsson.com;

Re: [devel] [PATCH 1 of 1] AMFD: Correct the size of synchronizing node after headless [#1984]

Ack, code review only. The ticket no is incorrect in the subject should be #1894/Thanks HansN -Original Message- From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] Sent: den 29 juni 2016 02:48 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; nagendr...@oracle.com; pravee

Re: [devel] [PATCH 1 of 1] amfnd: fix amfnd crash during su and node level escalations [#1770] V2

ack, code review only/Thanks HansN On 06/20/2016 08:35 AM, praveen.malv...@oracle.com wrote: > osaf/services/saf/amf/amfnd/err.cc | 19 +++ > osaf/services/saf/amf/amfnd/su.cc | 16 > osaf/services/saf/amf/amfnd/susm.cc | 2 +- > 3 files changed, 36

<    1   2   3   4   5   6   7   >