Re: [devel] [PATCH 1 of 1] nid: Use the FIFO monitoring for started services V2 [#2204]

2016-12-26 Thread praveen malviya
rom: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] >>> Sent: Tuesday, December 20, 2016 4:21 PM >>> To: Mathivanan Naickan Palanivelu; Ramesh Babu Betham >>> Cc: opensaf-devel@lists.sourceforge.net; Praveen Malviya; Anders Widell >>> Subject: RE: [devel] [PATCH

Re: [devel] [PATCH 1 of 1] nid: Use the FIFO monitoring for started services V2 [#2204]

2016-12-21 Thread Hans Nordeback
t;> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com] >> Sent: Tuesday, December 20, 2016 4:21 PM >> To: Mathivanan Naickan Palanivelu; Ramesh Babu Betham >> Cc: opensaf-devel@lists.sourceforge.net; Praveen Malviya; Anders Widell >> Subject: RE: [devel] [PATCH 1 of 1] nid: Us

Re: [devel] [PATCH 1 of 1] nid: Use the FIFO monitoring for started services V2 [#2204]

2016-12-21 Thread Mathivanan Naickan Palanivelu
> Sent: Tuesday, December 20, 2016 4:21 PM > To: Mathivanan Naickan Palanivelu; Ramesh Babu Betham > Cc: opensaf-devel@lists.sourceforge.net; Praveen Malviya; Anders Widell > Subject: RE: [devel] [PATCH 1 of 1] nid: Use the FIFO monitoring for started > services V2 [#2204] > > Hi Ma

Re: [devel] [PATCH 1 of 1] nid: Use the FIFO monitoring for started services V2 [#2204]

2016-12-20 Thread Hans Nordebäck
.net Subject: Re: [devel] [PATCH 1 of 1] nid: Use the FIFO monitoring for started services V2 [#2204] Hi Mathi, please see comment inlined with [HansN]. /Thanks HansN On 12/19/2016 01:05 PM, Mathivanan Naickan Palanivelu wrote: > Hi Hans, > > Quick comments > > (a) Rem

Re: [devel] [PATCH 1 of 1] nid: Use the FIFO monitoring for started services V2 [#2204]

2016-12-19 Thread Hans Nordeback
Hi Mathi, please see comment inlined with [HansN]. /Thanks HansN On 12/19/2016 01:05 PM, Mathivanan Naickan Palanivelu wrote: > Hi Hans, > > Quick comments > > (a) Remove the comma below: > + {"CLMD", "osafclmd.fifo", -1}, [HansN] I have removed the comma. > > (b) NULL is not a part of c++11 r

Re: [devel] [PATCH 1 of 1] nid: Use the FIFO monitoring for started services V2 [#2204]

2016-12-19 Thread Mathivanan Naickan Palanivelu
Hi Hans, Quick comments (a) Remove the comma below: + {"CLMD", "osafclmd.fifo", -1}, (b) NULL is not a part of c++11 right. (c) I'm not sure there is an obvious reason for converting this file to c++ Thanks, Mathi. > -Original Message- > From: Hans Nordeback [mailto:hans.nordeb...@er

Re: [devel] [PATCH 1 of 1] nid: Use the FIFO monitoring for started services V2 [#2204]

2016-12-18 Thread Hans Nordeback
Hi Anders, thanks, I'll update/Regards HansN On 12/16/2016 04:06 PM, Anders Widell wrote: > Ack with comments, marked AndersW>. > > regards, > > Anders Widell > > > On 12/13/2016 02:56 PM, Hans Nordeback wrote: >> osaf/services/infrastructure/nid/Makefile.am |2 +- >> osaf/services/infrastr

Re: [devel] [PATCH 1 of 1] nid: Use the FIFO monitoring for started services V2 [#2204]

2016-12-16 Thread Anders Widell
Ack with comments, marked AndersW>. regards, Anders Widell On 12/13/2016 02:56 PM, Hans Nordeback wrote: > osaf/services/infrastructure/nid/Makefile.am |2 +- > osaf/services/infrastructure/nid/nodeinit.c | 285 > ++- > 2 files changed, 278 insertions(+), 9 de

Re: [devel] [PATCH 1 of 1] nid: Use the FIFO monitoring for started services V2 [#2204]

2016-12-15 Thread praveen malviya
Ack from me. Note:For pushing in other branches there is dependency on FileNotify infrastructure developed in ticket #2091. Currently #2091 is not pushed in other branches. Thanks, Praveen On 13-Dec-16 7:26 PM, Hans Nordeback wrote: > osaf/services/infrastructure/nid/Makefile.am |2 +- >

[devel] [PATCH 1 of 1] nid: Use the FIFO monitoring for started services V2 [#2204]

2016-12-13 Thread Hans Nordeback
osaf/services/infrastructure/nid/Makefile.am |2 +- osaf/services/infrastructure/nid/nodeinit.c | 285 ++- 2 files changed, 278 insertions(+), 9 deletions(-) diff --git a/osaf/services/infrastructure/nid/Makefile.am b/osaf/services/infrastructure/nid/Makefile.am --