Re: [opensc-devel] [PATCH 2/3] libp11: API change: change id_len from int to size_t

2008-08-19 Thread Andreas Jellinghaus
Hi Stanislav, can you resend this patch as attachment? your mailer broke the long lines I guess, doesn't apply :( Regards, Andreas ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-

Re: [opensc-devel] one small porting change to the pam_pkcs11 module

2008-08-19 Thread Huie-Ying Lee
Ludovic Rousseau wrote: > On Mon, Aug 18, 2008 at 11:58 PM, Huie-Ying Lee <[EMAIL PROTECTED]> wrote: > >> Thought it a little bit more on this ... >> Although my changes work fine, it use more memory than it needs. >> Adding an implementation of strndup() on a platform without it is a better >>

[opensc-devel] [PATCH 3/3] libp11: increase library serial

2008-08-19 Thread Stanislav Brabec
As both previous patches changed ABI (at least on x86_64), increasing of soname is required. --- configure.ac +++ configure.ac @@ -20,9 +20,9 @@ # (Code changed: REVISION++) # (Oldest interface removed: OLDEST++) # (Interfaces added: CURRENT+

[opensc-devel] [PATCH 2/3] libp11: API change: change id_len from int to size_t

2008-08-19 Thread Stanislav Brabec
Currently id_len is declared as integer, but in come contexts it is used as size_t. On some 64-bit platforms, these sizes and simple cast may work incorrectly. Actually, these two places of code Casts while calling pkcs11_getattr_var() will make it most probably crashing: Compiler will either try

[opensc-devel] [PATCH 1/3] libp11: minor API fix of PKCS11_CTX_init_args()

2008-08-19 Thread Stanislav Brabec
Hallo. As documentation says, PKCS11_CTX_init_args() returns "none". In the implementation it really returns none (i. e. it is void), but in both declaration and header it is declared as "void*" (i. e. non-void). I suspect that it was really intended as void. Here is a fix. --- src/libp11.h +++

Re: [opensc-devel] Code for ePass3000 accomplished

2008-08-19 Thread Weitao Sun
Ludovic Rousseau wrote: > On Mon, Aug 18, 2008 at 10:25 PM, Andreas Jellinghaus > <[EMAIL PROTECTED]> wrote: > >> Am Freitag, 15. August 2008 07:14:12 schrieb Weitao Sun: >> >>> Hello, >>> >>> The attachment is the patch file. Let me know if you have any comments. >>> Thank you. >>>

Re: [opensc-devel] one small porting change to the pam_pkcs11 module

2008-08-19 Thread Ludovic Rousseau
On Mon, Aug 18, 2008 at 11:58 PM, Huie-Ying Lee <[EMAIL PROTECTED]> wrote: > Thought it a little bit more on this ... > Although my changes work fine, it use more memory than it needs. > Adding an implementation of strndup() on a platform without it is a better > solution. > > Can we add this into

Re: [opensc-devel] Code for ePass3000 accomplished

2008-08-19 Thread Ludovic Rousseau
On Mon, Aug 18, 2008 at 10:25 PM, Andreas Jellinghaus <[EMAIL PROTECTED]> wrote: > Am Freitag, 15. August 2008 07:14:12 schrieb Weitao Sun: >> Hello, >> >> The attachment is the patch file. Let me know if you have any comments. >> Thank you. > > Hi Weitao, > > thanks for sending the diff. a few sm