Re: [opensc-devel] ID of cryptographic objects

2009-11-11 Thread Aleksey Samsonov
Viktor TARASOV: > Aktiv Co. Aleksey Samsonov wrote: >> Viktor TARASOV: >>> Aktiv Co. Aleksey Samsonov wrote: Viktor TARASOV: >>> > It's commited ... Thanks, good work. --- /trunk/src/libopensc/pkcs15-pubkey.c (revision 3818) +++ /trunk/src/libopensc/pkcs15-pubkey.c (revision 3820) @@

Re: [opensc-devel] ID of cryptographic objects

2009-11-11 Thread Viktor TARASOV
Aktiv Co. Aleksey Samsonov wrote: > Viktor TARASOV: >> Aktiv Co. Aleksey Samsonov wrote: >>> Viktor TARASOV: >> It's commited ... >>> Thanks, but some remarks: >>> >>> Potencial memory leaks (see /* */): >> >> Thanks for your code revision. I'll be more attentive. >> >> Considering the 'SC_ER

Re: [opensc-devel] ID of cryptographic objects

2009-11-11 Thread Aktiv Co. Aleksey Samsonov
Viktor TARASOV: > Aktiv Co. Aleksey Samsonov wrote: >> Viktor TARASOV: > >>> It's commited ... >> Thanks, but some remarks: >> >> Potencial memory leaks (see /* */): > > Thanks for your code revision. I'll be more attentive. > > Considering the 'SC_ERROR_OUT_OF_MEMORY' error, > IMHO, it's quiet

Re: [opensc-devel] ID of cryptographic objects

2009-11-11 Thread Viktor TARASOV
Aktiv Co. Aleksey Samsonov wrote: > Viktor TARASOV: >> It's commited ... > > Thanks, but some remarks: > > Potencial memory leaks (see /* */): Thanks for your code revision. I'll be more attentive. Considering the 'SC_ERROR_OUT_OF_MEMORY' error, IMHO, it's quiet dangerous to regroup the allocati

Re: [opensc-devel] ID of cryptographic objects

2009-11-11 Thread Aktiv Co. Aleksey Samsonov
Viktor TARASOV: > Aktiv Co. Aleksey Samsonov wrote: >> Viktor TARASOV: >>> Hi, >> Hi Hi, >>> Nevertheless, IMHO, it would be nice, for the cryptographic objects (and >>> maybe for the others) >>> to have the possibility of some unique ID calculated from the object >>> itself, as it was discussed

Re: [opensc-devel] ID of cryptographic objects

2009-11-11 Thread Viktor TARASOV
Aktiv Co. Aleksey Samsonov wrote: > Viktor TARASOV: >> Hi, > > Hi > >> Nevertheless, IMHO, it would be nice, for the cryptographic objects (and >> maybe for the others) >> to have the possibility of some unique ID calculated from the object >> itself, as it was discussed in thread: >> 'CKA_ID and p

Re: [opensc-devel] Small bug + possible bug (or by design?)

2009-11-11 Thread Viktor TARASOV
Martin Paljak wrote: > On 10.11.2009, at 17:02, Mats Andersson wrote: > >> Specific feedback/question about EF(DIR) file usage: It could be useful to >> be able to “by config” inject new AIDs of known applications (i.e. into apps >> in dir.c) which comply with PKCS15 but that uses EF(DIR) to p

Re: [opensc-devel] Small bug + possible bug (or by design?)

2009-11-11 Thread Martin Paljak
Hi. On 10.11.2009, at 17:02, Mats Andersson wrote: > This is in stock opensc-0.11.11. > > Smallish bug: (tried mailing b...@opensc-project.org but it failed) > pkcs15.c:760: > Usage of strstr() inverted (works anyway since it’s || and the contents > of the if() is mostly harmless, it will mo

[opensc-devel] Fwd: Small bug + possible bug (or by design?)

2009-11-11 Thread Andreas Jellinghaus
Hi, some feedback I got to bugs@, could you have a look? -- Weitergeleitete Nachricht -- Betreff: Small bug + possible bug (or by design?) Datum: Dienstag 10 November 2009 Von: Mats Andersson An: "b...@opensc-project.org" This is in stock opensc-0.11.11. Bug: pkcs15.c:760: