Re: [opensc-devel] [RFC] Proposal For Restructuring 'struct sc_pkcs15_card'

2010-10-05 Thread Martin Paljak
Hello, On Tue, Sep 28, 2010 at 23:08, Andre Zepezauer andre.zepeza...@student.uni-halle.de wrote: Attached is the final patch. Naming of flags as mentioned above. All changes were trivial with the exception of pkcs15init/pkcs15-oberthur.c Thanks! Commited in r4788 [1] [1]

Re: [opensc-devel] [RFC] Proposal For Restructuring 'struct sc_pkcs15_card'

2010-09-29 Thread Andre Zepezauer
On Tue, 2010-09-28 at 15:47 +0300, Martin Paljak wrote: Hello, On Sep 28, 2010, at 3:30 PM, Andre Zepezauer wrote: personally I would like to keep this patch specific to the separation of attributes from (public) TokenInfo and (internal) sc_pkcs15_card structure. Fixing the use of

Re: [opensc-devel] [RFC] Proposal For Restructuring 'struct sc_pkcs15_card'

2010-09-28 Thread Viktor TARASOV
Andre Zepezauer wrote: Dear OpenSC developers, the patch I proposed is mostly complete. The total count of lines is huge, but individual changes are trivial. An exception to this is the pkcs15 emulation related to the Oberthur cards. It makes heavy use of flags before writing the TokenInfo

Re: [opensc-devel] [RFC] Proposal For Restructuring 'struct sc_pkcs15_card'

2010-09-28 Thread Andre Zepezauer
On Tue, 2010-09-28 at 10:08 +0200, Viktor TARASOV wrote: Andre Zepezauer wrote: Dear OpenSC developers, the patch I proposed is mostly complete. The total count of lines is huge, but individual changes are trivial. An exception to this is the pkcs15 emulation related to the Oberthur

Re: [opensc-devel] [RFC] Proposal For Restructuring 'struct sc_pkcs15_card'

2010-09-28 Thread Andre Zepezauer
Hello Martin, personally I would like to keep this patch specific to the separation of attributes from (public) TokenInfo and (internal) sc_pkcs15_card structure. Fixing the use of tokeninfo-version is another task and therefore I would suggest a separate patch for that one. The matter of

Re: [opensc-devel] [RFC] Proposal For Restructuring 'struct sc_pkcs15_card'

2010-09-28 Thread Martin Paljak
Hello, On Sep 28, 2010, at 3:30 PM, Andre Zepezauer wrote: personally I would like to keep this patch specific to the separation of attributes from (public) TokenInfo and (internal) sc_pkcs15_card structure. Fixing the use of tokeninfo-version is another task and therefore I would suggest a

Re: [opensc-devel] [RFC] Proposal For Restructuring 'struct sc_pkcs15_card'

2010-09-27 Thread Andre Zepezauer
Dear OpenSC developers, the patch I proposed is mostly complete. The total count of lines is huge, but individual changes are trivial. An exception to this is the pkcs15 emulation related to the Oberthur cards. It makes heavy use of flags before writing the TokenInfo to the card. Since the two

Re: [opensc-devel] [RFC] Proposal For Restructuring 'struct sc_pkcs15_card'

2010-09-27 Thread Martin Paljak
Hello, On Sep 27, 2010, at 9:59 PM, Andre Zepezauer wrote: the patch I proposed is mostly complete. The total count of lines is huge, but individual changes are trivial. An exception to this is the pkcs15 emulation related to the Oberthur cards. It makes heavy use of flags before writing the

[opensc-devel] [RFC] Proposal For Restructuring 'struct sc_pkcs15_card'

2010-09-17 Thread Andre Zepezauer
Dear opensc developers, I would like to propose the following simplification of the internal 'struct sc_pkcs15_card'. typedef struct sc_pkcs15_card { sc_card_t *card; unsigned int flags; unsigned int magic; unsigned int pin_cache_counter; sc_file_t

Re: [opensc-devel] [RFC] Proposal For Restructuring 'struct sc_pkcs15_card'

2010-09-17 Thread Martin Paljak
Hello, Nice! (Comments inline) On Sep 17, 2010, at 3:03 PM, Andre Zepezauer wrote: I would like to propose the following simplification of the internal 'struct sc_pkcs15_card'. ... The main difference to the current definition is, that everything that belongs to tokeninfo would be accessible