Re: [opensc-devel] [RFC] removal of more split-key related pieces

2010-06-25 Thread Andreas Jellinghaus
If you initialize a card with old opensc and split-key, and then try to use or alter it with the new opensc with that patch, does it still work? I didn't touch some parts of the code, because I feared to break support for old opensc cards initialized with split-key. we should never do that IMO, ev

Re: [opensc-devel] [RFC] removal of more split-key related pieces

2010-06-24 Thread Andre Zepezauer
On Thu, 2010-06-24 at 14:47 +0300, Martin Paljak wrote: > Hello, > > On Jun 24, 2010, at 12:47 , Andre Zepezauer wrote: > > Ludovic Rousseau wrote: > >> Why not just remove the lines if they are useless now? > >> > > Because it makes the process of reviewing much easier. One could apply the > >

Re: [opensc-devel] [RFC] removal of more split-key related pieces

2010-06-24 Thread Martin Paljak
Hello, On Jun 24, 2010, at 12:47 , Andre Zepezauer wrote: > Ludovic Rousseau wrote: >> Why not just remove the lines if they are useless now? >> > Because it makes the process of reviewing much easier. One could apply the > patch local and see the hole context of the pieces which are considered

Re: [opensc-devel] [RFC] removal of more split-key related pieces

2010-06-24 Thread Andre Zepezauer
Ludovic Rousseau wrote: 2010/6/24 Andre Zepezauer : Dear all, Hello, in the attached patch I have collected some pieces of code, which I consider for obsolete sine r4113 (removal of split-key concept). This patch is maintains only and as this may have a lower priority. Why

Re: [opensc-devel] [RFC] removal of more split-key related pieces

2010-06-24 Thread Ludovic Rousseau
2010/6/24 Andre Zepezauer : > Dear all, Hello, > in the attached patch I have collected some pieces of code, which I > consider for obsolete sine r4113 (removal of split-key concept). This > patch is maintains only and as this may have a lower priority. Why not just remove the lines if they are

[opensc-devel] [RFC] removal of more split-key related pieces

2010-06-24 Thread Andre Zepezauer
Dear all, in the attached patch I have collected some pieces of code, which I consider for obsolete sine r4113 (removal of split-key concept). This patch is maintains only and as this may have a lower priority. Kind Regards Andre Zepezauer Index: pkcs11/framework-pkcs15.c ==