Re: [opensc-devel] Buffer size and defining constant

Le 23 avril 2012 11:41, Nguyễn Hồng Quân a écrit : > Thanks, > Because I focus on OpenPGP support, I base my branch on Martin's. > Some coding convention (from GNU C for example) recommend not to place > any space character at the end of lines. I think doing such is a good > practice. I fully agr

Re: [opensc-devel] Buffer size and defining constant

Thanks, Because I focus on OpenPGP support, I base my branch on Martin's. Some coding convention (from GNU C for example) recommend not to place any space character at the end of lines. I think doing such is a good practice. Because I just start with this project, I think I should let my modifi

Re: [opensc-devel] Buffer size and defining constant

Le 23 avril 2012 11:09, Nguyễn Hồng Quân a écrit : > Thanks, > I made a pull request at https://github.com/martinpaljak/OpenSC/pull/19 I can't accept your pull request because: - you cloned martinpaljak/OpenSC instead of OpenSC/OpenSC - use the staging branch instead of the master branch - you ma

Re: [opensc-devel] Buffer size and defining constant

Thanks, I made a pull request at https://github.com/martinpaljak/OpenSC/pull/19 On 04/23/2012 03:05 PM, Frank Morgner wrote: > On Monday, April 23 at 02:11PM, Nguyễn Hồng Quân wrote: >> Hello all, >> >> I'm starting to code for OpenSC (with the focus on OpenPGP card). >> I found in opensc-explorer

Re: [opensc-devel] Buffer size and defining constant

Hello, On Mon, Apr 23, 2012 at 11:05, Frank Morgner wrote: > On Monday, April 23 at 02:11PM, Nguyễn Hồng Quân wrote: >> Hello all, >> >> I'm starting to code for OpenSC (with the focus on OpenPGP card). >> I found in opensc-explorer.c, the do_update_binary() and >> do_update_record() function use

Re: [opensc-devel] Buffer size and defining constant

On Monday, April 23 at 02:11PM, Nguyễn Hồng Quân wrote: > Hello all, > > I'm starting to code for OpenSC (with the focus on OpenPGP card). > I found in opensc-explorer.c, the do_update_binary() and > do_update_record() function use the buffer of 240bytes in size. > I want to know if 240 is just co

[opensc-devel] Buffer size and defining constant

Hello all, I'm starting to code for OpenSC (with the focus on OpenPGP card). I found in opensc-explorer.c, the do_update_binary() and do_update_record() function use the buffer of 240bytes in size. I want to know if 240 is just convention or a limit of something? I want to replace the hardcode wit