Re: [opensc-devel] Minidriver assume hexstring encoding for card serial number

2012-08-22 Thread Douglas E. Engert
On 8/22/2012 1:53 PM, Andreas Schwier wrote: > Yes, that's basically what our patch is all about. There are actually > two places in minidriver.c where the tokeninfo->serial_number value is > copied. We propose to change both as you can see in [1]. Looks good. > > Andreas > > [1] > https://gith

Re: [opensc-devel] Minidriver assume hexstring encoding for card serial number

2012-08-22 Thread Andreas Schwier
Yes, that's basically what our patch is all about. There are actually two places in minidriver.c where the tokeninfo->serial_number value is copied. We propose to change both as you can see in [1]. Andreas [1] https://github.com/CardContact/OpenSC/commit/724cdd06e23ecd2e822bd1f138d9c3fbdafe9324

Re: [opensc-devel] Minidriver assume hexstring encoding for card serial number

2012-08-22 Thread Douglas E. Engert
On 8/22/2012 11:24 AM, Andreas Schwier (ML) wrote: > Hi Douglas, > > see below. > > Am 22.08.2012 18:00, schrieb Douglas E. Engert: >> >> On 8/22/2012 10:09 AM, Andreas Schwier wrote: >>> Hi Douglas, >>> >>> thanks for your infos. >>> >>> The minidriver.c already ensures that the cardid file is a

Re: [opensc-devel] Minidriver assume hexstring encoding for card serial number

2012-08-22 Thread Andreas Schwier (ML)
Hi Douglas, see below. Am 22.08.2012 18:00, schrieb Douglas E. Engert: > > On 8/22/2012 10:09 AM, Andreas Schwier wrote: >> Hi Douglas, >> >> thanks for your infos. >> >> The minidriver.c already ensures that the cardid file is always 16 byte. >> It does this by repeating the token serial number

Re: [opensc-devel] Minidriver assume hexstring encoding for card serial number

2012-08-22 Thread Douglas E. Engert
On 8/22/2012 10:09 AM, Andreas Schwier wrote: > Hi Douglas, > > thanks for your infos. > > The minidriver.c already ensures that the cardid file is always 16 byte. > It does this by repeating the token serial number until 16 bytes are filled. Unfortunately that gives OpenbSC 16 bytes but does no

Re: [opensc-devel] Minidriver assume hexstring encoding for card serial number

2012-08-22 Thread Andreas Schwier
Hi Douglas, thanks for your infos. The minidriver.c already ensures that the cardid file is always 16 byte. It does this by repeating the token serial number until 16 bytes are filled. We can ensure uniqueness of the serial number for our cards, but no uniqueness among all other card vendors. Th

Re: [opensc-devel] Minidriver assume hexstring encoding for card serial number

2012-08-22 Thread Douglas E. Engert
On 8/22/2012 5:28 AM, Andreas Schwier (ML) wrote: > Hi everyone, > > we've come across an issue with the minidriver which assumes the card > serial number to be a hex string. > > In our card the serial number is a string composed of ASCII characters. > This works well with pkcs15-tool and the PKC

[opensc-devel] Minidriver assume hexstring encoding for card serial number

2012-08-22 Thread Andreas Schwier (ML)
Hi everyone, we've come across an issue with the minidriver which assumes the card serial number to be a hex string. In our card the serial number is a string composed of ASCII characters. This works well with pkcs15-tool and the PKCS#11 library, however it fails with the current minidriver when