Re: [opensc-devel] r5124

2011-03-07 Thread Andre Zepezauer
On Mon, 2011-02-28 at 15:33 +0100, Andre Zepezauer wrote: > Hello Martin, > > I would like to commit the attached patch. Any objections? Committed in r5222. > On Thu, 2011-02-03 at 14:36 +0200, Martin Paljak wrote: > > Hello, > > > > On Thu, Jan 27, 2011 at 20:08, Andre Zepezauer > > wrote: >

Re: [opensc-devel] r5124

2011-02-28 Thread Andre Zepezauer
Hello Martin, I would like to commit the attached patch. Any objections? On Thu, 2011-02-03 at 14:36 +0200, Martin Paljak wrote: > Hello, > > On Thu, Jan 27, 2011 at 20:08, Andre Zepezauer > wrote: > > Hello Martin, > > > > some comments on r5124: > > > > 1. The values of pin_info->reference an

Re: [opensc-devel] r5124

2011-02-03 Thread Martin Paljak
On Feb 3, 2011, at 3:22 PM, Andre Zepezauer wrote: > That patch could be some lines shorter when using > sc_pkcs15_compare_id(). Additionally that would improve readability. > > I don't know what kind of function you did mean. Extracting only that > patch into a new function? I mean the lookup f

Re: [opensc-devel] r5124

2011-02-03 Thread Andre Zepezauer
On Thu, 2011-02-03 at 14:36 +0200, Martin Paljak wrote: > Hello, > > On Thu, Jan 27, 2011 at 20:08, Andre Zepezauer > wrote: > > Hello Martin, > > > > some comments on r5124: > > > > 1. The values of pin_info->reference and prkey_info->key_reference > > shouldn't be compared because: > > > > * pi

Re: [opensc-devel] r5124

2011-02-03 Thread Martin Paljak
Hello, On Thu, Jan 27, 2011 at 20:08, Andre Zepezauer wrote: > Hello Martin, > > some comments on r5124: > > 1. The values of pin_info->reference and prkey_info->key_reference > shouldn't be compared because: > > * pin_info->reference is used as P2 parameter in VERIFY command > * prkey_info->key_

Re: [opensc-devel] r5124

2011-01-28 Thread Martin Paljak
Hello, On Jan 27, 2011, at 8:08 PM, Andre Zepezauer wrote: > some comments on r5124: > > 1. The values of pin_info->reference and prkey_info->key_reference > shouldn't be compared because: > > * pin_info->reference is used as P2 parameter in VERIFY command > * prkey_info->key_reference is used i

[opensc-devel] r5124

2011-01-27 Thread Andre Zepezauer
Hello Martin, some comments on r5124: 1. The values of pin_info->reference and prkey_info->key_reference shouldn't be compared because: * pin_info->reference is used as P2 parameter in VERIFY command * prkey_info->key_reference is used in MSE SET tag 0x84 There is no relation between these two