Re: [opensc-devel] pam_pkcs11: more implicit and conflicting declaration fixes

2008-11-06 Thread Ludovic Rousseau
On Tue, Nov 4, 2008 at 7:46 PM, Robert Relyea <[EMAIL PROTECTED]> wrote: > Ludovic Rousseau wrote: >> >> On Fri, Oct 31, 2008 at 12:25 AM, Robert Relyea <[EMAIL PROTECTED]> >> wrote: >> >>> >>> Stanislav Brabec wrote: >>> Could it be implemented using CERT_DecodeDERCertificate()? >>>

Re: [opensc-devel] pam_pkcs11: more implicit and conflicting declaration fixes

2008-11-04 Thread Robert Relyea
Ludovic Rousseau wrote: On Fri, Oct 31, 2008 at 12:25 AM, Robert Relyea <[EMAIL PROTECTED]> wrote: Stanislav Brabec wrote: Could it be implemented using CERT_DecodeDERCertificate()? extern CERTCertificate * CERT_DecodeDERCertificate (SECItem *derSignedCert, PRBool copyDER, char *nickna

Re: [opensc-devel] pam_pkcs11: more implicit and conflicting declaration fixes

2008-11-04 Thread Ludovic Rousseau
On Fri, Oct 31, 2008 at 12:25 AM, Robert Relyea <[EMAIL PROTECTED]> wrote: > Stanislav Brabec wrote: >> Could it be implemented using CERT_DecodeDERCertificate()? >> >> extern CERTCertificate * >> CERT_DecodeDERCertificate (SECItem *derSignedCert, PRBool copyDER, char >> *nickname); >> > > Don't us

Re: [opensc-devel] pam_pkcs11: more implicit and conflicting declaration fixes

2008-11-04 Thread Ludovic Rousseau
On Tue, Oct 28, 2008 at 7:23 PM, Robert Relyea <[EMAIL PROTECTED]> wrote: > When identical certs are imported into NSS, they are given the same > reference counted pointer, so the test is as easy as: > cert1 == cert2 Commited in revision 354. Thanks. -- Dr. Ludovic Rousseau ___

Re: [opensc-devel] pam_pkcs11: more implicit and conflicting declaration fixes

2008-10-30 Thread Robert Relyea
Stanislav Brabec wrote: Robert Relyea wrote: When identical certs are imported into NSS, they are given the same reference counted pointer, so the test is as easy as: cert1 == cert2 Thanks, and what about d2i_X509() counterpart: undefined symbol: d2i_X509 (.libs/ldap

Re: [opensc-devel] pam_pkcs11: more implicit and conflicting declaration fixes

2008-10-29 Thread Stanislav Brabec
Robert Relyea wrote: >When identical certs are imported into NSS, they are given the same > reference counted pointer, so the test is as easy as: >cert1 == cert2 Thanks, and what about d2i_X509() counterpart: > > undefined symbol: d2i_X509 (.libs/ldap_mapper.so) > > > > So the libr

Re: [opensc-devel] pam_pkcs11: more implicit and conflicting declaration fixes

2008-10-28 Thread Robert Relyea
Ludovic Rousseau wrote: 2008/10/24 Stanislav Brabec <[EMAIL PROTECTED]>: Ludovic Rousseau wrote: 2008/10/17 Stanislav Brabec <[EMAIL PROTECTED]>: "Fixed" in revision 353. http://www.opensc-project.org/pam_pkcs11/changeset/353 Not yet completely. This seems to be critical

Re: [opensc-devel] pam_pkcs11: more implicit and conflicting declaration fixes

2008-10-28 Thread Ludovic Rousseau
2008/10/24 Stanislav Brabec <[EMAIL PROTECTED]>: > Ludovic Rousseau wrote: >> 2008/10/17 Stanislav Brabec <[EMAIL PROTECTED]>: > >> "Fixed" in revision 353. >> http://www.opensc-project.org/pam_pkcs11/changeset/353 > > Not yet completely. This seems to be critical: Not really critical in fact :-)

Re: [opensc-devel] pam_pkcs11: more implicit and conflicting declaration fixes

2008-10-24 Thread Stanislav Brabec
Ludovic Rousseau wrote: > 2008/10/17 Stanislav Brabec <[EMAIL PROTECTED]>: > "Fixed" in revision 353. > http://www.opensc-project.org/pam_pkcs11/changeset/353 Not yet completely. This seems to be critical: ldap_mapper.c: In function 'ldap_get_certificate': ldap_mapper.c:760: warning: assignment

Re: [opensc-devel] pam_pkcs11: more implicit and conflicting declaration fixes

2008-10-24 Thread Ludovic Rousseau
2008/10/17 Stanislav Brabec <[EMAIL PROTECTED]>: > Stanislav Brabec wrote: >> Ludovic Rousseau wrote: >> > But I have two warnings: >> > ldap_mapper.c:874: warning: passing argument 1 of 'X509_cmp' from >> > incompatible pointer type >> > ldap_mapper.c:874: warning: passing argument 2 of 'X509_cmp'

Re: [opensc-devel] pam_pkcs11: more implicit and conflicting declaration fixes

2008-10-17 Thread Stanislav Brabec
Stanislav Brabec wrote: > Ludovic Rousseau wrote: > > But I have two warnings: > > ldap_mapper.c:874: warning: passing argument 1 of 'X509_cmp' from > > incompatible pointer type > > ldap_mapper.c:874: warning: passing argument 2 of 'X509_cmp' from > > incompatible pointer type > > I spent a quite

Re: [opensc-devel] pam_pkcs11: more implicit and conflicting declaration fixes

2008-10-16 Thread Stanislav Brabec
Ludovic Rousseau wrote: > But I have two warnings: > ldap_mapper.c:874: warning: passing argument 1 of 'X509_cmp' from > incompatible pointer type > ldap_mapper.c:874: warning: passing argument 2 of 'X509_cmp' from > incompatible pointer type I spent a quite a lot of time to identify this problem.

Re: [opensc-devel] pam_pkcs11: more implicit and conflicting declaration fixes

2008-10-16 Thread Ludovic Rousseau
2008/10/15 Stanislav Brabec <[EMAIL PROTECTED]>: > Attached two patches fix compilation errors or warnings when compiling > with NSS support. > > Compiler messages are mentioned in patch headers. Corrected in revision 347 and 348. Thanks > Note that implicit declaration fix again refers to implic