Re: [opensc-devel] patch for pkcs15-crypt

2006-10-02 Thread Nils Larsch
Andreas Jellinghaus wrote: mandriva has a patch for pkcs15-crypt so it can accept pins from stdin. could someone please review this patch? maybe it is a nice addition we want to integrate? http://cvs.mandriva.com/cgi-bin/viewvc.cgi/SPECS/opensc/opensc-0.10.0-pinstdin.patch?view=markup patch

Re: [opensc-devel] patch for pkcs15-crypt

2006-09-28 Thread Peter Stuge
On Thu, Sep 28, 2006 at 09:47:11AM +0200, Andreas Jellinghaus wrote: > >>maybe it is a nice addition we want to integrate? > > > >Dunno.. We don't want people to think it's ok (secure) to enter > >pins that way.. > > the user is always right. we can add lots of warnings and document > the problems

Re: [opensc-devel] patch for pkcs15-crypt

2006-09-28 Thread Andreas Jellinghaus
Peter Stuge wrote: On Wed, Sep 27, 2006 at 11:34:36PM +0200, Andreas Jellinghaus wrote: mandriva has a patch for pkcs15-crypt so it can accept pins from stdin. could someone please review this patch? maybe it is a nice addition we want to integrate? Dunno.. We don't want people to think it's

Re: Re: [opensc-devel] patch for pkcs15-crypt

2006-09-28 Thread Martin Paljak
On 9/28/06, Nils Larsch <[EMAIL PROTECTED]> wrote: agree. Do we want to commit it now or wait for Martin's patch ? My code mimicked openssl. So if more extended pin retrieval mechanisms would be used, we should have to agree on the usability questions (type and syntax of command line arguments

Re: [opensc-devel] patch for pkcs15-crypt

2006-09-27 Thread Nils Larsch
Ludovic Rousseau wrote: Hello, On 28/09/06, Peter Stuge <[EMAIL PROTECTED]> wrote: On Wed, Sep 27, 2006 at 11:34:36PM +0200, Andreas Jellinghaus wrote: > mandriva has a patch for pkcs15-crypt so it can accept pins from > stdin. > > could someone please review this patch? > maybe it is a nice ad

Re: [opensc-devel] patch for pkcs15-crypt

2006-09-27 Thread Nils Larsch
Martin Paljak wrote: On 9/28/06, Ludovic Rousseau <[EMAIL PROTECTED]> wrote: Do you prefer "pkcs15-crypt --pin 1234" as it is now or "pkcs15-crypt --pin -" and enter the PIN in stdin as proposed by Mandriva? ~2 years ago I extended the command line utilities to use pin options much like opens

Re: Re: [opensc-devel] patch for pkcs15-crypt

2006-09-27 Thread Martin Paljak
On 9/28/06, Ludovic Rousseau <[EMAIL PROTECTED]> wrote: Do you prefer "pkcs15-crypt --pin 1234" as it is now or "pkcs15-crypt --pin -" and enter the PIN in stdin as proposed by Mandriva? ~2 years ago I extended the command line utilities to use pin options much like openssl - with options for

Re: [opensc-devel] patch for pkcs15-crypt

2006-09-27 Thread Ludovic Rousseau
Hello, On 28/09/06, Peter Stuge <[EMAIL PROTECTED]> wrote: On Wed, Sep 27, 2006 at 11:34:36PM +0200, Andreas Jellinghaus wrote: > mandriva has a patch for pkcs15-crypt so it can accept pins from > stdin. > > could someone please review this patch? > maybe it is a nice addition we want to integra

Re: [opensc-devel] patch for pkcs15-crypt

2006-09-27 Thread Peter Stuge
On Wed, Sep 27, 2006 at 11:34:36PM +0200, Andreas Jellinghaus wrote: > mandriva has a patch for pkcs15-crypt so it can accept pins from > stdin. > > could someone please review this patch? > maybe it is a nice addition we want to integrate? Dunno.. We don't want people to think it's ok (secure) t