Re: [opensource-dev] Review Request: STORM-638 "Object Return" doesn't return distant objects

> On Aug. 26, 2011, 11:51 a.m., Richard Nelson wrote: > > indra/newview/llviewermenu.cpp, line 4267 > > > > > > This is dangerous! Never hold on to raw pointers to llviewerobject, as > > they can be deleted from und

Re: [opensource-dev] [JIRA] Proposal - Default Search settings on jira.secondlife.com

Opinions inline... On 8/26/2011 12:34 PM, opensourceobscure wrote: > PROPOSAL: > > 1) exclude "Comments" from fields where keywords are searched for Agree > 2) exclude "Description" too (this may be excessive but usually works for me) Disagree on the grounds that excluding this one would negat

Re: [opensource-dev] Review Request: STORM-638 "Object Return" doesn't return distant objects

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/451/#review998 --- do not ship until fixing the pointer problem - Richard On Aug.

Re: [opensource-dev] Review Request: STORM-638 "Object Return" doesn't return distant objects

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/451/#review997 --- indra/newview/llviewermenu.cpp

Re: [opensource-dev] [JIRA] Proposal - Default Search settings on jira.secondlife.com

On Fri, Aug 26, 2011 at 1:34 PM, opensourceobscure wrote: > Currently, if you search multiple keywords on jira.secondlife.com > you get result that include at least one of the keywords > in Summary OR Description OR Comments fields. > actually i would like to see ALL KEYWORDS set as default on all

[opensource-dev] [JIRA] Proposal - Default Search settings on jira.secondlife.com

Currently, if you search multiple keywords on jira.secondlife.com you get result that include at least one of the keywords in Summary OR Description OR Comments fields. Unsurprisingly you often get thousands of results for every search, which is pointless. This requires users to tweak the search p

Re: [opensource-dev] Review Request: STORM-1567 Mute button for llDialog popup

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/449/ --- (Updated Aug. 26, 2011, 9:37 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: STORM-1567 Mute button for llDialog popup

> On Aug. 26, 2011, 6:05 a.m., Vadim ProductEngine wrote: > > indra/newview/llviewermessage.cpp, lines 6556-6559 > > > > > > It's a hack to update the Block List panel from here. > > The panel should be an observe

Re: [opensource-dev] Review Request: STORM-1567 Mute button for llDialog popup

> On Aug. 26, 2011, 6:05 a.m., Vadim ProductEngine wrote: > > indra/newview/lltoastnotifypanel.cpp, line 339 > > > > > > The surrounding code looks quite messy (not your fault, I know), so > > please make more comment

Re: [opensource-dev] Review Request: STORM-638 "Object Return" doesn't return distant objects

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/451/ --- (Updated Aug. 26, 2011, 8:38 a.m.) Review request for Viewer and Seth Produ

[opensource-dev] Review Request: STORM-638 "Object Return" doesn't return distant objects

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/451/ --- Review request for Viewer. Summary --- Reason: Showing the confirmatio

Re: [opensource-dev] Review Request: STORM-1567 Mute button for llDialog popup

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/449/#review993 --- indra/newview/lltoastnotifypanel.cpp