RE: [openssl.org #2028] [PATCH] DTLS cookie management bugs

2009-09-07 Thread Dave Thompson
> From: owner-openssl-...@openssl.org On Behalf Of Robin Seggelmann via RT > Sent: Friday, 04 September, 2009 07:29 > Cc: openssl-dev@openssl.org > On Sep 4, 2009, at 1:21 PM, Stephen Henson via RT wrote: > > A fair number of the casts seem to be unnecessary for example in > > RAND_bytes(), OPEN

Re: [openssl.org #2028] [PATCH] DTLS cookie management bugs

2009-09-04 Thread Dr. Stephen Henson
On Fri, Sep 04, 2009, Michael Txen wrote: > On Sep 4, 2009, at 5:16 PM, Stephen Henson via RT wrote: > >>> [seggelm...@fh-muenster.de - Fri Sep 04 13:28:50 2009]: >>> >>> >>> On Sep 4, 2009, at 1:21 PM, Stephen Henson via RT wrote: >>> > [seggelm...@fh-muenster.de - Fri Sep 04 09:39:52 2009]:

Re: [openssl.org #2028] [PATCH] DTLS cookie management bugs

2009-09-04 Thread Michael Tüxen
On Sep 4, 2009, at 5:16 PM, Stephen Henson via RT wrote: [seggelm...@fh-muenster.de - Fri Sep 04 13:28:50 2009]: On Sep 4, 2009, at 1:21 PM, Stephen Henson via RT wrote: [seggelm...@fh-muenster.de - Fri Sep 04 09:39:52 2009]: Still wrong castsI hope that's it now A fair number o

[openssl.org #2028] [PATCH] DTLS cookie management bugs

2009-09-04 Thread Stephen Henson via RT
> [seggelm...@fh-muenster.de - Fri Sep 04 13:28:50 2009]: > > > On Sep 4, 2009, at 1:21 PM, Stephen Henson via RT wrote: > > >> [seggelm...@fh-muenster.de - Fri Sep 04 09:39:52 2009]: > >> > >> > >> Still wrong castsI hope that's it now > >> > > > > A fair number of the casts seem to be

Re: [openssl.org #2028] [PATCH] DTLS cookie management bugs

2009-09-04 Thread Michael Tüxen
On Sep 4, 2009, at 3:38 PM, Tomas Mraz wrote: On Fri, 2009-09-04 at 14:26 +0200, Michael Tüxen wrote: On Sep 4, 2009, at 1:21 PM, Stephen Henson via RT wrote: [seggelm...@fh-muenster.de - Fri Sep 04 09:39:52 2009]: Still wrong castsI hope that's it now A fair number of the casts

Re: [openssl.org #2028] [PATCH] DTLS cookie management bugs

2009-09-04 Thread Tomas Mraz
On Fri, 2009-09-04 at 14:26 +0200, Michael Tüxen wrote: > On Sep 4, 2009, at 1:21 PM, Stephen Henson via RT wrote: > > >> [seggelm...@fh-muenster.de - Fri Sep 04 09:39:52 2009]: > >> > >> > >> Still wrong castsI hope that's it now > >> > > > > A fair number of the casts seem to be unnecess

Re: [openssl.org #2028] [PATCH] DTLS cookie management bugs

2009-09-04 Thread Michael Tüxen
On Sep 4, 2009, at 1:21 PM, Stephen Henson via RT wrote: [seggelm...@fh-muenster.de - Fri Sep 04 09:39:52 2009]: Still wrong castsI hope that's it now A fair number of the casts seem to be unnecessary for example in RAND_bytes(), OPENSSL_malloc() and HMAC(). Do you get warnings on y

Re: [openssl.org #2028] [PATCH] DTLS cookie management bugs

2009-09-04 Thread Robin Seggelmann via RT
On Sep 4, 2009, at 1:21 PM, Stephen Henson via RT wrote: >> [seggelm...@fh-muenster.de - Fri Sep 04 09:39:52 2009]: >> >> >> Still wrong castsI hope that's it now >> > > A fair number of the casts seem to be unnecessary for example in > RAND_bytes(), OPENSSL_malloc() and HMAC(). Do you ge

[openssl.org #2028] [PATCH] DTLS cookie management bugs

2009-09-04 Thread Stephen Henson via RT
> [seggelm...@fh-muenster.de - Fri Sep 04 09:39:52 2009]: > > > Still wrong castsI hope that's it now > A fair number of the casts seem to be unnecessary for example in RAND_bytes(), OPENSSL_malloc() and HMAC(). Do you get warnings on your system without them? Steve. -- Dr Stephen N.

Re: [openssl.org #2028] [PATCH] DTLS cookie management bugs

2009-09-04 Thread Robin Seggelmann via RT
On Sep 3, 2009, at 2:09 PM, Robin Seggelmann via RT wrote: > > On Sep 3, 2009, at 1:35 PM, Robin Seggelmann via RT wrote: > >> >> On Sep 3, 2009, at 10:50 AM, Robin Seggelmann via RT wrote: >> >>> >>> On Sep 2, 2009, at 3:02 PM, Stephen Henson via RT wrote: >>> There appear to be several pro

Re: [openssl.org #2028] [PATCH] DTLS cookie management bugs

2009-09-03 Thread Robin Seggelmann via RT
On Sep 3, 2009, at 1:35 PM, Robin Seggelmann via RT wrote: > > On Sep 3, 2009, at 10:50 AM, Robin Seggelmann via RT wrote: > >> >> On Sep 2, 2009, at 3:02 PM, Stephen Henson via RT wrote: >> >>> There appear to be several problems with this patch, see inline: >>> [seggelm...@fh-muenster.de -

Re: [openssl.org #2028] [PATCH] DTLS cookie management bugs

2009-09-03 Thread Robin Seggelmann via RT
On Sep 3, 2009, at 10:50 AM, Robin Seggelmann via RT wrote: > > On Sep 2, 2009, at 3:02 PM, Stephen Henson via RT wrote: > >> There appear to be several problems with this patch, see inline: >> >>> [seggelm...@fh-muenster.de - Mon Aug 31 17:04:19 2009]: >>> >>> This patch fixes several issues wit

Re: [openssl.org #2028] [PATCH] DTLS cookie management bugs

2009-09-03 Thread Robin Seggelmann via RT
On Sep 2, 2009, at 3:02 PM, Stephen Henson via RT wrote: > There appear to be several problems with this patch, see inline: > >> [seggelm...@fh-muenster.de - Mon Aug 31 17:04:19 2009]: >> >> This patch fixes several issues with DTLS cookies. >> > [snip] >> > > cookie_secret is defined: > >> +unsi

[openssl.org #2028] [PATCH] DTLS cookie management bugs

2009-09-02 Thread Stephen Henson via RT
There appear to be several problems with this patch, see inline: > [seggelm...@fh-muenster.de - Mon Aug 31 17:04:19 2009]: > > This patch fixes several issues with DTLS cookies. > [snip] > cookie_secret is defined: > +unsigned char cookie_secret[COOKIE_SECRET_LENGTH]; > +int cookie_initialize

[openssl.org #2028] [PATCH] DTLS cookie management bugs

2009-08-31 Thread Robin Seggelmann via RT
This patch fixes several issues with DTLS cookies. At first the maximum cookie length was defined as 32 bytes, while the specification states 256 bytes. Then there was code in the wrong order which prevented the use of cookies larger than 0 bytes in ssl3_get_client_hello(), it was tried to