no unlock in bio/b_sock.c

1999-06-07 Thread Goetz Babin-Ebell
Hallo, I think in b_sock.c I've stumbled into some error cases in which some locking isn't undone: diff b_sock.c b_sock.fixed.c 250c250,251 if (ret == NULL) return(NULL); --- if (ret == NULL) goto err; 352,353c353,357 if (ret == NULL) return(NULL);

Re: no unlock in bio/b_sock.c

1999-06-07 Thread Goetz Babin-Ebell
At 17:52 07.06.99 +0200, you wrote: Hallo, I think in b_sock.c I've stumbled into some error cases in which some locking isn't undone: sorry, wrong diff... *** OpenSSL/crypto/bio/b_sock.c Mon Apr 26 19:00:12 1999 --- OpenSSL/crypto/bio/b_sock.fixed.c Mon Jun 7 17:46:45 1999 ***

Re: no unlock in bio/b_sock.c

1999-06-07 Thread Bodo Moeller
On Mon, Jun 07, 1999 at 05:52:24PM +0200, Goetz Babin-Ebell wrote: I think in b_sock.c I've stumbled into some error cases in which some locking isn't undone: It's wrong anyway, I haven't come around to change it ... That caching gethostbyname function is only suitable for single-threaded use

Re: no unlock in bio/b_sock.c

1999-06-07 Thread Bodo Moeller
Goetz Babin-Ebell [EMAIL PROTECTED]: I think in b_sock.c I've stumbled into some error cases in which some locking isn't undone: - if (ret == NULL) return(NULL); + if (ret == NULL) + goto err; - if (ret == NULL) return(NULL); - if (j