Re: [openstack-dev] [Horizon] import only module message and #noqa

2014-01-03 Thread Russell Bryant
On 01/03/2014 10:10 AM, Radomir Dopieralski wrote: I think that we can actually do a little bit better and remove many of the #noqa tags without forfeiting automatic checking. I submitted a patch: https://review.openstack.org/#/c/64832/ This basically adds a h302_exceptions option to

Re: [openstack-dev] [Horizon] import only module message and #noqa

2014-01-03 Thread Radomir Dopieralski
On 03/01/14 16:18, Russell Bryant wrote: On 01/03/2014 10:10 AM, Radomir Dopieralski wrote: I think that we can actually do a little bit better and remove many of the #noqa tags without forfeiting automatic checking. I submitted a patch: https://review.openstack.org/#/c/64832/ This basically

Re: [openstack-dev] [Horizon] import only module message and #noqa

2014-01-03 Thread Gabriel pettier
On Fri, Jan 03, 2014 at 10:18:58AM -0500, Russell Bryant wrote: On 01/03/2014 10:10 AM, Radomir Dopieralski wrote: I think that we can actually do a little bit better and remove many of the #noqa tags without forfeiting automatic checking. I submitted a patch:

Re: [openstack-dev] [Horizon] import only module message and #noqa

2014-01-03 Thread Russell Bryant
On 01/03/2014 10:35 AM, Radomir Dopieralski wrote: On 03/01/14 16:18, Russell Bryant wrote: On 01/03/2014 10:10 AM, Radomir Dopieralski wrote: I think that we can actually do a little bit better and remove many of the #noqa tags without forfeiting automatic checking. I submitted a patch:

Re: [openstack-dev] [Horizon] import only module message and #noqa

2013-12-30 Thread Gabriel pettier
So Tatiana pointed http://lists.openstack.org/pipermail/openstack-dev/2013-June/thread.html#9993 to me, and from there i went on to read http://lists.openstack.org/pipermail/openstack-dev/2013-August/thread.html#13074 and i can see valid points for H302, even if it annoy me sometime, if it's