Re: [openstack-dev] [Nova] Questions about instance actions' update and finish

2016-07-10 Thread Zhenyu Zheng
OK, then I will work on it in O On Thu, Jul 7, 2016 at 12:15 AM, Matt Riedemann wrote: > On 7/4/2016 1:12 AM, Zhenyu Zheng wrote: > >> I'm willing to work on this, should this be a Blueprint for O? >> >> > The spec will need to be re-proposed for Ocata and any adjustments for the > sorting/pagin

Re: [openstack-dev] [Nova] Questions about instance actions' update and finish

2016-07-06 Thread Matt Riedemann
On 7/4/2016 1:12 AM, Zhenyu Zheng wrote: I'm willing to work on this, should this be a Blueprint for O? The spec will need to be re-proposed for Ocata and any adjustments for the sorting/paging/marker discussions from this thread and/or the review should be laid out in the spec. -- Thanks

Re: [openstack-dev] [Nova] Questions about instance actions' update and finish

2016-07-03 Thread Zhenyu Zheng
I'm willing to work on this, should this be a Blueprint for O? On Sun, Jul 3, 2016 at 9:05 PM, Matt Riedemann wrote: > On 7/3/2016 6:21 AM, Alex Xu wrote: > >> >> >> 2016-07-02 2:32 GMT+08:00 Sean Dague > >: >> >> >> On 06/30/2016 08:31 AM, Andrew Laski wrote: >> >

Re: [openstack-dev] [Nova] Questions about instance actions' update and finish

2016-07-03 Thread Matt Riedemann
On 7/3/2016 6:21 AM, Alex Xu wrote: 2016-07-02 2:32 GMT+08:00 Sean Dague mailto:s...@dague.net>>: On 06/30/2016 08:31 AM, Andrew Laski wrote: > > > On Wed, Jun 29, 2016, at 11:11 PM, Matt Riedemann wrote: >> On 6/29/2016 10:10 PM, Matt Riedemann wrote: >>> On 6/29/2016

Re: [openstack-dev] [Nova] Questions about instance actions' update and finish

2016-07-03 Thread Alex Xu
2016-07-02 2:32 GMT+08:00 Sean Dague : > On 06/30/2016 08:31 AM, Andrew Laski wrote: > > > > > > On Wed, Jun 29, 2016, at 11:11 PM, Matt Riedemann wrote: > >> On 6/29/2016 10:10 PM, Matt Riedemann wrote: > >>> On 6/29/2016 6:40 AM, Andrew Laski wrote: > > > > On Tue, Jun 28, 20

Re: [openstack-dev] [Nova] Questions about instance actions' update and finish

2016-07-01 Thread Matt Riedemann
On 7/1/2016 1:32 PM, Sean Dague wrote: On 06/30/2016 08:31 AM, Andrew Laski wrote: On Wed, Jun 29, 2016, at 11:11 PM, Matt Riedemann wrote: On 6/29/2016 10:10 PM, Matt Riedemann wrote: On 6/29/2016 6:40 AM, Andrew Laski wrote: On Tue, Jun 28, 2016, at 09:27 PM, Zhenyu Zheng wrote: How a

Re: [openstack-dev] [Nova] Questions about instance actions' update and finish

2016-07-01 Thread Sean Dague
On 06/30/2016 08:31 AM, Andrew Laski wrote: > > > On Wed, Jun 29, 2016, at 11:11 PM, Matt Riedemann wrote: >> On 6/29/2016 10:10 PM, Matt Riedemann wrote: >>> On 6/29/2016 6:40 AM, Andrew Laski wrote: On Tue, Jun 28, 2016, at 09:27 PM, Zhenyu Zheng wrote: > How about I syn

Re: [openstack-dev] [Nova] Questions about instance actions' update and finish

2016-07-01 Thread Sean Dague
On 07/01/2016 10:37 AM, Matt Riedemann wrote: > On 6/30/2016 11:10 AM, Chris Friesen wrote: >> >> For what it's worth, this is how the timestamps work for POSIX >> filesystems. When you create a file it sets the access/modify/change >> timestamps to the file creation time. >> >> Chris >> >> ___

Re: [openstack-dev] [Nova] Questions about instance actions' update and finish

2016-07-01 Thread Matt Riedemann
On 6/30/2016 11:10 AM, Chris Friesen wrote: For what it's worth, this is how the timestamps work for POSIX filesystems. When you create a file it sets the access/modify/change timestamps to the file creation time. Chris __

Re: [openstack-dev] [Nova] Questions about instance actions' update and finish

2016-06-30 Thread Chris Friesen
On 06/29/2016 09:13 PM, Edward Leafe wrote: On Jun 29, 2016, at 10:05 PM, Matt Riedemann wrote: 2. The updated_at field is also empty, should we sync the updated_at time to the created_at time when we create the action and also update it whenever the action status changed, e.g finished. Whe

Re: [openstack-dev] [Nova] Questions about instance actions' update and finish

2016-06-30 Thread Andrew Laski
On Wed, Jun 29, 2016, at 11:11 PM, Matt Riedemann wrote: > On 6/29/2016 10:10 PM, Matt Riedemann wrote: > > On 6/29/2016 6:40 AM, Andrew Laski wrote: > >> > >> > >> > >> On Tue, Jun 28, 2016, at 09:27 PM, Zhenyu Zheng wrote: > >>> How about I sync updated_at and created_at in my patch, and leave

Re: [openstack-dev] [Nova] Questions about instance actions' update and finish

2016-06-29 Thread Edward Leafe
On Jun 29, 2016, at 10:05 PM, Matt Riedemann wrote: > >>> 2. The updated_at field is also empty, should we sync the updated_at >>> time to the created_at time when we create the action and also update >>> it whenever the action status changed, e.g finished. >> >> When a finish_time is recorded t

Re: [openstack-dev] [Nova] Questions about instance actions' update and finish

2016-06-29 Thread Matt Riedemann
On 6/29/2016 10:10 PM, Matt Riedemann wrote: On 6/29/2016 6:40 AM, Andrew Laski wrote: On Tue, Jun 28, 2016, at 09:27 PM, Zhenyu Zheng wrote: How about I sync updated_at and created_at in my patch, and leave the finish to the other BP, by this way, I can use updated_at for the timestamp filt

Re: [openstack-dev] [Nova] Questions about instance actions' update and finish

2016-06-29 Thread Matt Riedemann
On 6/29/2016 6:40 AM, Andrew Laski wrote: On Tue, Jun 28, 2016, at 09:27 PM, Zhenyu Zheng wrote: How about I sync updated_at and created_at in my patch, and leave the finish to the other BP, by this way, I can use updated_at for the timestamp filter I added and it don't need to change again o

Re: [openstack-dev] [Nova] Questions about instance actions' update and finish

2016-06-29 Thread Matt Riedemann
On 6/28/2016 7:28 AM, Andrew Laski wrote: On Tue, Jun 28, 2016, at 03:26 AM, Zhenyu Zheng wrote: Hi all, I'm working on add pagination and timestamp filter for os-instance-actions API: https://review.openstack.org/#/c/326326/ As Alex_xu pointed out that it will be better to filter by `update

Re: [openstack-dev] [Nova] Questions about instance actions' update and finish

2016-06-29 Thread Andrew Laski
On Tue, Jun 28, 2016, at 09:27 PM, Zhenyu Zheng wrote: > How about I sync updated_at and created_at in my patch, and leave the > finish to the other BP, by this way, I can use updated_at for the > timestamp filter I added and it don't need to change again once the > finish BP is complete. S

Re: [openstack-dev] [Nova] Questions about instance actions' update and finish

2016-06-28 Thread Zhenyu Zheng
How about I sync updated_at and created_at in my patch, and leave the finish to the other BP, by this way, I can use updated_at for the timestamp filter I added and it don't need to change again once the finish BP is complete. On Tue, Jun 28, 2016 at 8:28 PM, Andrew Laski wrote: > > > > On Tue,

Re: [openstack-dev] [Nova] Questions about instance actions' update and finish

2016-06-28 Thread Andrew Laski
On Tue, Jun 28, 2016, at 03:26 AM, Zhenyu Zheng wrote: > Hi all, > > I'm working on add pagination and timestamp filter for os-instance- > actions API: > https://review.openstack.org/#/c/326326/ > As Alex_xu pointed out that it will be better to filter by > `updated_at` for timestamp filter w

[openstack-dev] [Nova] Questions about instance actions' update and finish

2016-06-28 Thread Zhenyu Zheng
Hi all, I'm working on add pagination and timestamp filter for os-instance-actions API: https://review.openstack.org/#/c/326326/ As Alex_xu pointed out that it will be better to filter by `updated_at` for timestamp filter which is reasonable, but when I tried to modify the patch I found out that: