Re: [openstack-dev] [all][gerrit] Showing all inline comments from all patch sets

2014-12-17 Thread James Polley
But equally I think finding out why the New Screen still doesn't do what you want is valuable - it's likely other people want something similar to what you want, so this kind of feedback can be used to decide on future features On Wed, Dec 17, 2014 at 8:38 AM, Radoslav Gerganov

[openstack-dev] [all][gerrit] Showing all inline comments from all patch sets

2014-12-16 Thread Radoslav Gerganov
I never liked how Gerrit is displaying inline comments and I find it hard to follow discussions on changes with many patch sets and inline comments. So I tried to hack together an html view which display all comments grouped by patch set, file and commented line. You can see the result at

Re: [openstack-dev] [all][gerrit] Showing all inline comments from all patch sets

2014-12-16 Thread Jeremy Stanley
On 2014-12-16 12:27:15 +0200 (+0200), Radoslav Gerganov wrote: [...] the backend running on GoogleAppEngine is just proxying the requests to review.openstack.org. So in theory if we serve the html page from our Gerrit it will work. [...] I'm having trouble locating the source code for Google

Re: [openstack-dev] [all][gerrit] Showing all inline comments from all patch sets

2014-12-16 Thread Radoslav Gerganov
On 12/16/2014 03:59 PM, Jeremy Stanley wrote: I'm having trouble locating the source code for Google App Engine, and can instead only find source code for its SDK. How would we run a GAE instance? (Please remember that our Infra team doesn't host content backed by proprietary services, but do

Re: [openstack-dev] [all][gerrit] Showing all inline comments from all patch sets

2014-12-16 Thread Jeremy Stanley
On 2014-12-16 17:19:55 +0200 (+0200), Radoslav Gerganov wrote: We don't need GoogleAppEngine if we decide that this is useful. We simply need to put the html page which renders the view on https://review.openstack.org. It is all javascript which talks asynchronously to the Gerrit backend. I

Re: [openstack-dev] [all][gerrit] Showing all inline comments from all patch sets

2014-12-16 Thread Dolph Mathews
I've envisioned basically the same feature before, but I don't find the comments to be particularly useful without the complete context. What I really want from gerrit is a 3-way diff, wherein the first column is always the original state of the repo, the second column is a user-selectable

Re: [openstack-dev] [all][gerrit] Showing all inline comments from all patch sets

2014-12-16 Thread James Polley
I was looking at the new change screen on https://review.openstack.org today[1] and it seems to do something vaguely similar. Rather than saying James polley made 4 inline comments, the contents of the comments are shown, along with a link to the file so you can see the context. Have you seen

Re: [openstack-dev] [all][gerrit] Showing all inline comments from all patch sets

2014-12-16 Thread Radoslav Gerganov
I am aware of this New Screen but it is not useful to me. I'd like to see comments grouped by patchset, file and commented line rather than a flat view mixed with everything else. Anyway, I guess there is no one-size-fits-all solution for this and everyone has different preferences which is