Re: [openstack-dev] [nova] Do we need a microversion to return a 501 from GET os-virtual-interfaces?

2016-03-07 Thread Andrey Kurilin
Hi! I did not find any usage "virtual_interfaces" with try...except block, so we can easily change error code without new microversion. I'm +1 for proper code. On Mon, Mar 7, 2016 at 6:32 PM, Ken'ichi Ohmichi wrote: > 2016-03-06 15:41 GMT-08:00 Jay Pipes

Re: [openstack-dev] [nova] Do we need a microversion to return a 501 from GET os-virtual-interfaces?

2016-03-07 Thread Ken'ichi Ohmichi
2016-03-06 15:41 GMT-08:00 Jay Pipes : > On 03/06/2016 02:21 PM, Matt Riedemann wrote: >> >> Thanks, good point. I think 400 would be best here. And according to our >> handy-dandy docs [1] it should be OK to do this without a microversion. > > > Yup, 400 is correct and yes,

Re: [openstack-dev] [nova] Do we need a microversion to return a 501 from GET os-virtual-interfaces?

2016-03-06 Thread Jay Pipes
On 03/06/2016 02:21 PM, Matt Riedemann wrote: Thanks, good point. I think 400 would be best here. And according to our handy-dandy docs [1] it should be OK to do this without a microversion. Yup, 400 is correct and yes, you should not need a new microversion addition to the API. Best, -jay

Re: [openstack-dev] [nova] Do we need a microversion to return a 501 from GET os-virtual-interfaces?

2016-03-06 Thread Matt Riedemann
On 3/6/2016 12:47 PM, Chris Dent wrote: On Sat, 5 Mar 2016, Matt Riedemann wrote: A GET request from the os-virtual-interfaces API returns a 500 today if neutron is the networking backend. It would be more accurate to return a 501, but do we need a microversion for that? Keep this in

Re: [openstack-dev] [nova] Do we need a microversion to return a 501 from GET os-virtual-interfaces?

2016-03-06 Thread Chris Dent
On Sat, 5 Mar 2016, Matt Riedemann wrote: A GET request from the os-virtual-interfaces API returns a 500 today if neutron is the networking backend. It would be more accurate to return a 501, but do we need a microversion for that? Keep this in mind:

Re: [openstack-dev] [nova] Do we need a microversion to return a 501 from GET os-virtual-interfaces?

2016-03-06 Thread Matt Riedemann
On 3/5/2016 8:51 PM, Matt Riedemann wrote: A GET request from the os-virtual-interfaces API returns a 500 today if neutron is the networking backend. It would be more accurate to return a 501, but do we need a microversion for that? I intend on implementing the method for the neutronv2 API

[openstack-dev] [nova] Do we need a microversion to return a 501 from GET os-virtual-interfaces?

2016-03-05 Thread Matt Riedemann
A GET request from the os-virtual-interfaces API returns a 500 today if neutron is the networking backend. It would be more accurate to return a 501, but do we need a microversion for that? I intend on implementing the method for the neutronv2 API in nova [1] but it will require a