Re: [openstack-dev] [stable][heat] Heat stable-maint additions

2017-02-20 Thread Thierry Carrez
Steven Hardy wrote: > I agree - those nominated by Zane are all highly experienced reviewers and > as ex-PTLs are well aware of the constraints around stable backports and > stable release management. > > I do agree the requirements around reviews for stable branches are very > different, but I

Re: [openstack-dev] [stable][heat] Heat stable-maint additions

2017-02-20 Thread Steven Hardy
On Fri, Feb 17, 2017 at 10:07:38PM +0530, Rabi Mishra wrote: >On Fri, Feb 17, 2017 at 8:44 PM, Matt Riedemann >wrote: > > On 2/15/2017 12:40 PM, Zane Bitter wrote: > >Traditionally Heat has given current and former PTLs of the project +2 >rights

Re: [openstack-dev] [stable][heat] Heat stable-maint additions

2017-02-20 Thread Zane Bitter
On 18/02/17 03:24, Thierry Carrez wrote: Thomas Herve wrote: [...] At any rate, it's a matter of trust, a subject that comes from time to time, and it's fairly divisive. In this case though, I find it ironic that I can approve whatever garbage I want on master, it can make its way into a

Re: [openstack-dev] [stable][heat] Heat stable-maint additions

2017-02-18 Thread Thierry Carrez
Thomas Herve wrote: > [...] > At any rate, it's a matter of trust, a subject that comes from time to > time, and it's fairly divisive. In this case though, I find it ironic > that I can approve whatever garbage I want on master, it can make its > way into a release, but if I want a bugfix

Re: [openstack-dev] [stable][heat] Heat stable-maint additions

2017-02-17 Thread Thomas Herve
On Fri, Feb 17, 2017 at 5:48 PM, Ian Cordasco wrote: > -Original Message- > From: Thomas Herve [snip] >> Respecting the guidelines is totally fair, but review stats won't tell >> you much, at least in my case: I barely do any stable reviews

Re: [openstack-dev] [stable][heat] Heat stable-maint additions

2017-02-17 Thread Ian Cordasco
t;openstack-dev@lists.openstack.org> Subject:  Re: [openstack-dev] [stable][heat] Heat stable-maint additions > On Fri, Feb 17, 2017 at 4:14 PM, Matt Riedemann wrote: > > On 2/15/2017 12:40 PM, Zane Bitter wrote: > >> > >> Traditionally Heat has given current and former PTLs of

Re: [openstack-dev] [stable][heat] Heat stable-maint additions

2017-02-17 Thread Rabi Mishra
On Fri, Feb 17, 2017 at 8:44 PM, Matt Riedemann wrote: > On 2/15/2017 12:40 PM, Zane Bitter wrote: > >> Traditionally Heat has given current and former PTLs of the project +2 >> rights on stable branches for as long as they remain core reviewers. >> Usually I've done that by

Re: [openstack-dev] [stable][heat] Heat stable-maint additions

2017-02-17 Thread Thomas Herve
On Fri, Feb 17, 2017 at 4:14 PM, Matt Riedemann wrote: > On 2/15/2017 12:40 PM, Zane Bitter wrote: >> >> Traditionally Heat has given current and former PTLs of the project +2 >> rights on stable branches for as long as they remain core reviewers. >> Usually I've done that by

Re: [openstack-dev] [stable][heat] Heat stable-maint additions

2017-02-17 Thread Matt Riedemann
On 2/15/2017 12:40 PM, Zane Bitter wrote: Traditionally Heat has given current and former PTLs of the project +2 rights on stable branches for as long as they remain core reviewers. Usually I've done that by adding them to the heat-release group. At some point the system changed so that the

[openstack-dev] [stable][heat] Heat stable-maint additions

2017-02-15 Thread Zane Bitter
Traditionally Heat has given current and former PTLs of the project +2 rights on stable branches for as long as they remain core reviewers. Usually I've done that by adding them to the heat-release group. At some point the system changed so that the review rights for these branches are no