Re: [Openvpn-devel] ASLR/DEP -enabled 2.4.0 Windows installer available

2017-01-20 Thread Selva Nair
Hi, On Fri, Jan 20, 2017 at 11:42 AM, Selva Nair wrote: > On Fri, Jan 20, 2017 at 9:43 AM, Samuli Seppänen >> wrote: >> Thanks for testing! I think we just have to merge the ASLR/DEP change in >> openvpn-build and see what happens. >> > > For ASLR we may have to add some option to get reloc info

Re: [Openvpn-devel] [PATCH applied] Add a check for -Wl, --wrap support in linker

2017-01-20 Thread Selva Nair
Hi, On Fri, Jan 20, 2017 at 4:40 PM, Gert Doering wrote: > On Fri, Jan 20, 2017 at 03:38:46PM -0500, Selva Nair wrote: > > I am curious to know whether the opensolaris buildbot (there is one isn't > > it?) run and pass all tests? > > There is one, but it uses gcc and GNU ld, so --wrap never was

Re: [Openvpn-devel] [PATCH] Use SHA256 for the internal digest, instead of MD5

2017-01-20 Thread David Sommerseth
On 18/12/16 17:40, Steffan Karger wrote: > Our internal options digest uses MD5 hashes to store the state, instead of > storing the full options string. There's nothing wrong with that, but it > would still be better to use SHA256 because: > * That makes it easier to make OpenVPN "FIPS-compliant"

Re: [Openvpn-devel] [PATCH applied] Add a check for -Wl, --wrap support in linker

2017-01-20 Thread Gert Doering
Hi, On Fri, Jan 20, 2017 at 03:38:46PM -0500, Selva Nair wrote: > I am curious to know whether the opensolaris buildbot (there is one isn't > it?) run and pass all tests? There is one, but it uses gcc and GNU ld, so --wrap never was a problem there... gert@osol10:/home/gert$ ld --version GNU ld

Re: [Openvpn-devel] [PATCH applied] Add a check for -Wl, --wrap support in linker

2017-01-20 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 20/01/17 21:38, Selva Nair wrote: > > On Fri, Jan 20, 2017 at 1:16 PM, David Sommerseth > mailto:dav...@openvpn.net>> wrote: > > Your patch has been applied to the following branches > > commit f91ab283a407e25c4b32aecb390911b212ce2694 (master) c

[Openvpn-devel] [PATCH] git: Merge .gitignore files into a single file

2017-01-20 Thread David Sommerseth
We already track a lot of files over the whole directory structure in the main .gitignore file. But a few additional ones had been added into some of the subdirectories. This unifies all these files into a master file for the whole project, making it easier to know where to look at and edit if ch

Re: [Openvpn-devel] [PATCH 2/2] do not race on RuntimeDirectory

2017-01-20 Thread David Sommerseth
On 27/12/16 23:15, Christian Hesse wrote: > From: Christian Hesse > > Different unit instances create and destroy the same RuntimeDirectory. > This leads to running instances where the status file (and possibly > more runtime data) is no longer accessible. > > So do not handle this in unit files

Re: [Openvpn-devel] [PATCH applied] Add a check for -Wl, --wrap support in linker

2017-01-20 Thread Selva Nair
On Fri, Jan 20, 2017 at 1:16 PM, David Sommerseth wrote: > Your patch has been applied to the following branches > > commit f91ab283a407e25c4b32aecb390911b212ce2694 (master) > commit 2f5f1d8fffcba26d21d47cbcb1e99e0e1c313568 (release/2.4) > I am curious to know whether the opensolaris buildbot

Re: [Openvpn-devel] [PATCH 1/2] use automake tools to install systemd files

2017-01-20 Thread David Sommerseth
On 27/12/16 23:15, Christian Hesse wrote: > From: Christian Hesse > > If systemd is enabled we install unit files to $libdir/systemd/system > (or the path specified by SYSTEMD_UNIT_DIR). > The unit files are generated on the fly with matching $sbindir. > > Signed-off-by: Christian Hesse > --- >

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-01-20 Thread David Sommerseth
On 13/01/17 10:05, Samuli Seppänen wrote: > Il 13/01/2017 10:50, Ilya Shipitsin ha scritto: >> --- >> .github/PULL_REQUEST_TEMPLATE.md | 8 >> 1 file changed, 8 insertions(+) >> create mode 100644 .github/PULL_REQUEST_TEMPLATE.md >> >> diff --git a/.github/PULL_REQUEST_TEMPLATE.md >> b/

Re: [Openvpn-devel] [PATCH applied] Add a check for -Wl, --wrap support in linker

2017-01-20 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 ACK to this approach, with one commit-time modification (removed the AC_DEFINE line, as already discussed in the patch mail thread) Your patch has been applied to the following branches commit f91ab283a407e25c4b32aecb390911b212ce2694 (master) commit

Re: [Openvpn-devel] ASLR/DEP -enabled 2.4.0 Windows installer available

2017-01-20 Thread Selva Nair
On Fri, Jan 20, 2017 at 9:43 AM, Samuli Seppänen wrote: > > Task manager shows DEP enabled while Windows is configured for > > DEP on Windows processes only but the machine has Hardware enabled DEP > > and shows DEP for 2.4.0-i601 as well . so not a very good test. > > > > I don't have a 32bit wi

Re: [Openvpn-devel] ASLR/DEP -enabled 2.4.0 Windows installer available

2017-01-20 Thread Samuli Seppänen
Il 19/01/2017 22:46, debbie10t ha scritto: > > On 18/01/17 07:48, Samuli Seppänen wrote: >> Hi, >> >> There's now a 2.4.0 Windows installer where all executables and >> libraries have ASLR/DEP enabled: >> >> >>