Re: [Openvpn-devel] [PATCH] Highlight deprecated features

Hi, On 15-08-17 23:54, David Sommerseth wrote: > We have quite a list of deprecated options currently. Ensure this > is highlighted both in documentation and code. > > This patch builds on the wiki page [1] enlisting all deprecated features > and their status. There are also some options not

[Openvpn-devel] [PATCH] tls-crypt: don't leak memory for incorrect tls-crypt messages

If tls_crypt_unwrap() failed, we would jump to cleanup and forget to free the buffer. Instead, allocate the buffer through gc, which is free'd in the cleanup section. Signed-off-by: Steffan Karger --- src/openvpn/ssl.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Openvpn-devel] [PATCH applied] tls-crypt: introduce tls_crypt_kt()

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Your patch has been applied to the following branches commit 489c7bf93ec618e03dbd9618efbb6e251a65e76c (master) commit d47228e71de6cbbf860746a50a3ecf8025e35653 (release/2.4) Author: Steffan Karger Date: Sat Aug 12 11:53:52 2017 +0200

Re: [Openvpn-devel] [PATCH applied] Move run_up_down() to init.c

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Your patch has been applied to the following branches commit 4a9d1d70d5b0ff04dbf26ba7e679733a54c694b6 (master) commit 81b78cf5de03f843cdf917bb2ee350ba85f49cbd (release/2.4) Author: Steffan Karger Date: Tue Aug 15 17:39:46 2017 +0200 Move

Re: [Openvpn-devel] [PATCH applied] remove the --disable-multi config switch

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Your patch has been applied to the following branches commit 299a8f8f1aa10b5b0d006ae77c26de33d55d4a25 (master) commit 12df7c26a5210052029acbf47bdf9aee673b34ee (release/2.4) Author: Antonio Quartulli Date: Wed Aug 16 21:24:54 2017 +0800

Re: [Openvpn-devel] [PATCH applied] ntlm: avoid breaking anti-aliasing rules

-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Your patch has been applied to the following branches commit e84b6994b4d2b53bcebd5415a58de4cecd411a7b (master) commit 30e0778a57a8db3d57d144471a869647037a115b (release/2.4) Author: Antonio Quartulli Date: Wed Aug 16 20:18:06 2017 +0800

Re: [Openvpn-devel] [PATCH v2] remove the --disable-multi config switch

Hi, On 16-08-17 15:24, Antonio Quartulli wrote: > This switch is broken and unmaintained. > However there wasn't any ticket about it so far, > which means that it is practically unused. > > Get rid of it and simplify P2MP logic. > > Signed-off-by: Antonio Quartulli > --- > >

[Openvpn-devel] [PATCH v2] remove the --disable-multi config switch

This switch is broken and unmaintained. However there wasn't any ticket about it so far, which means that it is practically unused. Get rid of it and simplify P2MP logic. Signed-off-by: Antonio Quartulli --- v2: remove ENABLE_CLIENT_SERVEr define from config-msvc.h

[Openvpn-devel] [PATCH] remove the --disable-multi config switch

This switch is broken and unmaintained. However there wasn't any ticket about it so far, which means that it is practically unused. Get rid of it and simplify the P2MP logic. Signed-off-by: Antonio Quartulli --- configure.ac | 8 src/openvpn/syshead.h | 2 +-

Re: [Openvpn-devel] [PATCH] fix compilation for --disable-multi

Hi, On 13/07/17 14:59, Gert Doering wrote: > Hi, > > On Thu, Jul 13, 2017 at 09:16:13AM +0300, Samuli Seppänen wrote: >> There were no bugs reports about --disable-multi in Trac. I say scrap >> that option altogether and make the code slightly cleaner and less >> entangled. > > I tend to agree

[Openvpn-devel] [PATCH v4] route: avoid definition of unused variables in certain configurations

From: Antonio Quartulli Although this patch adds more ifdefs, this is an easy fix towards a no-warning-build process. A proper cleanup should be carried out later on route.c. Signed-off-by: Antonio Quartulli --- v2: - add commit message - fix warning

Re: [Openvpn-devel] [PATCH v4] ntlm: avoid breaking anti-aliasing rules

Hi, On 16-08-17 14:18, Antonio Quartulli wrote: > From: Antonio Quartulli > > The problem is visible when compiling with -O2: > > ntlm.c: In function ‘ntlm_phase_3’: > ntlm.c:305:9: warning: dereferencing type-punned pointer will break > strict-aliasing rules

Re: [Openvpn-devel] [PATCH v3] route: avoid definition of unused variables in certain configurations

Hi and thanks for reviewing this patch, On 16/08/17 20:41, Steffan Karger wrote: > Hi, > > On 16-08-17 13:46, Antonio Quartulli wrote: >> From: Antonio Quartulli >> >> Although this patch adds more ifdefs, this is an easy >> fix towards a no-warning-build process. >> >> A

Re: [Openvpn-devel] [PATCH v3] route: avoid definition of unused variables in certain configurations

Hi, On 16-08-17 13:46, Antonio Quartulli wrote: > From: Antonio Quartulli > > Although this patch adds more ifdefs, this is an easy > fix towards a no-warning-build process. > > A proper cleanup should be carried out later on route.c. Even though the #ifdefs are ugly,

[Openvpn-devel] [PATCH v3] route: avoid definition of unused variables in certain configurations

From: Antonio Quartulli Although this patch adds more ifdefs, this is an easy fix towards a no-warning-build process. A proper cleanup should be carried out later on route.c. Signed-off-by: Antonio Quartulli --- v2: - add commit message - fix warning

[Openvpn-devel] [PATCH v2] route: avoid definition of unused variables in certain configurations

From: Antonio Quartulli Although this patch adds more ifdefs, this is an easy fix towards a no-warning-build process. A proper cleanup should be carried out later on route.c. Signed-off-by: Antonio Quartulli --- v2: - add commit message - fix warning