Re: [Openvpn-devel] [PATCH 09/13] Signed/unsigned warnings of MSVC resolved

Hi, I understand the intent here and its nice to get rid of compiler warnings, when it makes sense. But be careful while silencing by just a cast. On Sun, Nov 5, 2017 at 5:06 PM, Simon Rozman wrote: > > Hi, > > Let me explain all proposed modifications case-by-case below... > >

[Openvpn-devel] [PATCH v2] Use lowest metric interface when multiple interfaces match a route

From: Selva Nair Currently a route addition using IPAPI or service is skipped if the route gateway is reachable by multiple interfaces. This changes that to use the interface with lowest metric. Implemented by (i) Do not over-write the return value with

[Openvpn-devel] [PATCH v2] openvpnserv: Add support for multi-instances

While openvpn.exe can run multiple concurrent processes, openvpnserv.exe is usually only one single globally unique running process. This patch extends openvpnserv.exe to support multiple service instances in parallel allowing side-by-side OpenVPN installations. Alternate instances must be

Re: [Openvpn-devel] [PATCH 09/13] Signed/unsigned warnings of MSVC resolved

Hi, Let me explain all proposed modifications case-by-case below... > > diff --git a/src/openvpn/block_dns.c b/src/openvpn/block_dns.c index > > d43cbcf..f88ba2c 100644 > > --- a/src/openvpn/block_dns.c > > +++ b/src/openvpn/block_dns.c > > @@ -370,7 +370,7 @@ get_interface_metric(const

Re: [Openvpn-devel] [PATCH 09/13] Signed/unsigned warnings of MSVC resolved

On 05/11/17 20:20, Gert Doering wrote: >> -modext(LPTSTR dest, int size, LPCTSTR src, LPCTSTR newext) >> +modext(LPTSTR dest, size_t size, LPCTSTR src, LPCTSTR newext) >> { >> int i; > Not sure why this is needed? The code verifies that size is ">0", so > a signed variable is ok here. I

Re: [Openvpn-devel] [PATCH 09/13] Signed/unsigned warnings of MSVC resolved

Hi, > > index 7a2d0e3..5422d33 100644 > > --- a/src/openvpnserv/validate.c > > +++ b/src/openvpnserv/validate.c > > @@ -298,7 +298,7 @@ IsUserInGroup(PSID sid, const PTOKEN_GROUPS > token_groups, const WCHAR *group_nam > > break; > > } > > /* If a match is already

Re: [Openvpn-devel] [PATCH 09/13] Signed/unsigned warnings of MSVC resolved

Hi, On Wed, Oct 11, 2017 at 01:11:26AM +0200, si...@rozman.si wrote: > From: Simon Rozman > > --- > src/openvpn/block_dns.c | 2 +- > src/openvpnserv/automatic.c | 2 +- > src/openvpnserv/common.c | 2 +- > src/openvpnserv/interactive.c | 4 ++-- >

Re: [Openvpn-devel] Windows installer with updated pkcs11-helper (1.22) available for testing

Hi, And the rationale for the patch: On Mon, Jul 17, 2017 at 8:22 AM, Jan Just Keijser wrote: > On 17/07/17 14:14, Gert Doering wrote: > >> Hi, >> >> On Mon, Jul 17, 2017 at 02:10:11PM +0200, Jan Just Keijser wrote: >> >>> this problem is NOT present in OpenVPN 2.3.17; the

[Openvpn-devel] [PATCH] Use lowest metric interface when multiple interfaces match a route

From: Selva Nair Currently a route addition using IPAPI or service is skipped if the route gateway is reachable by multiple interfaces. This changes that to use the interface with lowest metric. Reported by Jan Just Keijser Signed-off-by: Selva Nair

Re: [Openvpn-devel] Windows installer with updated pkcs11-helper (1.22) available for testing

On Sun, Nov 5, 2017 at 12:11 PM, Gert Doering wrote: > Hi, > > On Mon, Jul 17, 2017 at 02:22:55PM +0200, Jan Just Keijser wrote: > > On 17/07/17 14:14, Gert Doering wrote: > > > Hi, > > > > > > On Mon, Jul 17, 2017 at 02:10:11PM +0200, Jan Just Keijser wrote: > > >> this

Re: [Openvpn-devel] Windows installer with updated pkcs11-helper (1.22) available for testing

Hi, On Mon, Jul 17, 2017 at 02:22:55PM +0200, Jan Just Keijser wrote: > On 17/07/17 14:14, Gert Doering wrote: > > Hi, > > > > On Mon, Jul 17, 2017 at 02:10:11PM +0200, Jan Just Keijser wrote: > >> this problem is NOT present in OpenVPN 2.3.17; the same warning appears > >> (route gateway is

[Openvpn-devel] [PATCH applied] Re: buffer_list_aggregate_separator(): add unit tests

ACK, test code is good :-) (it passes the tests now, and does not change anything else). Applying to 2.4 as well, since "test good is good", even if we might not apply the refactoring bits there. Your patch has been applied to the master and release/2.4 branch. commit

[Openvpn-devel] [PATCH] Use long long to format time_t-related environment variables

Signed-off-by: Jeremie Courreges-Anglas --- src/openvpn/misc.c| 4 ++-- src/openvpn/misc.h| 2 +- src/openvpn/multi.c | 7 ++- src/openvpn/options.c | 2 +- 4 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/openvpn/misc.c b/src/openvpn/misc.c index

Re: [Openvpn-devel] [PATCH applied] Re: Print time_t as long long and suseconds_t as long

On Sat, Nov 04 2017, Gert Doering wrote: > ACK, thanks. Reviewed by "staring at the code" (changes are only what it > says on the tin), compiling with clang and gcc (no format related warnings), > and running tests, of course :-) Cool, thank you for your time. > I'm a bit