Re: [Openvpn-devel] [PATCH] systemd: Change the default cipher to AES-256-GCM for server configs

2020-06-22 Thread Dmitry Melekhov
22.06.2020 20:58, Selva Nair пишет: +*WARNING*This MAY break configurations where the client uses +``--disable-occ`` feature where the ``--cipher`` has +not been explicitly configured on both client and +server side. It is recommended to

[Openvpn-devel] [PATCH v8 1/1] Add unit tests for engine keys

2020-06-22 Thread James Bottomley
Testing engines is problematic, so one of the prerequisites built for the tests is a simple openssl engine that reads a non-standard PEM guarded key. The test is simply can we run a client/server configuration with the usual sample key replaced by an engine key. The trivial engine prints out some

[Openvpn-devel] [PATCH v8 0/1] Add unit tests for engine keys

2020-06-22 Thread James Bottomley
This is the version that should work on Linux, Mac and BSD (famous last words ...). I've checked it on the Linux platforms (Ubuntu and OpenSUSE). James --- James Bottomley (1): Add unit tests for engine keys configure.ac | 2 +

Re: [Openvpn-devel] [PATCH v6 3/3] Add unit tests for engine keys

2020-06-22 Thread Gert Doering
Hi, On Mon, Jun 22, 2020 at 11:28:16AM -0700, James Bottomley wrote: > That will be my fault. I assumed automake always ran with gnu make, No :-) (and let's not start a gnu make vs bsd make vs. cmake vs. ant discussion now :-) ). Specifically, we run automake on linux systems before doing

Re: [Openvpn-devel] [PATCH v6 3/3] Add unit tests for engine keys

2020-06-22 Thread James Bottomley
On Mon, 2020-06-22 at 19:28 +0200, Gert Doering wrote: > Hi, > > On Mon, Jun 22, 2020 at 10:06:44AM -0700, James Bottomley wrote: > > > [..] > > > > Right, that's what the patch in the url does: uses .so on both > > > > mac > > > > and linux. > > > > > > I got all confused with your "v6" patch

Re: [Openvpn-devel] [PATCH] systemd: Change the default cipher to AES-256-GCM for server configs

2020-06-22 Thread David Sommerseth
[resent for the ML inclusion] On 22/06/2020 18:58, Selva Nair wrote: > On Mon, Jun 22, 2020 at 7:31 AM David Sommerseth wrote: [...snip...] >> +ExecStart=@sbindir@/openvpn --status %t/openvpn-server/status-%i.log >> --status-version 2 --suppress-timestamps --cipher AES-256-GCM --ncp-ciphers >>

Re: [Openvpn-devel] [PATCH] systemd: Change the default cipher to AES-256-GCM for server configs

2020-06-22 Thread David Sommerseth
On 22/06/2020 14:43, Steffan Karger wrote: > Hi, > > On 22-06-2020 14:29, David Sommerseth wrote: >> On 22/06/2020 14:21, Arne Schwabe wrote: >>> PrivateTmp=true WorkingDirectory=/etc/openvpn/server -ExecStart=@sbindir@/openvpn --status %t/openvpn-server/status-%i.log

Re: [Openvpn-devel] [PATCH] systemd: Change the default cipher to AES-256-GCM for server configs

2020-06-22 Thread David Sommerseth
On 22/06/2020 19:20, André via Openvpn-devel wrote: > Hi, > > > Sent with ProtonMail Secure Email. > > ‐‐‐ Original Message ‐‐‐ > On Monday 22 June 2020 18:58, Selva Nair wrote: > >> On Mon, Jun 22, 2020 at 7:31 AM David Sommerseth dav...@openvpn.net wrote: >> >>> This change makes

Re: [Openvpn-devel] [PATCH v6 3/3] Add unit tests for engine keys

2020-06-22 Thread Gert Doering
Hi, On Mon, Jun 22, 2020 at 10:06:44AM -0700, James Bottomley wrote: > > [..] > > > Right, that's what the patch in the url does: uses .so on both mac > > > and linux. > > > > I got all confused with your "v6" patch and your "v7" patch, which > > did other things, and but did not have a "v6" in

Re: [Openvpn-devel] [PATCH] systemd: Change the default cipher to AES-256-GCM for server configs

2020-06-22 Thread André via Openvpn-devel
Hi, Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Monday 22 June 2020 18:58, Selva Nair wrote: > On Mon, Jun 22, 2020 at 7:31 AM David Sommerseth dav...@openvpn.net wrote: > > > This change makes the server use AES-256-GCM instead of BF-CBC as the > > default cipher

Re: [Openvpn-devel] [PATCH v6 3/3] Add unit tests for engine keys

2020-06-22 Thread James Bottomley
On Mon, 2020-06-22 at 18:23 +0200, Gert Doering wrote: > Hi, > > On Sun, Jun 21, 2020 at 08:10:34AM -0700, James Bottomley wrote: > > > Arne, James, can we converge on something here? > > > > Could someone just test the proposed updated v6 patch on a Mac? > > > >

Re: [Openvpn-devel] [PATCH] systemd: Change the default cipher to AES-256-GCM for server configs

2020-06-22 Thread Selva Nair
On Mon, Jun 22, 2020 at 7:31 AM David Sommerseth wrote: > > This change makes the server use AES-256-GCM instead of BF-CBC as the > default cipher for the VPN tunnel when starting OpenVPN via systemd > and the openvpn-server@.service unit file. > > To avoid breaking existing running

Re: [Openvpn-devel] [PATCH v6 3/3] Add unit tests for engine keys

2020-06-22 Thread Gert Doering
Hi, On Sun, Jun 21, 2020 at 08:10:34AM -0700, James Bottomley wrote: > > Arne, James, can we converge on something here? > > Could someone just test the proposed updated v6 patch on a Mac? > > https://sourceforge.net/p/openvpn/mailman/message/37031113/ Took Arne and me half a day ("the macos

[Openvpn-devel] [PATCH v4 3/3] Implement tls-groups option to specify eliptic curves/groups

2020-06-22 Thread Arne Schwabe
By default OpenSSL 1.1+ only allows signatures and ecdh/ecdhx from the default list of X25519:secp256r1:X448:secp521r1:secp384r1. In TLS1.3 key exchange is independent from the signature/key of the certificates, so allowing all groups per default is not a sensible choice anymore and instead a

Re: [Openvpn-devel] [PATCH] systemd: Change the default cipher to AES-256-GCM for server configs

2020-06-22 Thread Arne Schwabe
Am 22.06.20 um 14:43 schrieb Steffan Karger: > Hi, > > On 22-06-2020 14:29, David Sommerseth wrote: >> On 22/06/2020 14:21, Arne Schwabe wrote: >>> PrivateTmp=true WorkingDirectory=/etc/openvpn/server -ExecStart=@sbindir@/openvpn --status %t/openvpn-server/status-%i.log

Re: [Openvpn-devel] [PATCH] systemd: Change the default cipher to AES-256-GCM for server configs

2020-06-22 Thread Steffan Karger
Hi, On 22-06-2020 14:29, David Sommerseth wrote: > On 22/06/2020 14:21, Arne Schwabe wrote: >> >>> PrivateTmp=true >>> WorkingDirectory=/etc/openvpn/server >>> -ExecStart=@sbindir@/openvpn --status %t/openvpn-server/status-%i.log >>> --status-version 2 --suppress-timestamps --config %i.conf

Re: [Openvpn-devel] [PATCH] systemd: Change the default cipher to AES-256-GCM for server configs

2020-06-22 Thread David Sommerseth
On 22/06/2020 14:21, Arne Schwabe wrote: > >> PrivateTmp=true >> WorkingDirectory=/etc/openvpn/server >> -ExecStart=@sbindir@/openvpn --status %t/openvpn-server/status-%i.log >> --status-version 2 --suppress-timestamps --config %i.conf >> +ExecStart=@sbindir@/openvpn --status

Re: [Openvpn-devel] [PATCH] systemd: Change the default cipher to AES-256-GCM for server configs

2020-06-22 Thread Arne Schwabe
> PrivateTmp=true > WorkingDirectory=/etc/openvpn/server > -ExecStart=@sbindir@/openvpn --status %t/openvpn-server/status-%i.log > --status-version 2 --suppress-timestamps --config %i.conf > +ExecStart=@sbindir@/openvpn --status %t/openvpn-server/status-%i.log > --status-version 2

[Openvpn-devel] [PATCH] systemd: Change the default cipher to AES-256-GCM for server configs

2020-06-22 Thread David Sommerseth
This change makes the server use AES-256-GCM instead of BF-CBC as the default cipher for the VPN tunnel when starting OpenVPN via systemd and the openvpn-server@.service unit file. To avoid breaking existing running configurations defaulting to BF-CBC, the Negotiable Crypto Parameters (NCP) list

Re: [Openvpn-devel] [PATCH] Add deferred authentication support to plugin-auth-pam

2020-06-22 Thread Gert Doering
Good morning, and thanks for the quick review :-) On Sun, Jun 21, 2020 at 06:23:15PM -0400, Selva Nair wrote: > On Sat, Jun 20, 2020 at 12:23 PM Gert Doering wrote: > > If OpenVPN signals deferred authentication support (by setting the > > internal environment variable "auth_control_file"), do