[Openvpn-devel] On tap-windows6 adapter installation by tapctl.exe

Hi, tldr: a fix for Trac 1321 Currently tapctl.exe does the following to create an adapter and install the driver on it. 1. Create a device info structure 2. Set the hardware id on it 3. Search the driver store for the latest matching driver 4. Select the driver, set it in the device info and

Re: [Openvpn-devel] [PATCH] openvpnmsica: make adapter renaming non-fatal

Hi, >> Warning is printed inside tap_delete_adapter(). > > tap_delete_adapter() is not called here. Right, I managed to mistype tap_set_adapter_name(). > I was suggesting that if we do check the return value, let us also print a > warning > that renaming failed. That can't be done anywhere

Re: [Openvpn-devel] [PATCH] openvpnmsica: remove adapter renaming

Hi, Adapter name already is configurable in openvpn-build/windows-msi/msi.wxs: https://github.com/Amebis/openvpn-build/blob/5f5ba807de2bad50d01a5b08dfc6fad98ee41213/windows-msi/msi.wxs#L1300 Regards, Simon From: Selva Nair Sent: Wednesday, September 2, 2020 3:12 PM To: Lev Stipakov Cc: Lev

Re: [Openvpn-devel] [PATCH] openvpnmsica: make adapter renaming non-fatal

Hi On Wed, Sep 2, 2020 at 9:54 AM Lev Stipakov wrote: > Hi, > > >> if (dwResult != ERROR_SUCCESS) > >> { > >> -tap_delete_adapter(NULL, , > ); > >> +/* failed renaming is not a fatal error, continue > */ > >> +

Re: [Openvpn-devel] [PATCH] openvpnmsica: make adapter renaming non-fatal

Hi, >> if (dwResult != ERROR_SUCCESS) >> { >> -tap_delete_adapter(NULL, , >> ); >> +/* failed renaming is not a fatal error, continue */ >> +dwResult = ERROR_SUCCESS; > > > This looks strange. If we are

Re: [Openvpn-devel] [PATCH] openvpnmsica: make adapter renaming non-fatal

Hi On Wed, Sep 2, 2020 at 9:39 AM Lev Stipakov wrote: > From: Lev Stipakov > > For some users renaming adapter mysteriously fails > (https://github.com/OpenVPN/openvpn-build/issues/187), > > Since renaming is just a a "nice to have", make it not fatail. > > Signed-off-by: Lev Stipakov > --- >

[Openvpn-devel] [PATCH] openvpnmsica: make adapter renaming non-fatal

From: Lev Stipakov For some users renaming adapter mysteriously fails (https://github.com/OpenVPN/openvpn-build/issues/187), Since renaming is just a a "nice to have", make it not fatail. Signed-off-by: Lev Stipakov --- src/openvpnmsica/openvpnmsica.c | 3 ++- 1 file changed, 2

Re: [Openvpn-devel] [PATCH] openvpnmsica: remove adapter renaming

Hi, I would suggest to keep this renaming but make it not fatal. A descriptive name is nice to have and we could even make the name configurable at some point in future. Selva On Wed, Sep 2, 2020 at 8:40 AM Lev Stipakov wrote: > From: Lev Stipakov > > Renaming doesn't work on some machines (

Re: [Openvpn-devel] OpenVPN 2.5-beta3 released

Hi, On Wed, Sep 02, 2020 at 10:03:11AM +0200, Thomas Schäfer wrote: > Am 01.09.20 um 22:14 schrieb Gert Doering: > > On Tue, Sep 01, 2020 at 08:07:20PM +0200, Thomas Schäfer wrote: > >>> - IPv4-only VPN > >> Typo? > > > > We can do that! > > Is it new in 2.5? The --block-ipv6 command is

[Openvpn-devel] [PATCH] openvpnmsica: remove adapter renaming

From: Lev Stipakov Renaming doesn't work on some machines (https://github.com/OpenVPN/openvpn-build/issues/187) and we couldn't find the cause. Also others do not seem to do it, so let's get rid of it. Signed-off-by: Lev Stipakov --- src/openvpnmsica/openvpnmsica.c | 9 - 1 file

[Openvpn-devel] Summary of the community meeting (2nd September 2020)

Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on irc.freenode.net Date: Wed 2nd September 2020 Time: 11:30 CEST (9:30 UTC) Planned meeting topics for this meeting were here: Your local

Re: [Openvpn-devel] OpenVPN 2.5-beta3 released

Am 01.09.20 um 22:14 schrieb Gert Doering: Hi, On Tue, Sep 01, 2020 at 08:07:20PM +0200, Thomas Schäfer wrote: - IPv4-only VPN Typo? We can do that! Is it new in 2.5? Asking again, just to understand the difference "IPv6-only operation" I can remove all IPv4-related config and

Re: [Openvpn-devel] OpenVPN 2.5-beta3 released

Argh yes. Copy-and-paste from the 2.5-beta1 release notes which had that typo :). Samuli Il 01/09/20 21:07, Thomas Schäfer ha scritto: >> - IPv4-only VPN > > Typo? > > > > > > > > > ___ > Openvpn-devel mailing list >