Hi,
I'm not convinced of the utility of this. It could be marginally
useful in some setups where all users are tied to a domain and
choosing any certificate that matches a template is appropriate. I
don't have a setup to test this.
Here are some general comments anyway.
On Tue, May 25, 2021 at 5
As with the last patch, I have not tested this - relying on Lev. I have
looked at the changes a bit and "they do what it says on the tin" (though
I have not explicitly verified each char/wchar <-> %hs/%ls mapping).
Your patch has been applied to the master branch.
commit ea2b153c35723fc2bbcf54ef
Have not tested anything, just looked a bit at the changes. ACK from
Lev is good enough :-) - and getting rid of #ifdef is even better.
Your patch has been applied to the master branch.
commit 455d0997931f968ed8c42812106c44941c4ca69b
Author: Selva Nair
Date: Fri May 21 23:32:30 2021 -0400
Stared at code ("git diff color-moved=zebra"), ran local linux tests. Did
not expect issues, had none :-)
Your patch has been applied to the master branch.
commit b7701fc5ce3a2d49bca890859541bb4b8dff0aec
Author: Antonio Quartulli
Date: Thu May 6 01:12:55 2021 +0200
forward: get rid of us
Hi,
When _DEBUG is defined openvpnmsica builds okay using MSVC, but fails
on mingw (before and after this patch) with errors like
openvpnmsica.c:410:17: error: ‘L__FUNCTION__’ undeclared (first use in
this function); did you mean ‘NLS_FUNCTION’?
debug_popup(TEXT(__FUNCTION__));
I have left
From: Selva Nair
The tapctl and openvpnmscia codebase is written with an intent of
supporting both unicode and ansi builds. This patch does not attempt
to change that although non-unicode support looks untested
and buggy.
The main change is to replace %s by PRIsLPTSR that is defined
as %ls or %
Hi,
Thanks for the review.
On Tue, May 25, 2021 at 4:06 AM Lev Stipakov wrote:
>
> Hi,
>
> I got compilation error:
Oops.. I did not test building with _DEBUG defined.
>
> 2>openvpnmsica.c
> 2>C:\Users\lev\Projects\openvpn\src\openvpnmsica\openvpnmsica.c(140,1):
> warning C4002: too many argum
The certificate selection process for the Crypto API certificates
is currently fixed to match on subject or identifier. Especially
if certificates that are used for OpenVPN are managed by a Windows CA,
it is appropriate to select the certificate to use by the template
that it is generated from, esp
Looks reasonable.
Built and tested with MSVC.
Acked-by: Lev Stipakov
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Hi,
I got compilation error:
2>openvpnmsica.c
2>C:\Users\lev\Projects\openvpn\src\openvpnmsica\openvpnmsica.c(140,1):
warning C4002: too many arguments for function-like macro invocation
'TEXT'
2>C:\Users\lev\Projects\openvpn\src\openvpnmsica\openvpnmsica.c(140,24):
error C2143: syntax error: mis
Idea of this patch has been already discussed:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21509.html
Code looks good, built and smoke-tested with MSVC.
Acked-by: Lev Stipakov
___
Openvpn-devel mailing list
Openvpn-devel@lists
11 matches
Mail list logo
