Re: [Openvpn-devel] [PATCH] Include --push-remove in the output of --help.

2021-11-17 Thread Antonio Quartulli
Hi, On 17/11/2021 07:44, Gert Doering wrote: "push-remove" has been in OpenVPN since 2.4, but managed to stay hidden from the "--help" output. Add. Reported-by: mike tancsa Signed-off-by: Gert Doering Acked-by: Antonio Quartulli Let's uncover the easter eggs! (as if we did not have enou

[Openvpn-devel] [PATCH applied] Re: Include --push-remove in the output of --help.

2021-11-17 Thread Gert Doering
Patch has been applied to the master and release/2.5 branch. commit 2a555c3aafcc8cf238a803d25971938ed75b518d (master) commit 59a8406e0e10716939a587aff3cb9662ce951d47 (release/2.5) Author: Gert Doering Date: Wed Nov 17 07:44:42 2021 +0100 Include --push-remove in the output of --help.

Re: [Openvpn-devel] [PATCH applied] Re: Use TYPE_do_all_provided function for listing cipher/digest

2021-11-17 Thread Gert Doering
Hi, On Wed, Nov 10, 2021 at 02:47:04PM +0100, Gert Doering wrote: > Acked-by: Gert Doering > > This is "v3 with the SIZE() change", and this change looks good. Max > has already stated "looks good and works", but wanted the sizeof() > change which is now in - so taking his pre-review, adding m

Re: [Openvpn-devel] (no subject)

2021-11-17 Thread Gert Doering
Hi, On Wed, Nov 03, 2021 at 08:20:13PM +, Richard T Bonhomme wrote: > Trac: 1417 For future patches, please include the Trac-ID in the commit message, at the end, like this I fixed a totally important problem here! Trac: #1417 Signed-off-by: ... Se

[Openvpn-devel] [PATCH applied] Re: doc link-options.rst: Use free open-source dynamic-DNS provider URL

2021-11-17 Thread Gert Doering
Acked-by: Gert Doering This looks like a useful service / project, and dyndns.org really went downhill - so if we endorse something, it should be free and open, so "yes". Your patch has been applied to the master and release/2.5 branch. commit 2c2e13d9ecdd1364c6a05ad77cea2840c015aa56 (master) c

[Openvpn-devel] [PATCH applied] Re: doc openvpn.8: Use free open-source dynamic-DNS provider URL

2021-11-17 Thread Gert Doering
Acked-by: Gert Doering Same change as for master and 2.5, but the content is elsewhere in this branch -> so, separate patch needed. Thanks. Your patch has been applied to the release/2.4 branch. commit fa17baf7c4552ba88ccf97dd2220cce897337b13 Author: Richard T Bonhomme Date: Wed Nov 3 21:18

[Openvpn-devel] [PATCH] Don't "undo" ifconfig when given --ifconfig-noexec

2021-11-17 Thread Max Fillinger
When running with --ifconfig-noexec on Linux, OpenVPN may still delete the ip address from the tun interface on exit, because it tries to undo the ifconfig that did not actually happen. This commit reintroduces the did_ifconfig member to struct tuntap so that we can check if ifconfig was actually

Re: [Openvpn-devel] [PATCH] Don't "undo" ifconfig when given --ifconfig-noexec

2021-11-17 Thread Gert Doering
Hi, On Wed, Nov 17, 2021 at 06:54:24PM +0100, Max Fillinger wrote: > When running with --ifconfig-noexec on Linux, OpenVPN may still delete > the ip address from the tun interface on exit, because it tries to undo > the ifconfig that did not actually happen. > > This commit reintroduces the did_i

Re: [Openvpn-devel] [PATCH] Don't "undo" ifconfig when given --ifconfig-noexec

2021-11-17 Thread Maximilian Fillinger
> ... so why is "did_ifconfig_setup" true, if ifconfig wasn't done? > > Or, phrased differently, what is did_ifconfig_setup used for, across the > code, and can we just "not set it to true" if ifconfig-noexec is in > effect? Or does it have nasty side effects? tt->did_ifconfig_setup is set in