[Openvpn-devel] [PATCH 2/3] dns option: remove support for exclude-domains

2023-03-09 Thread Heiko Hund
No DNS resolver currently supports this and it is not possible to emulate the behavior without the chance of errors. Finding the effective default system DNS server(s) to specify the exclude DNS routes is not trivial and cannot be verified to be correct without resolver internal knowledge. So, it

[Openvpn-devel] [PATCH 3/3] dns option: make server id/priority optional

2023-03-09 Thread Heiko Hund
With the discovery that most of the time only one DNS server's settings can be applied on various systems, the priority value will likely serve no purpose most of the time. This is to make it optional to give a --dns server priority, for cases where you only specify one DNS server anyway. We keep

[Openvpn-devel] [PATCH 1/3] dns option: allow up to eight addresses per server

2023-03-09 Thread Heiko Hund
This change allows configuration of more than one address per family for a DNS server. This way you can specify backup addresses in case a server is not reachable. During closer inspection of the various DNS backend in supported operation systems it turned out that our previous idea to have more

Re: [Openvpn-devel] [PATCH v2] dco: don't use NetLink to exchange control packets

2023-03-09 Thread Arne Schwabe
Am 09.03.2023 um 22:03 schrieb Antonio Quartulli: Using NetLink for control messages did not work out as it did lead to kernel side buffer congestion during heavy client activity. With this patch DCO will redirect control packets directly to the transport socket without altering them, so that

[Openvpn-devel] [PATCH v2] dco: don't use NetLink to exchange control packets

2023-03-09 Thread Antonio Quartulli
Using NetLink for control messages did not work out as it did lead to kernel side buffer congestion during heavy client activity. With this patch DCO will redirect control packets directly to the transport socket without altering them, so that userspace can happily process them as usual.

[Openvpn-devel] [PATCH applied] Re: tests/unit_tests: Fix 'make distcheck' with subdir-objects enabled

2023-03-09 Thread Gert Doering
Tested in-tree and out-of-tree builds, regular "make check" and also "make distcheck", Linux and FreeBSD. All works. Your patch has been applied to the master and release/2.6 branch. commit 838474145933199a62d1f59fbc2df14e4fbd57f3 (master) commit 5eb94ce9ef2d4095004a0a3c9dbf3aeae78cf371

[Openvpn-devel] [PATCH applied] Re: Ensure n = 2 is set in key2 struct in tls_crypt_v2_unwrap_client_key

2023-03-09 Thread Gert Doering
Trivial enough :-) - wording fixes applied ("structer", "trigerring"). Interesting that Antonio could reproduce this while it "just works" in my test beds. Your patch has been applied to the master and release/2.6 branch. commit 85832307fcb41c229ccb7ba83984726757eb32f7 (master) commit

[Openvpn-devel] [PATCH applied] Re: Set netlink socket to be non-blocking

2023-03-09 Thread Gert Doering
I cannot reproduce this particular problem on my Linux/DCO systems here, but with the problem description, the patch makes sense. Minimally tested on a Linux/DCO system. Your patch has been applied to the master and release/2.6 branch. commit 7aa3520768a68fb6a73ab64569c7be5d571f86fc (master)

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-09 Thread plaisthos (Code Review)
Attention is currently required from: cron2, ordex. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email ) Change subject: dco: don't use NetLink to exchange control packets ..

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-09 Thread plaisthos (Code Review)
Attention is currently required from: cron2, ordex. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email ) Change subject: dco: don't use NetLink to exchange control packets ..

Re: [Openvpn-devel] [PATCH v3] dco: print version to log if available

2023-03-09 Thread Antonio Quartulli
This is being discussed on Gerrit at: https://gerrit.openvpn.net/c/openvpn/+/28 On 09/03/2023 14:14, Antonio Quartulli wrote: In order to provide better support in case of troubleshooting issues, it's important to know what exact DCO version is loaded on the user system. Therefore print the

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-09 Thread ordex (Code Review)
Attention is currently required from: cron2, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email ) Change subject: dco: don't use NetLink to exchange control packets ..

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-09 Thread ordex (Code Review)
Attention is currently required from: cron2, plaisthos. Hello cron2, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/28?usp=email to look at the new patch set (#5). Change subject: dco: don't use NetLink to exchange control packets

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-09 Thread ordex (Code Review)
Attention is currently required from: cron2, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email ) Change subject: dco: don't use NetLink to exchange control packets ..

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-09 Thread plaisthos (Code Review)
Attention is currently required from: cron2, ordex. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email ) Change subject: dco: don't use NetLink to exchange control packets ..

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-09 Thread ordex (Code Review)
Attention is currently required from: cron2, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email ) Change subject: dco: don't use NetLink to exchange control packets ..

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-09 Thread plaisthos (Code Review)
Attention is currently required from: cron2, ordex. ordex has uploaded this change for review. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email ) Change subject: dco: don't use NetLink to exchange control packets .. dco:

[Openvpn-devel] [L] Change in openvpn[master]: dco: don't use NetLink to exchange control packets

2023-03-09 Thread plaisthos (Code Review)
Attention is currently required from: cron2, ordex. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/28?usp=email ) Change subject: dco: don't use NetLink to exchange control packets ..

[Openvpn-devel] [PATCH v3] dco: print version to log if available

2023-03-09 Thread Antonio Quartulli
In order to provide better support in case of troubleshooting issues, it's important to know what exact DCO version is loaded on the user system. Therefore print the DCO version during bootup. For Windows and FreeBSD we currently implement a placeholder printing 'v0'. This should be improved

Re: [Openvpn-devel] [PATCH] Ensure n = 2 is set in key2 structer in tls_crypt_v2_unwrap_client_key

2023-03-09 Thread Antonio Quartulli
Hi, On 09/03/2023 13:00, Arne Schwabe wrote: The ASSERT in xor_key2 assumes that all methods that load a key2 struct correctly set n=2. However, tls_crypt_v2_unwrap_client_key loads a key without setting n = 2, trigerring the assert. trigerring -> triggering Closes and reported in

[Openvpn-devel] [PATCH v2] dco: print version to log if available

2023-03-09 Thread Antonio Quartulli
In order to provide better support in case of troubleshooting issues, it's important to know what exact DCO version is loaded on the user system. Therefore print the DCO version during bootup. For Windows and FreeBSD we currently implement a placeholder printing 'v0'. This should be improved

[Openvpn-devel] [PATCH] dco: print FreeBSD version

2023-03-09 Thread Kristof Provost via Openvpn-devel
From: Kristof Provost Implement dco_version_string() for FreeBSD. Unlike Linux and Windows the DCO driver is built into the operating system itself, so we log the OS version as a proxy for the DCO version. --- src/openvpn/dco_freebsd.c | 12 +++- 1 file changed, 11 insertions(+), 1

Re: [Openvpn-devel] [PATCH] dco: print FreeBSD version

2023-03-09 Thread Antonio Quartulli
Hi, On 09/03/2023 13:13, Kristof Provost via Openvpn-devel wrote: This should use BSTR(data) instead. I copied Antonio’s code here, but that is better, so I’ll fix that too. dang! with one email Arne spoiled two patches! Cheers, -- Antonio Quartulli

Re: [Openvpn-devel] [PATCH] dco: print FreeBSD version

2023-03-09 Thread Kristof Provost via Openvpn-devel
On 9 Mar 2023, at 13:06, Arne Schwabe wrote: > Am 09.03.23 um 10:26 schrieb Kristof Provost via Openvpn-devel: >> From: Kristof Provost >> >> Implement dco_version_string() for FreeBSD. >> Unlike Linux and Windows the DCO driver is built into the operating >> system itself, so we log the OS

Re: [Openvpn-devel] [PATCH] dco: print FreeBSD version

2023-03-09 Thread Arne Schwabe
Am 09.03.23 um 10:26 schrieb Kristof Provost via Openvpn-devel: From: Kristof Provost Implement dco_version_string() for FreeBSD. Unlike Linux and Windows the DCO driver is built into the operating system itself, so we log the OS version as a proxy for the DCO version. ---

[Openvpn-devel] [PATCH] Ensure n = 2 is set in key2 structer in tls_crypt_v2_unwrap_client_key

2023-03-09 Thread Arne Schwabe
The ASSERT in xor_key2 assumes that all methods that load a key2 struct correctly set n=2. However, tls_crypt_v2_unwrap_client_key loads a key without setting n = 2, trigerring the assert. Closes and reported in https://github.com/OpenVPN/openvpn/issues/272 Change-Id:

[Openvpn-devel] [PATCH] dco: print FreeBSD version

2023-03-09 Thread Kristof Provost via Openvpn-devel
From: Kristof Provost Implement dco_version_string() for FreeBSD. Unlike Linux and Windows the DCO driver is built into the operating system itself, so we log the OS version as a proxy for the DCO version. --- src/openvpn/dco_freebsd.c | 14 +- 1 file changed, 13 insertions(+), 1

Re: [Openvpn-devel] [PATCH] dco: print version to log if available

2023-03-09 Thread Antonio Quartulli
Hi, On 09/03/2023 10:03, Kristof Provost wrote: On 9 Mar 2023, at 9:57, Antonio Quartulli wrote: On 09/03/2023 09:36, Kristof Provost wrote: On 9 Mar 2023, at 1:52, Antonio Quartulli wrote: In order to provide better support in case of troubleshooting issues, it's important to know what

Re: [Openvpn-devel] [PATCH] dco: print version to log if available

2023-03-09 Thread Kristof Provost via Openvpn-devel
On 9 Mar 2023, at 9:57, Antonio Quartulli wrote: > On 09/03/2023 09:36, Kristof Provost wrote: >> On 9 Mar 2023, at 1:52, Antonio Quartulli wrote: >>> In order to provide better support in case of troubleshooting issues, >>> it's important to know what exact DCO version is loaded on the user >>>

Re: [Openvpn-devel] [PATCH] dco: print version to log if available

2023-03-09 Thread Antonio Quartulli
Hi, On 09/03/2023 09:36, Kristof Provost wrote: On 9 Mar 2023, at 1:52, Antonio Quartulli wrote: In order to provide better support in case of troubleshooting issues, it's important to know what exact DCO version is loaded on the user system. Therefore print the DCO version during bootup.

Re: [Openvpn-devel] [PATCH] dco: print version to log if available

2023-03-09 Thread Kristof Provost via Openvpn-devel
On 9 Mar 2023, at 1:52, Antonio Quartulli wrote: > In order to provide better support in case of troubleshooting issues, > it's important to know what exact DCO version is loaded on the user > system. > > Therefore print the DCO version during bootup. > > For Windows and FreeBSD we currently