Re: [Openvpn-devel] [PATCH] Mock openvpn_exece on win32 also for test_tls_crypt

2023-07-04 Thread Frank Lichtenheld
On Tue, Jul 04, 2023 at 04:08:05PM +0200, Arne Schwabe wrote: > This function is needed to commpile on win32 as run_command.c defines it > on Unix Linux but on windows it is defined in win32.c which pulls in too > many other unresolvable symbols. Also need to add mock_win32_execve.c in

Re: [Openvpn-devel] [PATCH v2 3/4] Check if the -wrap argument is actually supported by the platform's ld

2023-07-04 Thread Frank Lichtenheld
On Sat, Jul 01, 2023 at 10:24:52PM +0200, Arne Schwabe wrote: > This avoids build errors on macOS. Also the test_tls_crypt command works > just fine on FreeBSD with its linkers, so do not make that test Linux only. > > Patch v2: allow running with old cmake version (cmake 3 on RHEL7 with EPEL >

Re: [Openvpn-devel] [PATCH v2 2/2] Fix CR_RESPONSE mangaement message using wrong key_id

2023-07-04 Thread Selva Nair
It seems I missed to send this ACK to the list.. Here it is. On Mon, May 22, 2023 at 6:12 AM Arne Schwabe wrote: > the management interface expects the management key id instead > of the openvpn key id. In the past they often were the same for low ids > which hid the bug quite well. > > Also do

Re: [Openvpn-devel] [PATCH] CMake: Support doc builds on Windows machines that do not have .py file association

2023-07-04 Thread Arne Schwabe
Am 04.07.23 um 16:09 schrieb Frank Lichtenheld: On Windows we might need to call python because .py files are not directly executable. This is true e.g. for GHA runners. For now we assume that rst2html and rst2man can be handled in the same way and do not test both of them. Commit

[Openvpn-devel] [PATCH] Mock openvpn_exece on win32 also for test_tls_crypt

2023-07-04 Thread Arne Schwabe
This function is needed to commpile on win32 as run_command.c defines it on Unix Linux but on windows it is defined in win32.c which pulls in too many other unresolvable symbols. Change-Id: I8c8fe298eb30e211279f3fc010584b9d3bc14b4a Signed-off-by: Arne Schwabe --- CMakeLists.txt

Re: [Openvpn-devel] [PATCH v2 2/2] Fix CR_RESPONSE mangaement message using wrong key_id

2023-07-04 Thread Frank Lichtenheld
On Mon, May 22, 2023 at 12:11:38PM +0200, Arne Schwabe wrote: > the management interface expects the management key id instead > of the openvpn key id. In the past they often were the same for low ids > which hid the bug quite well. > > Also do not pick uninitialised keystates (management key_id

[Openvpn-devel] [PATCH] CMake: Support doc builds on Windows machines that do not have .py file association

2023-07-04 Thread Frank Lichtenheld
On Windows we might need to call python because .py files are not directly executable. This is true e.g. for GHA runners. For now we assume that rst2html and rst2man can be handled in the same way and do not test both of them. Commit e8881ec6dd63bd80ce05202573eac54ab8657fcb unconditionally used

[Openvpn-devel] [PATCH applied] Re: CMake: Throw a clear error when config.h in top-level source directory

2023-07-04 Thread Gert Doering
Sounds & looks reasonable. Not that I could really verify this, or have tested it, but that's what we have an ACK from Arne for :-) Your patch has been applied to the master branch. commit 0652ae84f4528daa57da344eee28b7385a6659a1 Author: Frank Lichtenheld Date: Mon Jul 3 17:39:25 2023 +0200

Re: [Openvpn-devel] OpenVPN Linking Exception - current status report update July

2023-07-04 Thread Arne Schwabe
Am 15.02.23 um 13:31 schrieb David Sommerseth: OpenVPN 2.x is licensed under the GNU Public License v2.0 (GPL-2.0). This license has served us well in the past and we are not trying to change that.  However, changes in licenses of our dependencies put us in an unfortunate situation. Since

Re: [Openvpn-devel] [PATCH] CMake: Throw a clear error when config.h in top-level source directory

2023-07-04 Thread Arne Schwabe
Am 03.07.23 um 18:39 schrieb Frank Lichtenheld: This causes weird, difficult to debug compilation errors. Usually caused by trying to run CMake against a source that had an in-tree autoconfig build. Note that you're able to do out-of-tree autoconfig builds and they can obviously mix with