Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/460?usp=email )
Change subject: Check PRF availability on initialisation and add
--force-tls-key-material-export
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/379?usp=email )
Change subject: Remove support for NTLM v1 proxy authentication
..
Remove support for NTLM v1 proxy authentication
Due to the limitation
The code change itself is fairly small and (git diff -w) easy to verify.
The patch is much larger because it removes all DES related code now
(which is welcome).
I have added a comment to Changes.rst as requested.
Lightly tested on FreeBSD / t_client - no NTLM proxy here, so that part
isn't
cron2 has uploaded a new patch set (#5) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/379?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: Remove support for NTLM v1 proxy authentication
Attention is currently required from: plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/471?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now.
Change subject: Add test_ssl unit test and test export of PEM to file
cron2 has uploaded a new patch set (#6) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/476?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: misc: make get_auth_challenge static
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/476?usp=email )
Change subject: misc: make get_auth_challenge static
..
misc: make get_auth_challenge static
Not used outside of misc.c.
Rename to
For whatever reason, doxygen documentation hunks for get_user_pass_cr()
sneaked into this patch - I have skipped those, as it's not related to
this patch and should go into the user_pass related patches (UT etc)
(maybe just a git rebase artefact anyway).
With the early return / ASSERT() it's a
Attention is currently required from: plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/454?usp=email )
Change subject: Fix unaligned access in macOS, FreeBSD, Solaris hwaddr
..
cron2 has uploaded a new patch set (#5) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/480?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: configure: enable silent rules by default
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/480?usp=email )
Change subject: configure: enable silent rules by default
..
configure: enable silent rules by default
The default build log is big and
Tested, looks good. Nothing is lost, as the full output is still
available with "make V=1".
Your patch has been applied to the master branch.
commit bfcad5cd054bf615c33ace2a920756c69467d497
Author: Frank Lichtenheld
Date: Sat Dec 30 15:23:48 2023 +0100
configure: enable silent rules by
cron2 has uploaded a new patch set (#4) to the change originally created by
flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/378?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: configure: allow to disable NTLM
Lightly tested (one build with and without --disable-ntlm, compare
resulting strings in binary). No surprises there, since this code was
already conditionalized, just not exposed to configure.
Your patch has been applied to the master branch.
commit 1da3496abce6c4380651fdf79c1d599750964ef2
cron2 has submitted this change. (
http://gerrit.openvpn.net/c/openvpn/+/378?usp=email )
Change subject: configure: allow to disable NTLM
..
configure: allow to disable NTLM
Since we want to get rid of it, might be useful to
Attention is currently required from: plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/454?usp=email )
Change subject: Fix unaligned access in macOS, FreeBSD, Solaris hwaddr
..
From: Arne Schwabe
This introduces a number of mock function to be able to compile
ssl_verify_*.c and ssl_mbedtls.c/ssl_openssl.c into a unit and adds
quite a number of files to that unit. But it allows similar unit tests
(in term of dependencies) to be added in the future.
Change-Id:
From: Frank Lichtenheld
The default build log is big and basically
unreadable.
Go the way of other build systems and do not
print compile commands by default. Verbose
output can always be enabled with make V=1.
Change-Id: Ib226079d1543209e08e5fdcf7344cd20850bea9d
Signed-off-by: Frank
From: Frank Lichtenheld
Not used outside of misc.c.
Rename to parse_auth_challenge since it really just parses
the string that you put in into the struct.
Add doxygen documentation.
v2:
- change if(auth_challenge) to ASSERT(auth_challenge)
Change-Id:
From: Frank Lichtenheld
Since we want to get rid of it, might be useful to
allow users to remove the support completely.
Change-Id: I199f83e2db5fc7c48a0ac9280cdbf9fa45f42300
Signed-off-by: Frank Lichtenheld
Acked-by: Arne Schwabe
---
This change was reviewed on Gerrit and approved by at
From: Frank Lichtenheld
Due to the limitation of the protocol it is not
considered secure. Better to use basic auth instead
of a false sense of security. NTLM v2 remains
supported for now.
Change-Id: I0dcb2dac4136f194da7050a8ea8495e9faba9dd9
Signed-off-by: Frank Lichtenheld
Acked-by: Arne
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/476?usp=email )
Change subject: misc: make get_auth_challenge static
..
Patch
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/480?usp=email )
Change subject: configure: enable silent rules by default
..
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/480?usp=email )
Change subject: configure: enable silent rules by default
..
24 matches
Mail list logo
