[Openvpn-devel] [M] Change in openvpn[master]: Implement Windows CA template match for Crypto-API selector

2024-06-05 Thread selvanair (Code Review)
Attention is currently required from: flichtenheld, plaisthos, ssbssa. selvanair has posted comments on this change by ssbssa. ( http://gerrit.openvpn.net/c/openvpn/+/621?usp=email ) Change subject: Implement Windows CA template match for Crypto-API selector .

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-06-05 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters .. Windows: enforce 'block-local' with WFP filters In an attempt to better

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-06-05 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#7) to the change originally created by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by stipa, Code-Review+2 by cron2 Change subject: Windows: enforce 'block-local' with WF

[Openvpn-devel] [PATCH applied] Re: Windows: enforce 'block-local' with WFP filters

2024-06-05 Thread Gert Doering
Acked-by: Gert Doering Lev has tested it and confirms that it works, I have stared long and hard at v5 of the patch, and the diffs v5->v6. The main difference v5->v6 is to make it error clean (add a "= 0") *and* that it also blocks DNS going out of the loopback interface - so if there's magic DN

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-06-05 Thread stipa (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters

[Openvpn-devel] [L] Change in openvpn[master]: Add t_server_null test suite

2024-06-05 Thread flichtenheld (Code Review)
Attention is currently required from: mattock, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/643?usp=email ) Change subject: Add t_server_null test suite .. Patch Set 2: (

[Openvpn-devel] IRC community meeting summary

2024-06-05 Thread Johan Draaisma
Meeting summary for 5 June 2024: * *New, closed: no community meeting on 12 June 2024* /Due to an event that a large amount of people will attend, this particular day will be inconvenient to do a meeting./ /Meetings will resume the week after on 19 June 2024./ * *Updated: Buildbot and

[Openvpn-devel] [PATCH v6] Windows: enforce 'block-local' with WFP filters

2024-06-05 Thread Gert Doering
From: Heiko Hund In an attempt to better defend against the TunnelCrack attacks, enforce that no traffic can pass to anything else than the VPN interface when the 'block-local' flags is given with either --redirect-gateway or --redirect-private. Reuse much of the existing --block-outside-dns cod

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-06-05 Thread cron2 (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters .

[Openvpn-devel] [L] Change in openvpn[master]: Add t_server_null test suite

2024-06-05 Thread flichtenheld (Code Review)
Attention is currently required from: mattock, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/643?usp=email ) Change subject: Add t_server_null test suite .. Patch Set 2: Co

[Openvpn-devel] [PATCH applied] Re: test_user_pass: Fix building with --enable-systemd

2024-06-05 Thread Gert Doering
Your patch has been applied to the master branch (this unit test is not in release/2.6, so nothing to fix there). Not tested myself as I do not have anything with systemd, but it does not break "non-systemd tests", as confirmed by gerrit/all the buildbots. commit 7dfff75659e6c06abe500f5b8716d9712

[Openvpn-devel] [XS] Change in openvpn[master]: test_user_pass: Fix building with --enable-systemd

2024-06-05 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/641?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: test_user_pass: Fix building with --enable-systemd

[Openvpn-devel] [XS] Change in openvpn[master]: test_user_pass: Fix building with --enable-systemd

2024-06-05 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/641?usp=email ) Change subject: test_user_pass: Fix building with --enable-systemd .. test_user_pass: Fix building with --enable-systemd Need to make sure

[Openvpn-devel] [S] Change in openvpn[master]: LZO: do not use lzoutils.h macros

2024-06-05 Thread cron2 (Code Review)
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/642?usp=email ) Change subject: LZO: do not use lzoutils.h macros .. LZO: do not use lzoutils.h macros Instead of lzo_{free,malloc} we can just use the fr

[Openvpn-devel] [S] Change in openvpn[master]: LZO: do not use lzoutils.h macros

2024-06-05 Thread cron2 (Code Review)
cron2 has uploaded a new patch set (#3) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/642?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: LZO: do not use lzoutils.h macros .

[Openvpn-devel] [PATCH applied] Re: LZO: do not use lzoutils.h macros

2024-06-05 Thread Gert Doering
Lightly tested via local builds and GHA. This is basically a no-op, as lzoutils.h contains #define lzo_malloc(a) (malloc(a)) #define lzo_free(a) (free(a)) .. and nothing more complicated. Having lzoutil.h out of the way paves the way for "make lzo2.pc pkg-config checks work" :

[Openvpn-devel] [PATCH v1] test_user_pass: Fix building with --enable-systemd

2024-06-05 Thread Gert Doering
From: Frank Lichtenheld Need to make sure that ENABLE_SYSTEMD is really disabled. Change-Id: Ic33c210f06e173a450534aa0969c57f140086655 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it t

[Openvpn-devel] [XS] Change in openvpn[master]: test_user_pass: Fix building with --enable-systemd

2024-06-05 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/641?usp=email ) Change subject: test_user_pass: Fix building with --enable-systemd

[Openvpn-devel] [L] Change in openvpn[master]: Add t_server_null test suite

2024-06-05 Thread mattock (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/643?usp=email to review the following change. Change subject: Add t_server_null test suite ...