[Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Fix writing messages to the event log

2025-09-16 Thread selvanair (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. selvanair has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email ) Change subject: openvpnserv: Fix writing messages to the event log .

[Openvpn-devel] [S] Change in openvpn[master]: Allowing installing FreeBSD routes with interface instead of next-hop

2025-09-16 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1193?usp=email to review the following change. Change subject: Allowing installing FreeBSD routes with interface instead of next-ho

[Openvpn-devel] [S] Change in openvpn[master]: dco: Change sd argument to dco_new_peer from int to socket_descriptor_t

2025-09-16 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1195?usp=email ) Change subject: dco: Change sd argument to dco_new_peer from int to socket_descriptor_t .

[Openvpn-devel] [M] Change in openvpn[master]: Install host routes with onlink scope iroutes for ifconfig-push routes

2025-09-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, ordex, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email ) Change subject: Install host routes with onlink scope iroutes for ifconfig-push routes ...

[Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Fix writing messages to the event log

2025-09-16 Thread selvanair (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. selvanair has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email ) Change subject: openvpnserv: Fix writing messages to the event log .

[Openvpn-devel] [M] Change in openvpn[master]: Install host routes with onlink scope iroutes for ifconfig-push routes

2025-09-16 Thread ordex (Code Review)
Attention is currently required from: d12fk, flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email ) Change subject: Install host routes with onlink scope iroutes for ifconfig-push routes ...

[Openvpn-devel] [M] Change in openvpn[master]: Install host routes with onlink scope iroutes for ifconfig-push routes

2025-09-16 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email ) Change subject: Install host routes with onlink scope iroutes for ifconfig-push routes ..

[Openvpn-devel] [S] Change in openvpn[master]: Allow route_ipv6_match_host to be used outside of route.c

2025-09-16 Thread ordex (Code Review)
Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1191?usp=email ) Change subject: Allow route_ipv6_match_host to be used outside of route.c

[Openvpn-devel] [S] Change in openvpn[master]: Allow route_ipv6_match_host to be used outside of route.c

2025-09-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1191?usp=email ) Change subject: Allow route_ipv6_match_host to be used outside of route.c

[Openvpn-devel] [M] Change in openvpn[master]: Install host routes with onlink scope iroutes for ifconfig-push routes

2025-09-16 Thread d12fk (Code Review)
Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email ) Change subject: Install host routes with onlink scope iroutes for ifconfig-push routes ..

[Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Fix writing messages to the event log

2025-09-16 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email ) Change subject: openvpnserv: Fix writing messages to the event log

[Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Fix writing messages to the event log

2025-09-16 Thread selvanair (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. selvanair has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email ) Change subject: openvpnserv: Fix writing messages to the event log .

[Openvpn-devel] [PATCH v1] Check message id/acked ids too when doing sessionid cookie checks

2025-09-16 Thread Gert Doering
From: Arne Schwabe This fixes that control packets on a floating client can trigger creating a new session in special circumstances: To trigger this circumstance a connection needs to - starts on IP A - successfully floats to IP B by data packet - then has a control packet from IP A before any

[Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Fix writing messages to the event log

2025-09-16 Thread selvanair (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. selvanair has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email ) Change subject: openvpnserv: Fix writing messages to the event log

[Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Fix writing messages to the event log

2025-09-16 Thread selvanair (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. selvanair has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email ) Change subject: openvpnserv: Fix writing messages to the event log

[Openvpn-devel] [S] Change in openvpn[master]: ps: Fix conversion warnings related to send/recv return values

2025-09-16 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1194?usp=email to review the following change. Change subject: ps: Fix conversion warnings related to send/recv return values

[Openvpn-devel] [M] Change in openvpn[release/2.6]: Check message id/acked ids too when doing sessionid cookie checks

2025-09-16 Thread MaxF (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1184?usp=email ) Change subject: Check message id/acked ids too when doing sessionid cookie checks .

Re: [Openvpn-devel] [M] Change in openvpn[master]: Check message id/acked ids too when doing sessionid cookie checks

2025-09-16 Thread Arne Schwabe
Am 23.08.25 um 23:28 schrieb Walter Doekes via Openvpn-devel: Thanks! Can we get this backported to 2.6 as well? https://gerrit.openvpn.net/c/openvpn/+/1184 Arne ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sour

[Openvpn-devel] [S] Change in openvpn[master]: Allow route_ipv6_match_host to be used outside of route.c

2025-09-16 Thread plaisthos (Code Review)
Attention is currently required from: d12fk, flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1191?usp=email to look at the new patch set (#3). Change subject: Allow route_ipv6_match_host to be used outside of route.c

[Openvpn-devel] [M] Change in openvpn[master]: Install host routes with onlink scope iroutes for ifconfig-push routes

2025-09-16 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email to look at the new patch set (#4). Change subject: Install host routes with onlink scope iroutes for ifconfig-push

[Openvpn-devel] [M] Change in openvpn[master]: Install host routes with onlink scope iroutes for ifconfig-push routes

2025-09-16 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email ) Change subject: Install host routes with onlink scope iroutes for ifconfig-push routes .

[Openvpn-devel] [S] Change in openvpn[release/2.6]: win: replace wmic invocation with powershell

2025-09-16 Thread stipa (Code Review)
stipa has abandoned this change. ( http://gerrit.openvpn.net/c/openvpn/+/1175?usp=email ) Change subject: win: replace wmic invocation with powershell .. Abandoned Superseded by 1183 -- To view, visit http://gerrit.openvpn.net

[Openvpn-devel] [S] Change in openvpn[master]: Allow route_ipv6_match_host to be used outside of route.c

2025-09-16 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1191?usp=email ) Change subject: Allow route_ipv6_match_host to be used outside of route.c ...

[Openvpn-devel] [M] Change in openvpn[master]: Install host routes with onlink scope iroutes for ifconfig-push routes

2025-09-16 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1192?usp=email to look at the new patch set (#3). Change subject: Install host routes with onlink scope iroutes for ifconfig-push

[Openvpn-devel] [XS] Change in openvpn[master]: Clarify some code in epoch with better comments

2025-09-16 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1190?usp=email ) Change subject: Clarify some code in epoch with better comments .. Patc

[Openvpn-devel] [S] Change in openvpn[master]: Allow route_ipv6_match_host to be used outside of route.c

2025-09-16 Thread d12fk (Code Review)
Attention is currently required from: plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1191?usp=email ) Change subject: Allow route_ipv6_match_host to be used outside of route.c .. P

Re: [Openvpn-devel] [PATCH net-next 0/3] net: tunnel: introduce noref xmit flows for tunnels

2025-09-16 Thread Sabrina Dubroca
2025-09-09, 16:43:01 +0200, Marek Mietus wrote: > W dniu 9/9/25 o 13:17, Antonio Quartulli pisze: > > On 09/09/2025 07:43, Marek Mietus wrote: > >> Currently, all xmit flows use dst_cache in a way that references > >> its dst_entry for each xmitted packet. These atomic operations > >> are redundant

Re: [Openvpn-devel] [PATCH net-next v2 3/3] net: ovpn: use new noref xmit flow in ovpn_udp4_output

2025-09-16 Thread Sabrina Dubroca
2025-09-12, 13:24:20 +0200, Marek Mietus wrote: > ovpn_udp4_output unnecessarily references the dst_entry from the > dst_cache. This should probably include a description of why it's safe to skip the reference in this context. > Reduce this overhead by using the newly implemented > udp_tunnel_xmi

Re: [Openvpn-devel] GCC15 errors

2025-09-16 Thread David Sommerseth via Openvpn-devel
On 16/09/2025 10:41, Marc Leeman wrote: >>> FYI, i've received a couple bugs wrt GCC15. For gdbuspp, I'll demote >>> the free-no-heap error atm, still need to look into the second error. >>> >>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1114118 >> >> I will need to look deeper into this one

[Openvpn-devel] [M] Change in openvpn[master]: Change msglevel flags to int

2025-09-16 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1189?usp=email to review the following change. Change subject: Change msglevel flags to int ..

Re: [Openvpn-devel] GCC15 errors

2025-09-16 Thread Marc Leeman
> > FYI, i've received a couple bugs wrt GCC15. For gdbuspp, I'll demote > > the free-no-heap error atm, still need to look into the second error. > > > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1114118 > > I will need to look deeper into this one. There are some odd things > happening h

[Openvpn-devel] [M] Change in openvpn[release/2.6]: openvpnserv: Fix writing messages to the event log

2025-09-16 Thread stipa (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. Hello cron2, flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1185?usp=email to look at the new patch set (#3). Change subject: openvpnserv: Fix writ

[Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Fix writing messages to the event log

2025-09-16 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos, selvanair. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email ) Change subject: openvpnserv: Fix writing messages to the event log

[Openvpn-devel] [M] Change in openvpn[master]: openvpnserv: Fix writing messages to the event log

2025-09-16 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1188?usp=email to look at the new patch set (#2). Change subject: openvpnserv: Fix writing messages t