Re: [Openvpn-devel] [PATCH] Added two features to Network Address Translator

2015-09-03 Thread Rafael Gava
Hello All, I'm looking forward to hearing from you guys a feedback if the patch for the features added to the NAT will be accepted or not or if is there anything else that I need to do or change in order to have it merged into the code. >From the previous replies, it seems that a minor change

Re: [Openvpn-devel] [PATCH] Added two features to Network Address Translator

2015-08-27 Thread Marvin
In certain cases we did exactly that. We used a linux appliance optimized as a router + OpenVPN. But the instances where we could get away with that is a small percentage of our installed base. Unfortunately the majority of those sites require the Windows box because of other requisite

Re: [Openvpn-devel] [PATCH] Added two features to Network Address Translator

2015-08-27 Thread Gert Doering
Hi, On Thu, Aug 27, 2015 at 09:18:12AM +1200, Jason Haar wrote: > On 26/08/15 20:35, Arne Schwabe wrote: > > Okay yes. Active FTP is broken by our simple nat implementation. But I > > think FTP, let alone active FTP is dead. I am not sure if we should > > support this in our simple NAT

Re: [Openvpn-devel] [PATCH] Added two features to Network Address Translator

2015-08-27 Thread Marvin
Author: Rafael Gava de Oliveira I wanted to give an ACK to both of Gava’s patches 1) client-nat localhost/client-ip patch and 2) active ftp patch. We had asked Gava to develop these patches so that we could use OpenVPN in our remote service network. We

Re: [Openvpn-devel] [PATCH] Added two features to Network Address Translator

2015-08-26 Thread Jason Haar
On 26/08/15 20:35, Arne Schwabe wrote: > Okay yes. Active FTP is broken by our simple nat implementation. But I > think FTP, let alone active FTP is dead. I am not sure if we should > support this in our simple NAT implementation. I agree. Surely this would be the beginning of a complete beat-up?

Re: [Openvpn-devel] [PATCH] Added two features to Network Address Translator

2015-08-26 Thread Rafael Gava
Hi JJK, "client-ip" instead of "localhost" sounds good to me. BR Gava On Wed, Aug 26, 2015 at 10:01 AM, Jan Just Keijser wrote: > Hi, > > Rafael Gava wrote: > >> >> this is my first submission to the list and I hope that I'm doing in the >> right way. :-) >> >> >> Well,

Re: [Openvpn-devel] [PATCH] Added two features to Network Address Translator

2015-08-26 Thread Jan Just Keijser
Hi, Rafael Gava wrote: this is my first submission to the list and I hope that I'm doing in the right way. :-) Well, the features added to Network Address Translator are: 1) Allow the user to use the string "localhost" on the client-nat network configuration in a way that is not

Re: [Openvpn-devel] [PATCH] Added two features to Network Address Translator

2015-08-26 Thread Rafael Gava
Hi Arne, thanks for the prompt feedback. please see comments in-line: Thanks in advance, Rafael On Wed, Aug 26, 2015 at 5:35 AM, Arne Schwabe wrote: > > > Am 26.08.15 um 03:43 schrieb Rafael Gava: > > Hi, > > this is my first submission to the list and I hope that I'm doing

Re: [Openvpn-devel] [PATCH] Added two features to Network Address Translator

2015-08-26 Thread Arne Schwabe
Am 26.08.15 um 03:43 schrieb Rafael Gava: > Hi, > > this is my first submission to the list and I hope that I'm doing in > the right way. :-) > Yes submitting patches to the list is the preferred way. I haven't looked in the patch yet. I am first trying to understand the goal of the patches. >

[Openvpn-devel] [PATCH] Added two features to Network Address Translator

2015-08-26 Thread Rafael Gava
Hi, this is my first submission to the list and I hope that I'm doing in the right way. :-) Well, the features added to Network Address Translator are: 1) Allow the user to use the string "localhost" on the client-nat network configuration in a way that is not necessary to inform the IP