Re: [Openvpn-devel] [PATCH] file checks: Merge warn_if_group_others_accessible() into check_file_access()

2016-11-16 Thread Gert Doering
Hi, On Wed, Nov 16, 2016 at 12:27:05PM -0500, Selva Nair wrote: > On Wed, Nov 16, 2016 at 11:07 AM, Steffan Karger > wrote: > > > > I do not have any Windows test environments, so I'll admit that's a > > > bold (and risky) move of me. However, as you've identified, >

Re: [Openvpn-devel] [PATCH] file checks: Merge warn_if_group_others_accessible() into check_file_access()

2016-11-16 Thread Selva Nair
On Wed, Nov 16, 2016 at 11:07 AM, Steffan Karger wrote: > > I do not have any Windows test environments, so I'll admit that's a > > bold (and risky) move of me. However, as you've identified, > > S_IRWXG|S_IRWXO is not set so shouldn't cause any issues. > > Combined

Re: [Openvpn-devel] [PATCH] file checks: Merge warn_if_group_others_accessible() into check_file_access()

2016-11-16 Thread Steffan Karger
On 16-11-16 15:59, David Sommerseth wrote: > On 16/11/16 11:44, Steffan Karger wrote: >> On 14-11-16 23:45, David Sommerseth wrote: >>> Commit 825e2ec1f358f2e8 cleaned up the usage of >>> warn_if_group_others_accessible() and moved it into options.c. >>> At this point there is only one caller of

Re: [Openvpn-devel] [PATCH] file checks: Merge warn_if_group_others_accessible() into check_file_access()

2016-11-16 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 16/11/16 11:44, Steffan Karger wrote: > Hi, > > On 14-11-16 23:45, David Sommerseth wrote: >> Commit 825e2ec1f358f2e8 cleaned up the usage of >> warn_if_group_others_accessible() and moved it into options.c. >> At this point there is only one

Re: [Openvpn-devel] [PATCH] file checks: Merge warn_if_group_others_accessible() into check_file_access()

2016-11-16 Thread Steffan Karger
On 16-11-16 11:44, Steffan Karger wrote: > I was also wondering, have you tested that this work as expected on > Windows? Since Windows has a quite different permission system. Or > will is simply never warn, like before? That would be fine for this patch. According to

Re: [Openvpn-devel] [PATCH] file checks: Merge warn_if_group_others_accessible() into check_file_access()

2016-11-16 Thread Steffan Karger
Hi, On 14-11-16 23:45, David Sommerseth wrote: > Commit 825e2ec1f358f2e8 cleaned up the usage of > warn_if_group_others_accessible() > and moved it into options.c. At this point there is only one caller of this > function, check_file_access(). > > This takes that clean-up one step further and

[Openvpn-devel] [PATCH] file checks: Merge warn_if_group_others_accessible() into check_file_access()

2016-11-14 Thread David Sommerseth
Commit 825e2ec1f358f2e8 cleaned up the usage of warn_if_group_others_accessible() and moved it into options.c. At this point there is only one caller of this function, check_file_access(). This takes that clean-up one step further and merges everything into check_file_access(). In addition it