Re: [Openvpn-devel] [PATCH 3/3] Print a --verb 1 warning when a connection uses compression

2018-06-04 Thread David Sommerseth
On 03/06/18 12:11, Steffan Karger wrote: > Can be suppressed by adding a "nowarn" flag to the compress options, for > those that are really sure that compression is fine for their use case. > > Signed-off-by: Steffan Karger > --- > This patch is also meant to discuss how far we want to go in

Re: [Openvpn-devel] [PATCH 3/3] Print a --verb 1 warning when a connection uses compression

2018-06-03 Thread Arne Schwabe
Am 03.06.18 um 12:11 schrieb Steffan Karger: > +msg(M_INFO, "WARNING: Compression enabled, might be insure. " > +"See --compress in the man page."); With my client maintainer hat on, this message is too vague. People will ask why compression is insure, because

Re: [Openvpn-devel] [PATCH 3/3] Print a --verb 1 warning when a connection uses compression

2018-06-03 Thread Selva Nair
Hi, On Sun, Jun 3, 2018 at 6:11 AM, Steffan Karger wrote: > Can be suppressed by adding a "nowarn" flag to the compress options, for > those that are really sure that compression is fine for their use case. > > Signed-off-by: Steffan Karger > --- > This patch is also meant to discuss how far we

[Openvpn-devel] [PATCH 3/3] Print a --verb 1 warning when a connection uses compression

2018-06-03 Thread Steffan Karger
Can be suppressed by adding a "nowarn" flag to the compress options, for those that are really sure that compression is fine for their use case. Signed-off-by: Steffan Karger --- This patch is also meant to discuss how far we want to go in warning users about using compression. I think this