[Openvpn-devel] [PATCH OpenVPN3] Add 'pull' to ignored options

2023-07-27 Thread Merten Fermont
Fixes error that --pull is an unknown option in client config. --- openvpn/client/cliopt.hpp | 1 + 1 file changed, 1 insertion(+) diff --git a/openvpn/client/cliopt.hpp b/openvpn/client/cliopt.hpp index f7be44a8..431791f3 100644 --- a/openvpn/client/cliopt.hpp +++ b/openvpn/client/cliopt.hpp @@ -7

Re: [Openvpn-devel] [PATCH OpenVPN3] Add 'pull' to ignored options

2023-07-27 Thread Arne Schwabe
Am 27.07.23 um 10:52 schrieb Merten Fermont: Fixes error that --pull is an unknown option in client config. --- openvpn/client/cliopt.hpp | 1 + 1 file changed, 1 insertion(+) diff --git a/openvpn/client/cliopt.hpp b/openvpn/client/cliopt.hpp index f7be44a8..431791f3 100644 --- a/openvpn/client/c

Re: [Openvpn-devel] [PATCH OpenVPN3] Add 'pull' to ignored options

2023-07-27 Thread Merten Fermont
Hi Arne, I changed my patch to check the client and client+pull options. Giving an error when neither options are declared. This however may break current implementations that depend on 'client' not being a required option? Greetings, Merten Subject: [PATCH] Check for client options Require 'c

Re: [Openvpn-devel] [PATCH OpenVPN3] Add 'pull' to ignored options

2023-07-27 Thread Arne Schwabe
Am 27.07.23 um 14:21 schrieb Merten Fermont: Hi Arne, I changed my patch to check the client and client+pull options. Giving an error when neither options are declared. This however may break current implementations that depend on 'client' not being a required option? Acked-By: Arne Schwabe

Re: [Openvpn-devel] [PATCH OpenVPN3] Add 'pull' to ignored options

2023-08-01 Thread David Sommerseth
On 27/07/2023 14:21, Merten Fermont wrote: Hi Arne, I changed my patch to check the client and client+pull options. Giving an error when neither options are declared. This however may break current implementations that depend on 'client' not being a required option? Greetings, Merten Subject:

Re: [Openvpn-devel] [PATCH OpenVPN3] Add 'pull' to ignored options

2024-03-06 Thread Frank Lichtenheld
On Tue, Aug 01, 2023 at 08:22:24PM +0200, David Sommerseth wrote: > On 27/07/2023 14:21, Merten Fermont wrote: > > Hi Arne, > > > > I changed my patch to check the client and client+pull options. > > Giving an error when neither options are declared. > > > > This however may break current impleme

Re: [Openvpn-devel] [PATCH OpenVPN3] Add 'pull' to ignored options

2024-03-08 Thread Frank Lichtenheld
On Fri, Mar 08, 2024 at 10:47:27AM +0100, Merten Fermont wrote: > Hi Frank, > > Arne has indeed applied a fix based on this patch. > > However, it looks like the case from this issue is not completely solved: > https://github.com/OpenVPN/openvpn3/issues/277 > If you have options "client" and "pul