Re: [Openvpn-devel] [PATCH applied] Re: Import some sample certificates into Windows store for testing

2023-03-16 Thread Gert Doering
Hi, On Thu, Mar 16, 2023 at 07:59:42AM -0400, Selva Nair wrote: > > I have tried testing this on a "real" Win10 VM, but I am missing some > > intricacies with the cert store - I wanted to see if certs are properly > > cleaned up, but I can't even see my own .p12 I have imported, so I am > > doing

Re: [Openvpn-devel] [PATCH applied] Re: Import some sample certificates into Windows store for testing

2023-03-16 Thread Selva Nair
> > > I have tried testing this on a "real" Win10 VM, but I am missing some > intricacies with the cert store - I wanted to see if certs are properly > cleaned up, but I can't even see my own .p12 I have imported, so I am > doing something wrong... This works for me: Run "certmgr" from a user com

[Openvpn-devel] [PATCH applied] Re: Import some sample certificates into Windows store for testing

2023-03-16 Thread Gert Doering
Acked-by: Gert Doering This is a welcome addition so we can have actual cryptoapi unit tests. The code looks reasonable, and GHA says "it passes"... Run ./unittests/cryptoapi_testdriver.exe [==] Running 2 test(s). [ RUN ] test_parse_hexstring [