Re: [Openvpn-devel] [PATCH v2 2/2] Cleanup route error and debug logging on Windows

2023-01-20 Thread Lev Stipakov
Hi, Stared at the code and slightly tested - works as expected. Nice that we display interface id: add_route_ipv6(2000::/3 -> 2001:db8:0:456::1 metric 200) IF 74 instead of device name: add_route_ipv6(2000::/3 -> 2001:db8:0:456::1 metric 200) dev OpenVPN Data Channel Offload Another thing

[Openvpn-devel] [PATCH v2 2/2] Cleanup route error and debug logging on Windows

2023-01-20 Thread selva . nair
From: Selva Nair Use a unified logging format for various route-methods - Route add/delete errors are always logged with M_WARN, so log only additional information (succeed/exists) with D_ROUTE. - Non-windows platforms log route errors with a prefix "ERROR:" and debug info with "ROUTE:".